Include repo name with borgmatic info --json output #800

New Issue

ginkel · 2023-12-19T11:05:52Z

ginkel commented

2023-12-19 11:05:52 +00:00

What I'd like to do and why

Hi there,

now that repositories (can) have names in borgmatic's configuration, it would be nice if the json output from borgmatic info --json included the repository name next to its id:

[
  {
    "archives": [...],
    "cache": {...},
    "encryption": {
      "mode": "repokey"
    },
    "repository": {
      "id": "<id>",
      "name": "myrepository",
      "last_modified": "2023-12-19T11:24:00.000000",
      "location": "ssh://<user>@<user>.your-storagebox.de:23/./borg/<host>"
    }
  },
  [...]
]

This would make creating (Prometheus) metrics for backup runs targeting multiple repositories much easier by being able to use a descriptive name to distinguish repos.

Thanks!

Other notes / implementation ideas

No response

### What I'd like to do and why Hi there, now that repositories (can) have names in borgmatic's configuration, it would be nice if the json output from `borgmatic info --json` included the repository name next to its id: ``` [ { "archives": [...], "cache": {...}, "encryption": { "mode": "repokey" }, "repository": { "id": "<id>", "name": "myrepository", "last_modified": "2023-12-19T11:24:00.000000", "location": "ssh://<user>@<user>.your-storagebox.de:23/./borg/<host>" } }, [...] ] ``` This would make creating (Prometheus) metrics for backup runs targeting multiple repositories much easier by being able to use a descriptive name to distinguish repos. Thanks! ### Other notes / implementation ideas _No response_

witten commented

2023-12-20 07:22:20 +00:00

Great idea! I have an implementation of this for all borgmatic actions that produce JSON output, but I need to write a few more tests. The new JSON field will be called label, as that's what it's called in configuration.

Great idea! I have an implementation of this for all borgmatic actions that produce JSON output, but I need to write a few more tests. The new JSON field will be called `label`, as that's what it's called in configuration.

witten referenced this issue from a commit

2023-12-20 17:18:05 +00:00

Add configured repository labels to the JSON output for all actions (#800).

witten commented

2023-12-20 17:19:07 +00:00

Okay, this is implemented in main and will be part of the next release. Thanks again for the suggestion!

👍 1

witten closed this issue

2023-12-20 17:19:07 +00:00

witten commented

2024-01-03 18:12:27 +00:00

Released in borgmatic 1.8.6!