Elevate warnings to errors or squash errors to warnings #798

New Issue

Closed

opened 2023-12-03 00:44:55 +00:00 by witten · 2 comments

witten commented 2023-12-03 00:44:55 +00:00

Owner

Copy Link

What I'd like to do and why

Borg recently added support for much more granular exit codes than just "success" (0), "warning" (1), and "error" (2). It would be great if borgmatic could take advantage of these exit codes as part of this ticket. Specifically, borgmatic users often want specific Borg errors/warnings (like permissions issues, file not found) to be either elevated to errors or squashed a warning, even if that's not how Borg treats them. So maybe there could be a borgmatic configuration options to accomplish that for specific Borg errors/warnings.

There are likely existing borgmatic tickets this may address.

Other notes / implementation ideas

The way to enable this feature in supported versions of Borg (beginning in 1.4.0alpha1) is to pass the following environment variable:

BORG_EXIT_CODES=modern

So borgmatic could always set that variable and, if the version of Borg installed supports it, then it'll return the new more granular exit codes. Otherwise it'll only return 0, 1, and 2 and any features implemented as part of this ticket won't work.

### What I'd like to do and why Borg recently [added support](https://github.com/borgbackup/borg/pull/7928) for [much more granular exit codes](https://github.com/ThomasWaldmann/borg/blob/new-rc-1.2/docs/internals/frontends.rst#message-ids) than just "success" (0), "warning" (1), and "error" (2). It would be great if borgmatic could take advantage of these exit codes as part of this ticket. Specifically, borgmatic users often want specific Borg errors/warnings (like permissions issues, file not found) to be either elevated to errors or squashed a warning, even if that's not how Borg treats them. So maybe there could be a borgmatic configuration options to accomplish that for specific Borg errors/warnings. There are likely existing borgmatic tickets this may address. ### Other notes / implementation ideas The way to enable this feature in supported versions of Borg (beginning in 1.4.0alpha1) is to pass the following environment variable: ``` BORG_EXIT_CODES=modern ``` So borgmatic could always set that variable and, if the version of Borg installed supports it, then it'll return the new more granular exit codes. Otherwise it'll only return 0, 1, and 2 and any features implemented as part of this ticket won't work.

witten referenced this issue 2023-12-23 02:03:58 +00:00

borgmatic ignores failure of underlying borg (at least in this circumstance) #787

witten referenced this issue 2024-01-12 00:44:38 +00:00

Permission denied does not result in failure (Continuation of #486) #709

witten referenced this issue from a commit 2024-01-21 19:35:10 +00:00

Elevate specific Borg warnings to errors or squash errors to warnings (#798).

witten commented 2024-01-21 19:35:31 +00:00

Author

Owner

Copy Link

Implemented in main!

Docs here: https://torsion.org/borgmatic/docs/how-to/customize-warnings-and-errors/

Implemented in main! Docs here: https://torsion.org/borgmatic/docs/how-to/customize-warnings-and-errors/

witten closed this issue 2024-01-21 19:35:31 +00:00

witten referenced this issue from a commit 2024-01-21 19:48:43 +00:00

Add documentation heading (#798).

witten referenced this issue from a commit 2024-01-21 22:47:48 +00:00

Rephrase documentation and link to docs on exit codes feature (#798).

witten commented 2024-01-21 22:57:02 +00:00

Author

Owner

Copy Link

Released in borgmatic 1.8.7!

Released in borgmatic 1.8.7!

witten referenced this issue 2024-01-24 23:19:54 +00:00

rcreate action broken with Borg 1.4 #820

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#798

No description provided.