borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
15
57
Fork 40
Code Issues 54 Pull Requests 1 Actions Packages Releases 121 Activity

Traceback when adding Repository to config file #794

New Issue
Closed
opened 2023-11-24 14:10:46 +00:00 by Jacksaur · 4 comments
Jacksaur commented 2023-11-24 14:10:46 +00:00
Copy Link

What I'm trying to do and why

When adding a repository to my config file, running borgmatic config validate to check results in a Python traceback.
The validate command worked perfectly when I used the example generated config and edited its paths directly, but the issue started when I tried to add a second repository. While attempting to locate the cause of the issue, I must have messed with the example config layout, as now the repository line will cause a traceback no matter what.

Traceback (most recent call last):
  File "/usr/local/bin/borgmatic", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/usr/local/lib/python3.11/site-packages/borgmatic/commands/borgmatic.py", line 844, in main
    configs, parse_logs = load_configurations(
                          ^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/borgmatic/commands/borgmatic.py", line 513, in load_configurations
    configs[config_filename], parse_logs = validate.parse_configuration(
                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/borgmatic/config/validate.py", line 118, in parse_configuration
    logs = normalize.normalize(config_filename, config)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/borgmatic/config/normalize.py", line 211, in normalize
    repository_path = repository_dict['path']
                      ~~~~~~~~~~~~~~~^^^^^^^^
TypeError: string indices must be integers, not 'str'

Removing the repository entries entirely results in the validate passing (Whilst warning that a repository hasn't been provided, of course).
As far as I can tell, my config file is formatted correctly. I've even directly pasted in the values from the example config hosted online, but still get a traceback.

Could my text editor be messing with the spacing or something somehow?

Steps to reproduce

Use attached config file with Borgmatic.
borgmatic config validate will result in a traceback.
Remove repository entries.
Config will validate successfully.

Actual behavior

No response

Expected behavior

No response

Other notes / implementation ideas

No response

borgmatic version

1.8.5

borgmatic installation method

Docker

Borg version

1.2.6

Python version

3.11.5

Database version (if applicable)

No response

Operating system and version

Host: Debian Container: Alpine

### What I'm trying to do and why When adding a repository to my config file, running `borgmatic config validate` to check results in a Python traceback. The validate command worked perfectly when I used the example generated config and edited its paths directly, but the issue started when I tried to add a second repository. While attempting to locate the cause of the issue, I must have messed with the example config layout, as now the repository line will cause a traceback no matter what. ``` Traceback (most recent call last): File "/usr/local/bin/borgmatic", line 8, in <module> sys.exit(main()) ^^^^^^ File "/usr/local/lib/python3.11/site-packages/borgmatic/commands/borgmatic.py", line 844, in main configs, parse_logs = load_configurations( ^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/borgmatic/commands/borgmatic.py", line 513, in load_configurations configs[config_filename], parse_logs = validate.parse_configuration( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/borgmatic/config/validate.py", line 118, in parse_configuration logs = normalize.normalize(config_filename, config) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/borgmatic/config/normalize.py", line 211, in normalize repository_path = repository_dict['path'] ~~~~~~~~~~~~~~~^^^^^^^^ TypeError: string indices must be integers, not 'str' ``` Removing the repository entries entirely results in the validate passing (Whilst warning that a repository hasn't been provided, of course). As far as I can tell, my config file is formatted correctly. I've even directly pasted in the values from the example config hosted online, but still get a traceback. Could my text editor be messing with the spacing or something somehow? ### Steps to reproduce Use attached config file with Borgmatic. `borgmatic config validate` will result in a traceback. Remove repository entries. Config will validate successfully. ### Actual behavior _No response_ ### Expected behavior _No response_ ### Other notes / implementation ideas _No response_ ### borgmatic version 1.8.5 ### borgmatic installation method Docker ### Borg version 1.2.6 ### Python version 3.11.5 ### Database version (if applicable) _No response_ ### Operating system and version Host: Debian Container: Alpine
config.zip
1.9 KiB
witten commented 2023-11-24 17:42:20 +00:00
Owner
Copy Link

What's going on is that borgmatic is interpreting the - .nobackup list item as part of the repositories list since it's not commented out—resulting in the traceback you're seeing. The work-around is to comment out that line so that it isn't treated as a repository.

I'm going to mark this as a bug though because an invalid configuration file shouldn't result in a borgmatic traceback.

What's going on is that borgmatic is interpreting the `- .nobackup` list item as part of the repositories list since it's not commented out—resulting in the traceback you're seeing. The work-around is to comment out that line so that it isn't treated as a repository. I'm going to mark this as a bug though because an invalid configuration file shouldn't result in a borgmatic traceback.
witten added the
bug
 label 2023-11-24 17:42:27 +00:00
Jacksaur commented 2023-11-24 17:44:18 +00:00
Author
Copy Link

Argh, I expected it'd be something silly with the formatting. I must have forgotten to uncomment the rest of the nobackup section when setting up. Cheers.

Argh, I expected it'd be something silly with the formatting. I must have forgotten to uncomment the rest of the nobackup section when setting up. Cheers.
👍 1
witten commented 2023-12-04 19:21:32 +00:00
Owner
Copy Link

Fixed in main!

Fixed in main!
witten commented 2024-01-03 18:12:19 +00:00
Owner
Copy Link

Released in borgmatic 1.8.6!

Released in borgmatic 1.8.6!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
spot-check
1.8.10
1.8.9
1.8.8
1.8.7
1.8.6
1.8.5
1.8.4
1.8.3
1.8.2
1.8.1
1.8.0
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.5.24
1.5.23
1.5.22
1.5.21
1.5.20
1.5.19
1.5.18
1.5.17
1.5.16
1.5.15
1.5.14
1.5.13
1.5.12
1.5.11
1.5.10
1.5.9
1.5.8
1.5.7
1.5.7.dev0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.22
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.26
1.3.25
1.3.24
1.3.23
1.3.22
1.3.21
1.3.20
1.3.19
1.3.18
1.3.17
1.3.16
1.3.15
1.3.14
1.3.13
1.3.12
1.3.11
1.3.10
1.3.9
1.3.8
1.3.7
1.3.6
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.18
1.2.17
1.2.16
1.2.15
1.2.14
1.2.13
1.2.12
1.2.11
1.2.10
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.3
1.0.2
1.0.1
1.0.0
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.7
0.0.6
0.0.5
0.0.4
0.0.3
0.0.2
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#794
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?