ruamel.yaml dependency is too restrictive #783

New Issue

Closed

opened 2023-11-07 14:44:12 +00:00 by kaechele · 3 comments

kaechele commented 2023-11-07 14:44:12 +00:00

Contributor

Copy Link

What I'm trying to do and why

The ruamel.yaml dependency is currently pinned at >0.15.0,<0.18.0.
Fedora now started shipping ruamel.yaml 0.18.2, so we're getting broken dependencies.

Borgmatic seems to work and test fine with ruamel.yaml 0.18.5.

Steps to reproduce

No response

Actual behavior

No response

Expected behavior

No response

Other notes / implementation ideas

No response

borgmatic version

No response

borgmatic installation method

No response

Borg version

No response

Python version

No response

Database version (if applicable)

No response

Operating system and version

No response

### What I'm trying to do and why The ruamel.yaml dependency is currently pinned at >0.15.0,<0.18.0. Fedora now started shipping ruamel.yaml 0.18.2, so we're getting broken dependencies. Borgmatic seems to work and test fine with ruamel.yaml 0.18.5. ### Steps to reproduce _No response_ ### Actual behavior _No response_ ### Expected behavior _No response_ ### Other notes / implementation ideas _No response_ ### borgmatic version _No response_ ### borgmatic installation method _No response_ ### Borg version _No response_ ### Python version _No response_ ### Database version (if applicable) _No response_ ### Operating system and version _No response_

witten commented 2023-11-07 16:55:02 +00:00

Owner

Copy Link

Thanks for bringing this to my attention! Newer versions of ruamel.yaml (0.18.x) actually break both config generation and end-to-end tests. So this is unfortunately not as straightforward as relaxing the version requirement. I'll see what can be done though.

Thanks for bringing this to my attention! Newer versions of ruamel.yaml (0.18.x) actually break both config generation and end-to-end tests. So this is unfortunately not as straightforward as relaxing the version requirement. I'll see what can be done though.

witten referenced this issue from a commit 2023-11-07 18:00:24 +00:00

Upgrade ruamel.yaml dependency to support version 0.18.x (#783).

witten commented 2023-11-07 18:00:41 +00:00

Owner

Copy Link

This has been implemented in main and will be part of the next release!

This has been implemented in main and will be part of the next release!

witten closed this issue 2023-11-07 18:00:41 +00:00

witten referenced this issue from a commit 2023-11-07 18:09:43 +00:00

Fix tests (#783).

witten commented 2023-11-20 05:23:03 +00:00

Owner

Copy Link

Just released with borgmatic 1.8.5!

Just released with borgmatic 1.8.5!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#783

No description provided.