Extract archive with --progress can't be canceled #761

New Issue

Closed

opened 2023-09-27 09:28:15 +00:00 by nicogodet · 3 comments

nicogodet commented 2023-09-27 09:28:15 +00:00

Copy Link

What I'm trying to do and why

$ borgmatic extract --archive ISLCACX02-26-09-2023_18:51 --progress

^CCalculating total archive size for the progress indicator (might take long for large archives)                                                                                 Traceback (most recent call last):
  File "/usr/local/bin/borgmatic", line 8, in <module>
    sys.exit(main())
  File "/opt/borg-env/lib/python3.8/site-packages/borgmatic/commands/borgmatic.py", line 877, in main
    or list(collect_configuration_run_summary_logs(configs, arguments))
  File "/opt/borg-env/lib/python3.8/site-packages/borgmatic/commands/borgmatic.py", line 758, in collect_configuration_run_summary_logs
    results = list(run_configuration(config_filename, config, arguments))
  File "/opt/borg-env/lib/python3.8/site-packages/borgmatic/commands/borgmatic.py", line 126, in run_configuration
    yield from run_actions(
  File "/opt/borg-env/lib/python3.8/site-packages/borgmatic/commands/borgmatic.py", line 361, in run_actions
    borgmatic.actions.extract.run_extract(
  File "/opt/borg-env/lib/python3.8/site-packages/borgmatic/actions/extract.py", line 39, in run_extract
    borgmatic.borg.extract.extract_archive(
  File "/opt/borg-env/lib/python3.8/site-packages/borgmatic/borg/extract.py", line 134, in extract_archive
    return execute_command(
  File "/opt/borg-env/lib/python3.8/site-packages/borgmatic/execute.py", line 233, in execute_command
    log_outputs(
  File "/opt/borg-env/lib/python3.8/site-packages/borgmatic/execute.py", line 131, in log_outputs
    exit_code = process.poll() if output_buffers else process.wait()
  File "/usr/lib/python3.8/subprocess.py", line 1083, in wait
    return self._wait(timeout=timeout)
  File "/usr/lib/python3.8/subprocess.py", line 1806, in _wait
    (pid, sts) = self._try_wait(0)
  File "/usr/lib/python3.8/subprocess.py", line 1764, in _try_wait
    (pid, sts) = os.waitpid(self.pid, wait_flags)
KeyboardInterrupt

ansys@islcalcx02:/home/Stockage/test$   0.0% Extracting: calculssd/Ansys/22F-209_MOE_Conde_Pommeroeul/v1/arrondi.mac                                                             ^C0.5% Extracting: calculssd/Ansys/22F-069_Pierre_Benite/9-Calculs_complementaires/4-Temporel/0-Colonne_sol/Histor/deplZ13.lis
ansys@islcalcx02:/home/Stockage/test$   0.6% Extracting: calculssd/Ansys/22F-069_Pierre_Benite/9-Calculs_complementaires/4-Temporel/3-Acc3/Sorties/pile1_Z164.5.lis              ^C1.8% Extracting: calculssd/Ansys/22F-069_Pierre_Benite/4-Temporel/0-Colonne_sol/Histor/deplZ6.lis
ansys@islcalcx02:/home/Stockage/test$ ^C
ansys@islcalcx02:/home/Stockage/test$ ^C
ansys@islcalcx02:/home/Stockage/test$ ^C
ansys@islcalcx02:/home/Stockage/test$   1.9% Extracting: calculssd/Ansys/22F-069_Pierre_Benite/4-Temporel/0-Colonne_sol/Histor/deplY7.lis                                        ^C
ansys@islcalcx02:/home/Stockage/test$ ^C
ansys@islcalcx02:/home/Stockage/test$   2.0% Extracting: calculssd/Ansys/22F-069_Pierre_Benite/4-Temporel/1-Acc1/Sorties/pile3_Z151.lis                                          logout Extracting: calculssd/Ansys/22F-126_THM/Commande_4/PxPlus_old/08-DS-COG800-85ans-9NO/THM/dpress.txt

After logout, extraction still in progress in background

Steps to reproduce

1. Start borgmatic extract with --progress argument
2. Try to cancel with CTRL-C
3. See

Actual behavior

No response

Expected behavior

No response

Other notes / implementation ideas

No response

borgmatic version

No response

borgmatic installation method

1.8.2

Borg version

1.2.6

Python version

3.8.10

Database version (if applicable)

No response

Operating system and version

Ubuntu 20.04.6 LTS

### What I'm trying to do and why `$ borgmatic extract --archive ISLCACX02-26-09-2023_18:51 --progress` ```console ^CCalculating total archive size for the progress indicator (might take long for large archives) Traceback (most recent call last): File "/usr/local/bin/borgmatic", line 8, in <module> sys.exit(main()) File "/opt/borg-env/lib/python3.8/site-packages/borgmatic/commands/borgmatic.py", line 877, in main or list(collect_configuration_run_summary_logs(configs, arguments)) File "/opt/borg-env/lib/python3.8/site-packages/borgmatic/commands/borgmatic.py", line 758, in collect_configuration_run_summary_logs results = list(run_configuration(config_filename, config, arguments)) File "/opt/borg-env/lib/python3.8/site-packages/borgmatic/commands/borgmatic.py", line 126, in run_configuration yield from run_actions( File "/opt/borg-env/lib/python3.8/site-packages/borgmatic/commands/borgmatic.py", line 361, in run_actions borgmatic.actions.extract.run_extract( File "/opt/borg-env/lib/python3.8/site-packages/borgmatic/actions/extract.py", line 39, in run_extract borgmatic.borg.extract.extract_archive( File "/opt/borg-env/lib/python3.8/site-packages/borgmatic/borg/extract.py", line 134, in extract_archive return execute_command( File "/opt/borg-env/lib/python3.8/site-packages/borgmatic/execute.py", line 233, in execute_command log_outputs( File "/opt/borg-env/lib/python3.8/site-packages/borgmatic/execute.py", line 131, in log_outputs exit_code = process.poll() if output_buffers else process.wait() File "/usr/lib/python3.8/subprocess.py", line 1083, in wait return self._wait(timeout=timeout) File "/usr/lib/python3.8/subprocess.py", line 1806, in _wait (pid, sts) = self._try_wait(0) File "/usr/lib/python3.8/subprocess.py", line 1764, in _try_wait (pid, sts) = os.waitpid(self.pid, wait_flags) KeyboardInterrupt ansys@islcalcx02:/home/Stockage/test$ 0.0% Extracting: calculssd/Ansys/22F-209_MOE_Conde_Pommeroeul/v1/arrondi.mac ^C0.5% Extracting: calculssd/Ansys/22F-069_Pierre_Benite/9-Calculs_complementaires/4-Temporel/0-Colonne_sol/Histor/deplZ13.lis ansys@islcalcx02:/home/Stockage/test$ 0.6% Extracting: calculssd/Ansys/22F-069_Pierre_Benite/9-Calculs_complementaires/4-Temporel/3-Acc3/Sorties/pile1_Z164.5.lis ^C1.8% Extracting: calculssd/Ansys/22F-069_Pierre_Benite/4-Temporel/0-Colonne_sol/Histor/deplZ6.lis ansys@islcalcx02:/home/Stockage/test$ ^C ansys@islcalcx02:/home/Stockage/test$ ^C ansys@islcalcx02:/home/Stockage/test$ ^C ansys@islcalcx02:/home/Stockage/test$ 1.9% Extracting: calculssd/Ansys/22F-069_Pierre_Benite/4-Temporel/0-Colonne_sol/Histor/deplY7.lis ^C ansys@islcalcx02:/home/Stockage/test$ ^C ansys@islcalcx02:/home/Stockage/test$ 2.0% Extracting: calculssd/Ansys/22F-069_Pierre_Benite/4-Temporel/1-Acc1/Sorties/pile3_Z151.lis logout Extracting: calculssd/Ansys/22F-126_THM/Commande_4/PxPlus_old/08-DS-COG800-85ans-9NO/THM/dpress.txt ``` After logout, extraction still in progress in background ### Steps to reproduce 1. Start borgmatic extract with `--progress` argument 2. Try to cancel with `CTRL-C` 3. See ### Actual behavior _No response_ ### Expected behavior _No response_ ### Other notes / implementation ideas _No response_ ### borgmatic version _No response_ ### borgmatic installation method 1.8.2 ### Borg version 1.2.6 ### Python version 3.8.10 ### Database version (if applicable) _No response_ ### Operating system and version Ubuntu 20.04.6 LTS

witten commented 2023-09-27 15:21:00 +00:00

Owner

Copy Link

Thanks for filing this! I've confirmed the behavior you're seeing, but I'm not yet sure what the cause might be.

Thanks for filing this! I've confirmed the behavior you're seeing, but I'm not yet sure what the cause might be.

witten added the

bug

label 2023-09-27 15:21:06 +00:00

witten referenced this issue from a commit 2023-09-27 15:52:14 +00:00

Fix for borgmatic not stopping Borg immediately when the user presses ctrl-C (#761).

witten commented 2023-09-27 15:52:43 +00:00

Owner

Copy Link

This has been fixed in main and should be part of the next release! Thanks again for the bug report.

This has been fixed in main and should be part of the next release! Thanks again for the bug report.

🚀 1

witten closed this issue 2023-09-27 15:52:43 +00:00

witten commented 2023-09-30 20:41:31 +00:00

Owner

Copy Link

This has been released as part of borgmatic 1.8.3!

This has been released as part of borgmatic 1.8.3!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

config-command-line

1.9.14

1.9.13

1.9.12

1.9.11

1.9.10

1.9.9

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels

blocked

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

No Label

bug

Milestone

No items

No Milestone

Assignees

Clear assignees

diivi import_bot witten

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#761

No description provided.