Unable to build using Python 3.7.0 #76

New Issue

Closed

opened 2018-07-14 22:51:16 +00:00 by jbravo · 7 comments

jbravo commented 2018-07-14 22:51:16 +00:00

Copy Link

Running pip install borgmatic on Python 3.7.0 fails to build due to an issue with the ruamel.yaml package, which is pinned at <0.15. This was raised with the project as issue #207 and they recommended testing against a newer version of the package, despite their guidance that production software should use <0.15.

I don't have time to test this right now, but it would be good to get this fixed soon as Python 3.7.0 is now the default version of Python installed by Homebrew.

Running `pip install borgmatic` on Python 3.7.0 fails to build due to an issue with the ruamel.yaml package, which is pinned at <0.15. This was raised with the project as issue [#207](https://bitbucket.org/ruamel/yaml/issues/207/0412-fails-to-install-with-python-37#comment-46744248) and they recommended testing against a newer version of the package, despite their guidance that production software should use <0.15. I don't have time to test this right now, but it would be good to get this fixed soon as Python 3.7.0 is now the [default version of Python installed by Homebrew](https://github.com/Homebrew/homebrew-core/blob/master/Formula/python.rb#L4).

witten commented 2018-07-14 22:53:24 +00:00

Owner

Copy Link

Thanks for reporting this. Sounds like #38 may be the solution? What's the issue you're seeing with the pinned ruamel.yaml?

Thanks for reporting this. Sounds like #38 may be the solution? What's the issue you're seeing with the pinned `ruamel.yaml`?

jbravo commented 2018-07-15 19:34:56 +00:00

Author

Copy Link

Yup, witten/borgmatic#38 would appear to be the solution.

Here's the output from the build:

$ pip3 --version
pip 10.0.1 from /usr/local/lib/python3.7/site-packages/pip (python 3.7)

$ pip3 install borgmatic
Collecting borgmatic
  Using cached https://files.pythonhosted.org/packages/77/92/1017f40877b10b64a02130c3052ad40685179853cd1b28d302ac64f071ff/borgmatic-1.2.0-py3-none-any.whl
Collecting ruamel.yaml<=0.15 (from borgmatic)
  Using cached https://files.pythonhosted.org/packages/10/aa/f31c8a858e23fe5b14c59e6a03ae80b4cb76353c184df48a582a55eb2674/ruamel.yaml-0.15.0.tar.gz
    Complete output from command python setup.py egg_info:
    /var/folders/tb/0fy391z92lz8tr0dc473wmlm0000gn/T/tmp_ruamel_0dorq8vr/test_ruamel_yaml.c:6:8: warning: explicitly assigning value of variable of type 'yaml_parser_t' (aka 'struct yaml_parser_s') to itself [-Wself-assign]
    parser = parser;  /* prevent warning */
    ~~~~~~ ^ ~~~~~~
    /var/folders/tb/0fy391z92lz8tr0dc473wmlm0000gn/T/tmp_ruamel_0dorq8vr/test_ruamel_yaml.c:6:10: warning: variable 'parser' is uninitialized when used here [-Wuninitialized]
    parser = parser;  /* prevent warning */
             ^~~~~~
    /var/folders/tb/0fy391z92lz8tr0dc473wmlm0000gn/T/tmp_ruamel_0dorq8vr/test_ruamel_yaml.c:5:1: note: variable 'parser' is declared here
    yaml_parser_t parser;
    ^
    2 warnings generated.
    Warning: 'keywords' should be a list, got type 'NoneType'
    sys.argv ['-c', 'egg_info', '--egg-base', 'pip-egg-info']
    test compiling test_ruamel_yaml
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/tb/0fy391z92lz8tr0dc473wmlm0000gn/T/pip-install-j2yu8bz8/ruamel.yaml/setup.py", line 858, in <module>
        main()
      File "/private/var/folders/tb/0fy391z92lz8tr0dc473wmlm0000gn/T/pip-install-j2yu8bz8/ruamel.yaml/setup.py", line 847, in main
        setup(**kw)
      File "/usr/local/lib/python3.7/site-packages/setuptools/__init__.py", line 129, in setup
        return distutils.core.setup(**attrs)
      File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/distutils/core.py", line 108, in setup
        _setup_distribution = dist = klass(attrs)
      File "/usr/local/lib/python3.7/site-packages/setuptools/dist.py", line 370, in __init__
        k: v for k, v in attrs.items()
      File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/distutils/dist.py", line 267, in __init__
        getattr(self.metadata, "set_" + key)(val)
      File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/distutils/dist.py", line 1203, in set_keywords
        self.keywords = _ensure_list(value, 'keywords')
      File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/distutils/dist.py", line 40, in _ensure_list
        value = list(value)
    TypeError: 'NoneType' object is not iterable

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /private/var/folders/tb/0fy391z92lz8tr0dc473wmlm0000gn/T/pip-install-j2yu8bz8/ruamel.yaml/

Yup, https://projects.torsion.org/witten/borgmatic/issues/38 would appear to be the solution. Here's the output from the build: ``` $ pip3 --version pip 10.0.1 from /usr/local/lib/python3.7/site-packages/pip (python 3.7) $ pip3 install borgmatic Collecting borgmatic Using cached https://files.pythonhosted.org/packages/77/92/1017f40877b10b64a02130c3052ad40685179853cd1b28d302ac64f071ff/borgmatic-1.2.0-py3-none-any.whl Collecting ruamel.yaml<=0.15 (from borgmatic) Using cached https://files.pythonhosted.org/packages/10/aa/f31c8a858e23fe5b14c59e6a03ae80b4cb76353c184df48a582a55eb2674/ruamel.yaml-0.15.0.tar.gz Complete output from command python setup.py egg_info: /var/folders/tb/0fy391z92lz8tr0dc473wmlm0000gn/T/tmp_ruamel_0dorq8vr/test_ruamel_yaml.c:6:8: warning: explicitly assigning value of variable of type 'yaml_parser_t' (aka 'struct yaml_parser_s') to itself [-Wself-assign] parser = parser; /* prevent warning */ ~~~~~~ ^ ~~~~~~ /var/folders/tb/0fy391z92lz8tr0dc473wmlm0000gn/T/tmp_ruamel_0dorq8vr/test_ruamel_yaml.c:6:10: warning: variable 'parser' is uninitialized when used here [-Wuninitialized] parser = parser; /* prevent warning */ ^~~~~~ /var/folders/tb/0fy391z92lz8tr0dc473wmlm0000gn/T/tmp_ruamel_0dorq8vr/test_ruamel_yaml.c:5:1: note: variable 'parser' is declared here yaml_parser_t parser; ^ 2 warnings generated. Warning: 'keywords' should be a list, got type 'NoneType' sys.argv ['-c', 'egg_info', '--egg-base', 'pip-egg-info'] test compiling test_ruamel_yaml Traceback (most recent call last): File "<string>", line 1, in <module> File "/private/var/folders/tb/0fy391z92lz8tr0dc473wmlm0000gn/T/pip-install-j2yu8bz8/ruamel.yaml/setup.py", line 858, in <module> main() File "/private/var/folders/tb/0fy391z92lz8tr0dc473wmlm0000gn/T/pip-install-j2yu8bz8/ruamel.yaml/setup.py", line 847, in main setup(**kw) File "/usr/local/lib/python3.7/site-packages/setuptools/__init__.py", line 129, in setup return distutils.core.setup(**attrs) File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/distutils/core.py", line 108, in setup _setup_distribution = dist = klass(attrs) File "/usr/local/lib/python3.7/site-packages/setuptools/dist.py", line 370, in __init__ k: v for k, v in attrs.items() File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/distutils/dist.py", line 267, in __init__ getattr(self.metadata, "set_" + key)(val) File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/distutils/dist.py", line 1203, in set_keywords self.keywords = _ensure_list(value, 'keywords') File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/distutils/dist.py", line 40, in _ensure_list value = list(value) TypeError: 'NoneType' object is not iterable ---------------------------------------- Command "python setup.py egg_info" failed with error code 1 in /private/var/folders/tb/0fy391z92lz8tr0dc473wmlm0000gn/T/pip-install-j2yu8bz8/ruamel.yaml/ ```

witten added the bug label 2018-07-22 18:02:26 +00:00

witten commented 2018-07-22 18:04:54 +00:00

Owner

Copy Link

I was able to reproduce traceback this within the python:3.7 Docker image.

I was able to reproduce traceback this within the `python:3.7` Docker image.

witten referenced this issue from a commit 2018-07-22 18:25:38 +00:00

Upgrade ruamel.yaml compatibility version range and fix support for Python 3.7 (#38, #76).

witten commented 2018-07-22 18:26:57 +00:00

Owner

Copy Link

Just fixed in master. The fix will go out in the next release.

Just fixed in master. The fix will go out in the next release.

witten closed this issue 2018-07-22 18:26:57 +00:00

jbravo commented 2018-07-27 11:58:14 +00:00

Author

Copy Link

Thanks for this. Would be great if you could cut a new release soon 😄

Thanks for this. Would be great if you could cut a new release soon :smile:

witten commented 2018-07-29 05:33:08 +00:00

Owner

Copy Link

Just released in borgmatic 1.2.1! Enjoy.

Just released in borgmatic 1.2.1! Enjoy.

jbravo commented 2018-08-01 12:48:07 +00:00

Author

Copy Link

Awesome. Thanks 👍

Awesome. Thanks 👍

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

command-hook-steps

2.0.12

2.0.11

2.0.10

2.0.9

2.0.8

2.0.7

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.9.14

1.9.13

1.9.12

1.9.11

1.9.10

1.9.9

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels

blocked

breaking

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

No Label bug

Milestone

No items

No Milestone

Assignees

Clear assignees

witten

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#76