borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
15
57
Fork 40
Code Issues 54 Pull Requests 1 Actions Packages Releases 121 Activity

MariaDB database restore does not work with borgmatic >=1.8.0 #738

New Issue
Closed
opened 2023-08-08 21:22:01 +00:00 by mrclschstr · 9 comments
mrclschstr commented 2023-08-08 21:22:01 +00:00
Copy Link

What I'm trying to do and why

I'm having a hard time describing my problem, but I'll try to keep it to the essentials. If important details are missing, I can of course provide them!

I am running an all-container Nextcloud setup consisting of four containers: Nextcloud, MariaDB, Redis and borgmatic. The borgmatic container backs up the Nextcloud data and the MariaDB database to my Hetzner storage box once a day.

In recent tests I noticed that the database restore with borgmatic since version 1.8.0 does not work anymore. No data is restored and no error messages are generated during the restore. With version 1.7.15 the restore still works without problems. For comparison I have executed the command borgmatic restore --archive latest --verbosity 2 with borgmatic version 1.7.15 as well as with version 1.8.1 (see attached files).

If you compare the two files, you can see that with the old borgmatic version the hook restore_database_dump is executed correctly. However, this is completely missing when running the restore with version 1.8.1.

Steps to reproduce

I am currently working on a minimal example. I hope that my problem is basically recognizable from the attached command outputs (see above).

Actual behavior

The database restore does not work using borgmatic version >=1.8.0. No tables are restored, but no error message is shown.

Expected behavior

The database restore works like in borgmatic version 1.7.15.

Other notes / implementation ideas

No response

borgmatic version

borgmatic 1.8.1

borgmatic installation method

Container (https://github.com/modem7/docker-borgmatic)

Borg version

borg 1.2.4

Python version

python 3.11.4

Database version (if applicable)

10.5.21-MariaDB

Operating system and version

Ubuntu 22.04.3 LTS

### What I'm trying to do and why I'm having a hard time describing my problem, but I'll try to keep it to the essentials. If important details are missing, I can of course provide them! I am running an all-container Nextcloud setup consisting of four containers: Nextcloud, MariaDB, Redis and borgmatic. The borgmatic container backs up the Nextcloud data and the MariaDB database to my Hetzner storage box once a day. In recent tests I noticed that the database restore with borgmatic since version 1.8.0 does not work anymore. No data is restored and no error messages are generated during the restore. With version 1.7.15 the restore still works without problems. For comparison I have executed the command `borgmatic restore --archive latest --verbosity 2` with borgmatic version 1.7.15 as well as with version 1.8.1 (see attached files). If you compare the two files, you can see that with the old borgmatic version the hook `restore_database_dump` is executed correctly. However, this is completely missing when running the restore with version 1.8.1. ### Steps to reproduce I am currently working on a minimal example. I hope that my problem is basically recognizable from the attached command outputs (see above). ### Actual behavior The database restore does not work using borgmatic version >=1.8.0. No tables are restored, but no error message is shown. ### Expected behavior The database restore works like in borgmatic version 1.7.15. ### Other notes / implementation ideas _No response_ ### borgmatic version borgmatic 1.8.1 ### borgmatic installation method Container (https://github.com/modem7/docker-borgmatic) ### Borg version borg 1.2.4 ### Python version python 3.11.4 ### Database version (if applicable) 10.5.21-MariaDB ### Operating system and version Ubuntu 22.04.3 LTS
mariadb_restore_v1.7.15.txt
4.9 KiB
mariadb_restore_v1.8.1.txt
3.5 KiB
witten commented 2023-08-08 21:29:27 +00:00
Owner
Copy Link

Thanks for filing this and including detailed logs! Nothing obvious comes to mind when looking at them though, so I'll see if I can repro this locally or at minimum figure out where something might be going wrong in the code.

Thanks for filing this and including detailed logs! Nothing obvious comes to mind when looking at them though, so I'll see if I can repro this locally or at minimum figure out where something might be going wrong in the code.
witten added the
bug
 label 2023-08-08 21:29:37 +00:00
witten commented 2023-08-08 21:37:58 +00:00
Owner
Copy Link

Good news: It repros locally here in 1.8.0, 1.8.1, and main. If I had to guess, it would be that this issue is breakage from the configuration file format change to remove sections (#721). I'll dig into the code and let you know what I find.

EDIT: Looks like this isn't just MySQL/MariaDB. Other database hooks are similarly broken for restore.

Good news: It repros locally here in 1.8.0, 1.8.1, and main. If I had to guess, it would be that this issue is breakage from the configuration file format change to remove sections (#721). I'll dig into the code and let you know what I find. EDIT: Looks like this isn't just MySQL/MariaDB. Other database hooks are similarly broken for restore.
witten commented 2023-08-08 22:24:27 +00:00
Owner
Copy Link

Another update: I have a fix in hand, but I'm hoping to write some failing automated tests before making the change so as to catch this sort of regression in the future.

Another update: I have a fix in hand, but I'm hoping to write some failing automated tests before making the change so as to catch this sort of regression in the future.
❤️ 1
mrclschstr commented 2023-08-09 05:41:16 +00:00
Author
Copy Link

Wow, thanks for the quick feedback. I assume that my minimal example is no longer needed?

I'm very looking forward to the fix. Keep up the good work!

Wow, thanks for the quick feedback. I assume that my minimal example is no longer needed? I'm very looking forward to the fix. Keep up the good work!
witten commented 2023-08-09 05:42:28 +00:00
Owner
Copy Link

Wow, thanks for the quick feedback. I assume that my minimal example is no longer needed?

That's correct!

I'm very looking forward to the fix. Keep up the good work!

Thanks, I'll keep you posted.

> Wow, thanks for the quick feedback. I assume that my minimal example is no longer needed? That's correct! > I'm very looking forward to the fix. Keep up the good work! Thanks, I'll keep you posted.
witten commented 2023-08-10 05:51:15 +00:00
Owner
Copy Link

An update: The end-to-end tests for this are proving tricky, likely because restores being disabled was masking latent issues with at least one of the database systems (MongoDB, for starters). I'm digging into those issues now, but it make take a while. I do think all of this underscores the need for better automated test coverage on restores—which will hopefully be in place after this work is done.

An update: The end-to-end tests for this are proving tricky, likely because restores being disabled was masking latent issues with at least one of the database systems (MongoDB, for starters). I'm digging into those issues now, but it make take a while. I do think all of this underscores the need for better automated test coverage on restores—which will hopefully be in place after this work is done.
🚀 1
witten commented 2023-08-14 19:57:36 +00:00
Owner
Copy Link

This has been fixed and released in borgmatic 1.8.2. The automated tests were a huge pain, but I'm glad they're in place now. Thanks again for the bug report, and please let me know if you have any further problems with this.

This has been fixed and released in borgmatic 1.8.2. The automated tests were a huge pain, but I'm glad they're in place now. Thanks again for the bug report, and please let me know if you have any further problems with this.
mrclschstr commented 2023-08-15 17:14:10 +00:00
Author
Copy Link

Restoring databases works again. Thank you for your quick fix!

Restoring databases works again. Thank you for your quick fix!
witten commented 2023-08-15 17:52:36 +00:00
Owner
Copy Link

Glad to hear it!

Glad to hear it!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
spot-check
1.8.10
1.8.9
1.8.8
1.8.7
1.8.6
1.8.5
1.8.4
1.8.3
1.8.2
1.8.1
1.8.0
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.5.24
1.5.23
1.5.22
1.5.21
1.5.20
1.5.19
1.5.18
1.5.17
1.5.16
1.5.15
1.5.14
1.5.13
1.5.12
1.5.11
1.5.10
1.5.9
1.5.8
1.5.7
1.5.7.dev0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.22
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.26
1.3.25
1.3.24
1.3.23
1.3.22
1.3.21
1.3.20
1.3.19
1.3.18
1.3.17
1.3.16
1.3.15
1.3.14
1.3.13
1.3.12
1.3.11
1.3.10
1.3.9
1.3.8
1.3.7
1.3.6
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.18
1.2.17
1.2.16
1.2.15
1.2.14
1.2.13
1.2.12
1.2.11
1.2.10
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.3
1.0.2
1.0.1
1.0.0
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.7
0.0.6
0.0.5
0.0.4
0.0.3
0.0.2
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#738
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?