How to catch warnings for files that are not backed up? #733

New Issue

Closed

opened 2023-07-28 17:37:56 +00:00 by shukon · 2 comments

shukon commented 2023-07-28 17:37:56 +00:00

Copy Link

What I'm trying to do and why

I just checked the health of my backups and noticed that there are files not being backed up - some due to being sqlite databases I didn't know about that changed, some due to permission errors.
However, Borgs return code is 1 for warning. And borgmatic only considers return codes of > 2 errors, because return code 1 is "just a warning". Now this was changed for the borg check. But not for borg create.
I would basically like my healthcheck to fail, if some files failed to back up. Otherwise I need to start monitoring borgmatic logs for warnings, because I'd like to know about issues during backups.
Possibly I'm thinking this all wrong, since I couldn't find any other issues about this. But I cannot wrap my head around the fact that files not being backed up is still considered a successful backup.
Thanks for the amazing piece of software ❤️

### What I'm trying to do and why I just checked the health of my backups and noticed that there are files not being backed up - some due to being sqlite databases I didn't know about that changed, some due to permission errors. However, [Borgs return code](https://borgbackup.readthedocs.io/en/stable/usage/general.html#return-codes) is 1 for warning. And borgmatic only considers [return codes of > 2 errors](https://github.com/borgmatic-collective/borgmatic/blob/c11dcdef0addd852c030bc713689802d88dd6cae/borgmatic/execute.py#L11), because return code 1 is "just a warning". Now this was [changed](https://projects.torsion.org/borgmatic-collective/borgmatic/issues/247#issuecomment-2159) for the `borg check`. But not for `borg create`. I would basically like my healthcheck to fail, if some files failed to back up. Otherwise I need to start monitoring borgmatic logs for warnings, because I'd like to know about issues during backups. Possibly I'm thinking this all wrong, since I couldn't find any other issues about this. But I cannot wrap my head around the fact that files not being backed up is still considered a successful backup. Thanks for the amazing piece of software :heart:

witten commented 2023-07-29 04:41:59 +00:00

Owner

Copy Link

Thanks for taking the time to file this! However I do think it's a duplicate of #709. The existing "source_directories_must_exist" option will cause borgmatic to fail if a source directory is missing, but it won't do anything if there's a permission error on some other file within a source directory. Anyway, I recommend closing this in favor of #709 and then following along with the issue there (and adding any additional thoughts you may have).

Related: borgmatic does have a SQLite hook integration, so you may be able to use that instead of hitting permissions errors on in-use SQLite files.

Thanks for taking the time to file this! However I do think it's a duplicate of #709. The existing "source_directories_must_exist" option will cause borgmatic to fail if a source directory is missing, but it won't do anything if there's a permission error on some other file _within_ a source directory. Anyway, I recommend closing this in favor of #709 and then following along with the issue there (and adding any additional thoughts you may have). Related: borgmatic does have a SQLite hook integration, so you may be able to use that instead of hitting permissions errors on in-use SQLite files.

shukon commented 2023-07-29 10:44:52 +00:00

Author

Copy Link

Thanks a lot for the quick reply and the hint to #709 - I somehow missed it, probably bad search terms. Sorry.

(also thanks for the SQLite hook note - I usually use it, this was more about general backup healthchecks for all sorts of things)

Thanks a lot for the quick reply and the hint to #709 - I somehow missed it, probably bad search terms. Sorry. (also thanks for the SQLite hook note - I usually use it, this was more about general backup healthchecks for all sorts of things)

👍 1

shukon closed this issue 2023-07-29 10:44:52 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#733

No description provided.