borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
15
57
Fork 40
Code Issues 54 Pull Requests 1 Actions Packages Releases 121 Activity

check --repair interactive question gets immediately answered #730

New Issue
Closed
opened 2023-07-22 21:42:44 +00:00 by nebulon42 · 5 comments
nebulon42 commented 2023-07-22 21:42:44 +00:00
Contributor
Copy Link

What I'm trying to do and why

I'm trying to repair a repository with problems but the interactive question gets immediately answered with NO and then the command aborts.

Steps to reproduce

Run borgmatic check --repair on 1.8.0.

Actual behavior

borg --version --debug --show-rc
ssh://user@url/./repo: Running actions for repository
/path/to/config.yml: No commands to run for pre-actions hook
/path/to/config.yml: No commands to run for pre-check hook
ssh://user@url/./repo: Running consistency checks
borg info --json ssh://user@url/./repo
borg check --repair --debug --show-rc ssh://user@url/./repo >
using builtin fallback logging configuration
35 self tests completed in 0.13 seconds
SSH command line: ['ssh', '-o', 'IdentitiesOnly=yes', '-i', '/path/to/key', '-p', '23', 'user@url', 'borg', 'serve', '--umask=077', '--debug']
Remote: using builtin fallback logging configuration
Remote: 33 self tests completed in 0.10 seconds
Remote: using builtin fallback logging configuration
Remote: Initialized logging system for JSON-based protocol
Remote: Resolving repository path b'/./repo'
Remote: Resolved repository path to '/repo'
This is a potentially dangerous function.
check --repair might lead to data loss (for kinds of corruption it is not
capable of dealing with). BE VERY CAREFUL!

Type 'YES' if you understand this and want to continue: NO (from BORG_CHECK_I_KNOW_WHAT_I_AM_DOING)
Aborting.
RemoteRepository: 139 B bytes sent, 838 B bytes received, 2 messages sent
terminating with error status, rc 2

Expected behavior

The question should be answered in interactive mode.

Other notes / implementation ideas

Could this be a regression from #724? I did not change anything in the config. Are there adjustments necessary?

borgmatic version

1.8.0

borgmatic installation method

No response

Borg version

No response

Python version

No response

Database version (if applicable)

No response

Operating system and version

No response

### What I'm trying to do and why I'm trying to repair a repository with problems but the interactive question gets immediately answered with NO and then the command aborts. ### Steps to reproduce Run borgmatic check --repair on 1.8.0. ### Actual behavior borg --version --debug --show-rc ssh://user@url/./repo: Running actions for repository /path/to/config.yml: No commands to run for pre-actions hook /path/to/config.yml: No commands to run for pre-check hook ssh://user@url/./repo: Running consistency checks borg info --json ssh://user@url/./repo borg check --repair --debug --show-rc ssh://user@url/./repo > using builtin fallback logging configuration 35 self tests completed in 0.13 seconds SSH command line: ['ssh', '-o', 'IdentitiesOnly=yes', '-i', '/path/to/key', '-p', '23', 'user@url', 'borg', 'serve', '--umask=077', '--debug'] Remote: using builtin fallback logging configuration Remote: 33 self tests completed in 0.10 seconds Remote: using builtin fallback logging configuration Remote: Initialized logging system for JSON-based protocol Remote: Resolving repository path b'/./repo' Remote: Resolved repository path to '/repo' This is a potentially dangerous function. check --repair might lead to data loss (for kinds of corruption it is not capable of dealing with). BE VERY CAREFUL! Type 'YES' if you understand this and want to continue: NO (from BORG_CHECK_I_KNOW_WHAT_I_AM_DOING) Aborting. RemoteRepository: 139 B bytes sent, 838 B bytes received, 2 messages sent terminating with error status, rc 2 ### Expected behavior The question should be answered in interactive mode. ### Other notes / implementation ideas Could this be a regression from #724? I did not change anything in the config. Are there adjustments necessary? ### borgmatic version 1.8.0 ### borgmatic installation method _No response_ ### Borg version _No response_ ### Python version _No response_ ### Database version (if applicable) _No response_ ### Operating system and version _No response_
witten commented 2023-07-22 21:51:47 +00:00
Owner
Copy Link

Thanks for taking the time to file this! I can repro it locally. And yes, good find, I think this is very likely a regression from #724 in that an incorrect default is being applied. Looking into it..

Thanks for taking the time to file this! I can repro it locally. And yes, good find, I think this is very likely a regression from #724 in that an incorrect default is being applied. Looking into it..
witten added the
bug
 label 2023-07-22 21:51:53 +00:00
witten commented 2023-07-22 21:54:30 +00:00
Owner
Copy Link

And by the way, you can work around this issue right now by specifying check_i_know_what_i_am_doing: true in your borgmatic configuration. That will unblock your check --repair, although be aware that it'll also bypass the interactive prompt.

And by the way, you can work around this issue right now by specifying `check_i_know_what_i_am_doing: true` in your borgmatic configuration. That will unblock your `check --repair`, although be aware that it'll also bypass the interactive prompt.
👍 1
nebulon42 commented 2023-07-22 22:00:42 +00:00
Author
Contributor
Copy Link

Yes, doing that now. :)

Yes, doing that now. :)
witten commented 2023-07-22 22:28:14 +00:00
Owner
Copy Link

This has been fixed in main and will be part of the next release. Now, BORG_* environment variables are no longer passed to Borg unless the corresponding borgmatic options are actually set. Thanks again for reporting this!

This has been fixed in main and will be part of the next release. Now, `BORG_*` environment variables are no longer passed to Borg unless the corresponding borgmatic options are actually set. Thanks again for reporting this!
witten commented 2023-08-04 04:59:31 +00:00
Owner
Copy Link

Just released in borgmatic 1.8.1!

Just released in borgmatic 1.8.1!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
spot-check
1.8.10
1.8.9
1.8.8
1.8.7
1.8.6
1.8.5
1.8.4
1.8.3
1.8.2
1.8.1
1.8.0
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.5.24
1.5.23
1.5.22
1.5.21
1.5.20
1.5.19
1.5.18
1.5.17
1.5.16
1.5.15
1.5.14
1.5.13
1.5.12
1.5.11
1.5.10
1.5.9
1.5.8
1.5.7
1.5.7.dev0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.22
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.26
1.3.25
1.3.24
1.3.23
1.3.22
1.3.21
1.3.20
1.3.19
1.3.18
1.3.17
1.3.16
1.3.15
1.3.14
1.3.13
1.3.12
1.3.11
1.3.10
1.3.9
1.3.8
1.3.7
1.3.6
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.18
1.2.17
1.2.16
1.2.15
1.2.14
1.2.13
1.2.12
1.2.11
1.2.10
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.3
1.0.2
1.0.1
1.0.0
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.7
0.0.6
0.0.5
0.0.4
0.0.3
0.0.2
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#730
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?