Invalid --keep-exclude-tags flag being passed to prune command #728

New Issue

Closed

opened 2023-07-22 11:39:18 +00:00 by mstarzinger · 5 comments

mstarzinger commented 2023-07-22 11:39:18 +00:00

Copy Link

What I'm trying to do and why

I have a configuration file with the keep_exclude_tags: True option and am trying to run the borgmatic prune command. This leads to Borgmatic passing the invalid command-line flag --keep-exclude-tags to Borg's borg prune command.

Steps to reproduce

Run borgmatic prune with a configuration file containing the keep_exclude_tags: True option.

Actual behavior

Borgmatic is passing the --keep-exclude-tags flag to Borg's prune command.

[XXX@XXX ~]$ borgmatic prune
XXXXXX: Error running actions for repository
Command 'borg prune --keep-exclude-tags True --keep-daily 7 --keep-weekly 4 --keep-monthly 6 ssh://XXXXXX/share/Backup/XXXXXX' returned non-zero exit status 2.
/home/XXX/.config/borgmatic/config.yaml: An error occurred

summary:
/home/XXX/.config/borgmatic/config.yaml: An error occurred
XXXXXX: Error running actions for repository
usage: borg [-V] [-h] [--critical] [--error] [--warning] [--info] [--debug]
            [--debug-topic TOPIC] [-p] [--iec] [--log-json]
            [--lock-wait SECONDS] [--bypass-lock] [--show-version] [--show-rc]
            [--umask M] [--remote-path PATH] [--remote-ratelimit RATE]
            [--upload-ratelimit RATE] [--remote-buffer UPLOAD_BUFFER]
            [--upload-buffer UPLOAD_BUFFER] [--consider-part-files]
            [--debug-profile FILE] [--rsh RSH]
            <command> ...
borg: error: unrecognized arguments: --keep-exclude-tags ssh://XXXXXX/share/Backup/XXXXXX
Command 'borg prune --keep-exclude-tags True --keep-daily 7 --keep-weekly 4 --keep-monthly 6 ssh://XXXXXX/share/Backup/XXXXXX' returned non-zero exit status 2.

Need some help? https://torsion.org/borgmatic/#issues

Expected behavior

Borgmatic should not pass the --keep-exclude-tags flag to the prune command.

Other notes / implementation ideas

No response

borgmatic version

1.8.0

borgmatic installation method

No response

Borg version

borg 1.2.4

Python version

No response

Database version (if applicable)

No response

Operating system and version

No response

### What I'm trying to do and why I have a configuration file with the `keep_exclude_tags: True` option and am trying to run the `borgmatic prune` command. This leads to Borgmatic passing the invalid command-line flag `--keep-exclude-tags` to Borg's `borg prune` command. ### Steps to reproduce Run `borgmatic prune` with a configuration file containing the `keep_exclude_tags: True` option. ### Actual behavior Borgmatic is passing the `--keep-exclude-tags` flag to Borg's `prune` command. ``` [XXX@XXX ~]$ borgmatic prune XXXXXX: Error running actions for repository Command 'borg prune --keep-exclude-tags True --keep-daily 7 --keep-weekly 4 --keep-monthly 6 ssh://XXXXXX/share/Backup/XXXXXX' returned non-zero exit status 2. /home/XXX/.config/borgmatic/config.yaml: An error occurred summary: /home/XXX/.config/borgmatic/config.yaml: An error occurred XXXXXX: Error running actions for repository usage: borg [-V] [-h] [--critical] [--error] [--warning] [--info] [--debug] [--debug-topic TOPIC] [-p] [--iec] [--log-json] [--lock-wait SECONDS] [--bypass-lock] [--show-version] [--show-rc] [--umask M] [--remote-path PATH] [--remote-ratelimit RATE] [--upload-ratelimit RATE] [--remote-buffer UPLOAD_BUFFER] [--upload-buffer UPLOAD_BUFFER] [--consider-part-files] [--debug-profile FILE] [--rsh RSH] <command> ... borg: error: unrecognized arguments: --keep-exclude-tags ssh://XXXXXX/share/Backup/XXXXXX Command 'borg prune --keep-exclude-tags True --keep-daily 7 --keep-weekly 4 --keep-monthly 6 ssh://XXXXXX/share/Backup/XXXXXX' returned non-zero exit status 2. Need some help? https://torsion.org/borgmatic/#issues ``` ### Expected behavior Borgmatic should not pass the `--keep-exclude-tags` flag to the `prune` command. ### Other notes / implementation ideas _No response_ ### borgmatic version 1.8.0 ### borgmatic installation method _No response_ ### Borg version borg 1.2.4 ### Python version _No response_ ### Database version (if applicable) _No response_ ### Operating system and version _No response_

witten commented 2023-07-22 17:15:28 +00:00

Owner

Copy Link

Thank you for taking the time to file this! This definitely looks like a regression introduced by 1.8.0, and I've repro'd it locally.

Thank you for taking the time to file this! This definitely looks like a regression introduced by 1.8.0, and I've repro'd it locally.

witten added the bug label 2023-07-22 17:15:35 +00:00

witten referenced this issue from a commit 2023-07-22 17:27:06 +00:00

Fix for "prune" action error when using the "keep_exclude_tags" option in configuration (#728).

witten commented 2023-07-22 17:27:21 +00:00

Owner

Copy Link

This is now fixed in main and will be part of the next release. Thanks again!

This is now fixed in main and will be part of the next release. Thanks again!

witten closed this issue 2023-07-22 17:27:21 +00:00

mstarzinger commented 2023-07-22 18:21:32 +00:00

Author

Copy Link

Awesome! Thanks for the quick fix.

Awesome! Thanks for the quick fix.

👍 1

witten commented 2023-08-04 04:59:41 +00:00

Owner

Copy Link

Just released in borgmatic 1.8.1!

Just released in borgmatic 1.8.1!

🎉 1

mstarzinger commented 2023-08-04 15:57:44 +00:00

Author

Copy Link

Thanks again! I can confirm that the issue is resolved with the Arch Linux distribution package of the Borgmatic 1.8.1 release.

Thanks again! I can confirm that the issue is resolved with the Arch Linux distribution package of the Borgmatic 1.8.1 release.

👍 1

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

command-hook-steps

2.0.11

2.0.10

2.0.9

2.0.8

2.0.7

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.9.14

1.9.13

1.9.12

1.9.11

1.9.10

1.9.9

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels

blocked

breaking

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

No Label bug

Milestone

No items

No Milestone

Assignees

Clear assignees

witten

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#728