borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
15
57
Fork 40
Code Issues 54 Pull Requests 1 Actions Packages Releases 121 Activity

Add a config entry for BORG_CHECK_I_KNOW_WHAT_I_AM_DOING env var #724

Merged
witten merged 1 commits from arakmar/borgmatic:env_check_i_know_what_i_am_doing into main 2023-07-10 16:38:09 +00:00
Conversation 3 Commits 1 Files Changed 3 +26 -2
arakmar commented 2023-07-09 09:50:08 +00:00
Contributor
Copy Link

It can be very useful especially with recent index count mismatch bugs in borg 1.2.x

It can be very useful especially with recent index count mismatch bugs in borg 1.2.x
arakmar added 1 commit 2023-07-09 09:50:09 +00:00
arakmar force-pushed env_check_i_know_what_i_am_doing from e0a39c9bbe to 8f1d4a339e 2023-07-09 10:41:31 +00:00 Compare
arakmar force-pushed env_check_i_know_what_i_am_doing from 8f1d4a339e to 1174eda171 2023-07-09 10:43:21 +00:00 Compare
arakmar force-pushed env_check_i_know_what_i_am_doing from 1174eda171 to 061a74cbc2 2023-07-09 10:48:30 +00:00 Compare
arakmar force-pushed env_check_i_know_what_i_am_doing from 061a74cbc2 to 2cdb44debd 2023-07-09 10:53:58 +00:00 Compare
arakmar force-pushed env_check_i_know_what_i_am_doing from 2cdb44debd to d05ec9fa2c 2023-07-09 10:54:25 +00:00 Compare
witten requested changes 2023-07-09 23:22:23 +00:00
witten left a comment
Owner
Copy Link

Thanks for submitting this and updating tests as well! It generally looks good except for the case-sensitivity issue. (See comments.)

Thanks for submitting this and updating tests as well! It generally looks good except for the case-sensitivity issue. (See comments.)
borgmatic/borg/environment.py Outdated
@ -36,3 +37,3 @@
) in DEFAULT_BOOL_OPTION_TO_ENVIRONMENT_VARIABLE.items():
value = storage_config.get(option_name, False)
environment[environment_variable_name] = 'yes' if value else 'no'
environment[environment_variable_name] = 'YES' if value else 'NO'
witten commented 2023-07-09 23:20:41 +00:00
Owner
Copy Link

It looks like this will break some of the other environment variables due to the fact that the value: 1. is case-sensitive, and 2. has different expectations for different Borg environment variables. See the documentation here for details: https://borgbackup.readthedocs.io/en/stable/usage/general.html#environment-variables

It looks like this will break some of the other environment variables due to the fact that the value: 1. is case-sensitive, and 2. has different expectations for different Borg environment variables. See the documentation here for details: https://borgbackup.readthedocs.io/en/stable/usage/general.html#environment-variables
arakmar commented 2023-07-10 08:39:41 +00:00
Author
Contributor
Copy Link

In theory, it shouldn't be a problem because downcase is not required for BORG_UNKNOWN_UNENCRYPTED_REPO_ACCESS_IS_OK and BORG_RELOCATED_REPO_ACCESS_IS_OK. (by looking at the borg code : https://github.com/borgbackup/borg/blob/master/src/borg/helpers/yes_no.py#L8)

But you're right, to be cleaner (and future proof), I created a downcase and an uppercase list of env var.

In theory, it shouldn't be a problem because downcase is not required for BORG_UNKNOWN_UNENCRYPTED_REPO_ACCESS_IS_OK and BORG_RELOCATED_REPO_ACCESS_IS_OK. (by looking at the borg code : https://github.com/borgbackup/borg/blob/master/src/borg/helpers/yes_no.py#L8) But you're right, to be cleaner (and future proof), I created a downcase and an uppercase list of env var.
arakmar marked this conversation as resolved
arakmar force-pushed env_check_i_know_what_i_am_doing from d05ec9fa2c to 7d18f59079 2023-07-10 08:37:08 +00:00 Compare
witten commented 2023-07-10 16:37:48 +00:00
Owner
Copy Link

Looks great, thank you!

Looks great, thank you!
witten merged commit d29667ca3c into main 2023-07-10 16:38:09 +00:00
witten commented 2023-07-19 06:02:14 +00:00
Owner
Copy Link

Released in borgmatic 1.8.0. Thanks again!

Released in borgmatic 1.8.0. Thanks again!
witten commented 2023-07-22 21:56:37 +00:00
Owner
Copy Link

FYI: #730

I think this is because check_i_know_what_i_am_doing defaults to false and therefore the Borg environment variable always gets set.

FYI: https://projects.torsion.org/borgmatic-collective/borgmatic/issues/730 I think this is because `check_i_know_what_i_am_doing` defaults to `false` and therefore the Borg environment variable always gets set.
Sign in to join this conversation.
Reviewers
No reviewers
witten
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#724
No description provided.
Delete Branch "arakmar/borgmatic:env_check_i_know_what_i_am_doing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?