Borg 1.7.15 breaks borg key export command #719

New Issue

Closed

opened 2023-06-26 16:12:54 +00:00 by Unostot · 4 comments

Unostot commented 2023-06-26 16:12:54 +00:00

Copy Link

What I'm trying to do and why

Extract the repo key by issuing a borgmatic -c borgmatic_configs/system.conf borg key export

Steps to reproduce (if a bug)

run command on borgmatic 1.7.14:

ssh://some_server_with_repository: Running arbitrary Borg command
BORG_KEY <very long and complex repo key>

summary:
borgmatic_configs/system.conf: Successfully ran configuration file

return code: 0

run the command with borgmatic 1.7.15:

ssh://some_server_with_repository: Running arbitrary Borg command
BORG_KEY <very long and complex repo key>

summary:
/root/borg/key: Error parsing configuration file
[Errno 2] No such file or directory: '/root/borg/key'
/root/borg/export: Error parsing configuration file
[Errno 2] No such file or directory: '/root/borg/export'
/root/borg/borgmatic_configs/system.conf: Successfully ran configuration file

Need some help? https://torsion.org/borgmatic/#issues

return code: 1

Actual behavior (if a bug)

as you can see, the 1.7.15 borgmatic somehow interprets the key and export as "config file arguments", not just the part after -c

Expected behavior (if a bug)

should work as in 1.7.14. So return code = 0 and not interpret key and export as config files.

Other notes / implementation ideas

Since the whole borg key export did need some extra work (i think 1.6), there might be something related to this extra steps, before 1.6 this command did not work, too.

Environment

borgmatic version: 1.7.15

borgmatic installation method: pip / python venv

Borg version: 1.2.0

Python version: 3.10.6

operating system and version: Ubuntu 22.04.2 LTS

Greetings,
Uno

#### What I'm trying to do and why Extract the repo key by issuing a `borgmatic -c borgmatic_configs/system.conf borg key export` #### Steps to reproduce (if a bug) run command on borgmatic 1.7.14: ``` ssh://some_server_with_repository: Running arbitrary Borg command BORG_KEY <very long and complex repo key> summary: borgmatic_configs/system.conf: Successfully ran configuration file ``` return code: 0 run the command with borgmatic 1.7.15: ``` ssh://some_server_with_repository: Running arbitrary Borg command BORG_KEY <very long and complex repo key> summary: /root/borg/key: Error parsing configuration file [Errno 2] No such file or directory: '/root/borg/key' /root/borg/export: Error parsing configuration file [Errno 2] No such file or directory: '/root/borg/export' /root/borg/borgmatic_configs/system.conf: Successfully ran configuration file Need some help? https://torsion.org/borgmatic/#issues ``` return code: 1 #### Actual behavior (if a bug) as you can see, the 1.7.15 borgmatic somehow interprets the `key` and `export` as "config file arguments", not just the part after `-c` #### Expected behavior (if a bug) should work as in 1.7.14. So return code = 0 and not interpret key and export as config files. #### Other notes / implementation ideas Since the whole `borg key export` did need some extra work (i think 1.6), there might be something related to this extra steps, before 1.6 this command did not work, too. #### Environment **borgmatic version:** 1.7.15 **borgmatic installation method:** pip / python venv **Borg version:** 1.2.0 **Python version:** 3.10.6 **operating system and version:** Ubuntu 22.04.2 LTS Greetings, Uno

witten commented 2023-06-26 16:18:02 +00:00

Owner

Copy Link

That's for taking the time to file this! There's actually code in borgmatic 1.7.15 (and tests) that are supposed to protect from exactly this sort of case. But it sounds like there might be an edge case upon an edge case, and you've unfortunately stumbled across it. And FWIW, I can repro this issue here.

That's for taking the time to file this! There's actually code in borgmatic 1.7.15 (and tests) that are supposed to protect from exactly this sort of case. But it sounds like there might be an edge case upon an edge case, and you've unfortunately stumbled across it. And FWIW, I can repro this issue here.

witten added the

bug

label 2023-06-26 16:18:09 +00:00

witten referenced this issue from a commit 2023-06-26 16:30:58 +00:00

Fix an error when running "borg key export" through borgmatic (#719).

witten commented 2023-06-26 16:32:36 +00:00

Owner

Copy Link

This is fixed in main and will be part of the next release. Thanks again for reporting it!

Side note: I'm considering some major-ish changes to borgmatic borg as part of the next release. I'll post my thoughts on #575 in case you're interested. You may also be interested in #345.

This is fixed in main and will be part of the next release. Thanks again for reporting it! Side note: I'm considering some major-ish changes to `borgmatic borg` as part of the next release. I'll post my thoughts on #575 in case you're interested. You may also be interested in #345.

👍 1

witten closed this issue 2023-06-26 16:32:36 +00:00

Unostot commented 2023-06-26 16:39:47 +00:00

Author

Copy Link

thanks for the quick fix...
Then I stick with 1.7.14 to pass the time until 1.7.16+ :)

Greetings,
Uno

thanks for the quick fix... Then I stick with 1.7.14 to pass the time until 1.7.16+ :) Greetings, Uno

👍 1

witten commented 2023-07-19 06:02:38 +00:00

Owner

Copy Link

Released in borgmatic 1.8.0!

Released in borgmatic 1.8.0!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#719

No description provided.