borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
14
57
Fork 41
Code Issues 54 Pull Requests 2 Actions Packages Releases 122 Activity

borgmatic doesn't show the borg error output for local repositories #705

New Issue
Closed
opened 2023-05-28 16:26:37 +00:00 by kaysond · 3 comments
kaysond commented 2023-05-28 16:26:37 +00:00
Copy Link

What I'm trying to do and why

Steps to reproduce (if a bug)

Run some kind of borg command that fails, with --verbosity 2

Actual behavior (if a bug)

Borgmatic will show the borg error output for remote repositories (I'm guessing because it's just showing all ssh output?) but not local ones.

Expected behavior (if a bug)

Borgmatic should always show the error output.

Other notes / implementation ideas

Here are some verbose logs showing the issue: the borg error output ("--repository-only contradicts --first, --last, --glob-archives, --prefix and --verify-data arguments") is shown after the remote repo runs, but not after the local one! I did check, and if I just do the local repository, I still don't get an error message.

Discovered while looking into #704 so could also be related to #688 but I'm guessing it's a general thing and not related to checks specifically.

ssh://borg@borgvm.iyer.lan/mnt/arambkup/borg: Running consistency checks
borg info --json ssh://borg@borgvm.iyer.lan/mnt/arambkup/borg                                                                                                             Reading check time from /root/.borgmatic/checks/dd22d39afc3a473af796348a2c054411368ea48a2c688b67cd7ed32dbed0e8e8/repository
Reading check time from /root/.borgmatic/checks/dd22d39afc3a473af796348a2c054411368ea48a2c688b67cd7ed32dbed0e8e8/archives/a47a4e53797d8a33427d8cd3201c607013e1a883195b3fbdebbe0454df566b7c
Skipping archives check due to configured frequency; 6 days, 10:12:03.845993 until next check
borg check --repository-only --glob-archives home-* --debug --show-rc ssh://borg@borgvm.iyer.lan/mnt/arambkup/borg
using builtin fallback logging configuration
33 self tests completed in 0.18 seconds                                                                                                                                   SSH command line: ['ssh', '-i', '/root/.ssh/borg@343guiltyspark.nub.lan.key', 'borg@borgvm.iyer.lan', 'borg', 'serve', '--debug']
Remote: using builtin fallback logging configuration
Remote: 38 self tests completed in 0.28 seconds
Remote: using builtin fallback logging configuration
Remote: Initialized logging system for JSON-based protocol
Remote: Resolving repository path b'/mnt/arambkup/borg'
Remote: Resolved repository path to '/mnt/arambkup/borg'
--repository-only contradicts --first, --last, --glob-archives, --prefix and --verify-data arguments.
RemoteRepository: 140 B bytes sent, 837 B bytes received, 2 messages sent                                                                                                 terminating with error status, rc 2                                                                                                                                       ssh://borg@borgvm.iyer.lan/mnt/arambkup/borg: Error running actions for repository                                                                                        Command 'borg check --repository-only --glob-archives home-* --debug --show-rc ssh://borg@borgvm.iyer.lan/mnt/arambkup/borg' returned non-zero exit status 2.
/mnt/extdrive/borg: Running actions for repository                                                                                                                        /etc/borgmatic.d/home.yml: No commands to run for pre-actions hook
/etc/borgmatic.d/home.yml: No commands to run for pre-check hook                                                                                                          /mnt/extdrive/borg: Running consistency checks
borg info --json /mnt/extdrive/borg                                                                                                                                       Reading check time from /root/.borgmatic/checks/758b61594cf8118b5cddea6aeadad04db905c4506aec0cc44249fbc95c922133/repository
Reading check time from /root/.borgmatic/checks/758b61594cf8118b5cddea6aeadad04db905c4506aec0cc44249fbc95c922133/archives/a47a4e53797d8a33427d8cd3201c607013e1a883195b3fbdebbe0454df566b7c
Skipping archives check due to configured frequency; 6 days, 10:14:28.939407 until next check
borg check --repository-only --glob-archives home-* --debug --show-rc /mnt/extdrive/borg
using builtin fallback logging configuration                                                                                                                              33 self tests completed in 0.19 seconds
--repository-only contradicts --first, --last, --glob-archives, --prefix and --verify-data arguments.
terminating with error status, rc 2
/mnt/extdrive/borg: Error running actions for repository
Command 'borg check --repository-only --glob-archives home-* --debug --show-rc /mnt/extdrive/borg' returned non-zero exit status 2.

Environment

borgmatic version: 1.7.13

borgmatic installation method: pip

Borg version: 1.2.4

Python version: 3.9.2

operating system and version: Debian 11

#### What I'm trying to do and why #### Steps to reproduce (if a bug) Run some kind of borg command that fails, with `--verbosity 2` #### Actual behavior (if a bug) Borgmatic will show the `borg` error output for remote repositories (I'm guessing because it's just showing all ssh output?) but not local ones. #### Expected behavior (if a bug) Borgmatic should always show the error output. #### Other notes / implementation ideas Here are some verbose logs showing the issue: the `borg` error output ("--repository-only contradicts --first, --last, --glob-archives, --prefix and --verify-data arguments") is shown after the remote repo runs, but not after the local one! I did check, and if I just do the local repository, I still don't get an error message. Discovered while looking into #704 so could also be related to #688 but I'm guessing it's a general thing and not related to checks specifically. ``` ssh://borg@borgvm.iyer.lan/mnt/arambkup/borg: Running consistency checks borg info --json ssh://borg@borgvm.iyer.lan/mnt/arambkup/borg Reading check time from /root/.borgmatic/checks/dd22d39afc3a473af796348a2c054411368ea48a2c688b67cd7ed32dbed0e8e8/repository Reading check time from /root/.borgmatic/checks/dd22d39afc3a473af796348a2c054411368ea48a2c688b67cd7ed32dbed0e8e8/archives/a47a4e53797d8a33427d8cd3201c607013e1a883195b3fbdebbe0454df566b7c Skipping archives check due to configured frequency; 6 days, 10:12:03.845993 until next check borg check --repository-only --glob-archives home-* --debug --show-rc ssh://borg@borgvm.iyer.lan/mnt/arambkup/borg using builtin fallback logging configuration 33 self tests completed in 0.18 seconds SSH command line: ['ssh', '-i', '/root/.ssh/borg@343guiltyspark.nub.lan.key', 'borg@borgvm.iyer.lan', 'borg', 'serve', '--debug'] Remote: using builtin fallback logging configuration Remote: 38 self tests completed in 0.28 seconds Remote: using builtin fallback logging configuration Remote: Initialized logging system for JSON-based protocol Remote: Resolving repository path b'/mnt/arambkup/borg' Remote: Resolved repository path to '/mnt/arambkup/borg' --repository-only contradicts --first, --last, --glob-archives, --prefix and --verify-data arguments. RemoteRepository: 140 B bytes sent, 837 B bytes received, 2 messages sent terminating with error status, rc 2 ssh://borg@borgvm.iyer.lan/mnt/arambkup/borg: Error running actions for repository Command 'borg check --repository-only --glob-archives home-* --debug --show-rc ssh://borg@borgvm.iyer.lan/mnt/arambkup/borg' returned non-zero exit status 2. /mnt/extdrive/borg: Running actions for repository /etc/borgmatic.d/home.yml: No commands to run for pre-actions hook /etc/borgmatic.d/home.yml: No commands to run for pre-check hook /mnt/extdrive/borg: Running consistency checks borg info --json /mnt/extdrive/borg Reading check time from /root/.borgmatic/checks/758b61594cf8118b5cddea6aeadad04db905c4506aec0cc44249fbc95c922133/repository Reading check time from /root/.borgmatic/checks/758b61594cf8118b5cddea6aeadad04db905c4506aec0cc44249fbc95c922133/archives/a47a4e53797d8a33427d8cd3201c607013e1a883195b3fbdebbe0454df566b7c Skipping archives check due to configured frequency; 6 days, 10:14:28.939407 until next check borg check --repository-only --glob-archives home-* --debug --show-rc /mnt/extdrive/borg using builtin fallback logging configuration 33 self tests completed in 0.19 seconds --repository-only contradicts --first, --last, --glob-archives, --prefix and --verify-data arguments. terminating with error status, rc 2 /mnt/extdrive/borg: Error running actions for repository Command 'borg check --repository-only --glob-archives home-* --debug --show-rc /mnt/extdrive/borg' returned non-zero exit status 2. ``` #### Environment **borgmatic version:** 1.7.13 **borgmatic installation method:** pip **Borg version:** 1.2.4 **Python version:** 3.9.2 **operating system and version:** Debian 11
witten commented 2023-05-31 02:57:13 +00:00
Owner
Copy Link

Thanks for filing this one as well. Based on your included borgmatic output though, it does look like the Borg error is showing up for the local repository (unless I'm missing something). Here's the portion of the log where it shows up:

borg check --repository-only --glob-archives home-* --debug --show-rc /mnt/extdrive/borg
using builtin fallback logging configuration
33 self tests completed in 0.19 seconds
--repository-only contradicts --first, --last, --glob-archives, --prefix and --verify-data arguments.
terminating with error status, rc 2
Thanks for filing this one as well. Based on your included borgmatic output though, it does look like the Borg error is showing up for the local repository (unless I'm missing something). Here's the portion of the log where it shows up: ``` borg check --repository-only --glob-archives home-* --debug --show-rc /mnt/extdrive/borg using builtin fallback logging configuration 33 self tests completed in 0.19 seconds --repository-only contradicts --first, --last, --glob-archives, --prefix and --verify-data arguments. terminating with error status, rc 2 ```
kaysond commented 2023-05-31 03:23:45 +00:00
Author
Copy Link

Thanks for filing this one as well. Based on your included borgmatic output though, it does look like the Borg error is showing up for the local repository (unless I'm missing something). Here's the portion of the log where it shows up:

borg check --repository-only --glob-archives home-* --debug --show-rc /mnt/extdrive/borg
using builtin fallback logging configuration
33 self tests completed in 0.19 seconds
--repository-only contradicts --first, --last, --glob-archives, --prefix and --verify-data argument
terminating with error status, rc 2

..................I am blind. Thanks. Closing this

> Thanks for filing this one as well. Based on your included borgmatic output though, it does look like the Borg error is showing up for the local repository (unless I'm missing something). Here's the portion of the log where it shows up: > > ``` > borg check --repository-only --glob-archives home-* --debug --show-rc /mnt/extdrive/borg > using builtin fallback logging configuration > 33 self tests completed in 0.19 seconds > --repository-only contradicts --first, --last, --glob-archives, --prefix and --verify-data argument > terminating with error status, rc 2 > ``` ..................I am blind. Thanks. Closing this
witten commented 2023-05-31 03:25:31 +00:00
Owner
Copy Link

No worries! Verbose output can be very ... verbose. 😄

No worries! Verbose output can be very ... verbose. 😄
witten added the
question / support
 label 2023-05-31 03:25:43 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
spot-check
1.8.11
1.8.10
1.8.9
1.8.8
1.8.7
1.8.6
1.8.5
1.8.4
1.8.3
1.8.2
1.8.1
1.8.0
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.5.24
1.5.23
1.5.22
1.5.21
1.5.20
1.5.19
1.5.18
1.5.17
1.5.16
1.5.15
1.5.14
1.5.13
1.5.12
1.5.11
1.5.10
1.5.9
1.5.8
1.5.7
1.5.7.dev0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.22
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.26
1.3.25
1.3.24
1.3.23
1.3.22
1.3.21
1.3.20
1.3.19
1.3.18
1.3.17
1.3.16
1.3.15
1.3.14
1.3.13
1.3.12
1.3.11
1.3.10
1.3.9
1.3.8
1.3.7
1.3.6
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.18
1.2.17
1.2.16
1.2.15
1.2.14
1.2.13
1.2.12
1.2.11
1.2.10
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.3
1.0.2
1.0.1
1.0.0
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.7
0.0.6
0.0.5
0.0.4
0.0.3
0.0.2
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#705
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?