borgmatic check doesn't work if only repo checks are run #704

New Issue

Closed

opened 2023-05-28 16:21:28 +00:00 by kaysond · 3 comments

kaysond commented 2023-05-28 16:21:28 +00:00

Copy Link

Probably related to the changes to fix #688 This is an easy one so I deleted the template but please let me know if you need any more info.

If you run borgmatic check, and the archive checks are skipped, but the repo check isn't, the borg command fails because you're still passing both --repository-only and --glob-archives:

Reading check time from /root/.borgmatic/checks/dd22d39afc3a473af796348a2c054411368ea48a2c688b67cd7ed32dbed0e8e8/repository
Reading check time from /root/.borgmatic/checks/dd22d39afc3a473af796348a2c054411368ea48a2c688b67cd7ed32dbed0e8e8/archives/a47a4e53797d8a33427d8cd3201c607013e1a883195b3fbdebbe0454df566b7c
Skipping archives check due to configured frequency; 6 days, 10:12:03.845993 until next check
borg check --repository-only --glob-archives home-* --debug --show-rc 

--repository-only contradicts --first, --last, --glob-archives, --prefix and --verify-data arguments.
RemoteRepository: 140 B bytes sent, 837 B bytes received, 2 messages sent                                                                                                 terminating with error status, rc 2                                                     

Probably related to the changes to fix #688 This is an easy one so I deleted the template but please let me know if you need any more info. If you run `borgmatic check`, and the archive checks are skipped, but the repo check isn't, the borg command fails because you're still passing both `--repository-only` and `--glob-archives`: ``` Reading check time from /root/.borgmatic/checks/dd22d39afc3a473af796348a2c054411368ea48a2c688b67cd7ed32dbed0e8e8/repository Reading check time from /root/.borgmatic/checks/dd22d39afc3a473af796348a2c054411368ea48a2c688b67cd7ed32dbed0e8e8/archives/a47a4e53797d8a33427d8cd3201c607013e1a883195b3fbdebbe0454df566b7c Skipping archives check due to configured frequency; 6 days, 10:12:03.845993 until next check borg check --repository-only --glob-archives home-* --debug --show-rc ``` ``` --repository-only contradicts --first, --last, --glob-archives, --prefix and --verify-data arguments. RemoteRepository: 140 B bytes sent, 837 B bytes received, 2 messages sent terminating with error status, rc 2 ```

kaysond referenced this issue 2023-05-28 16:26:37 +00:00

borgmatic doesn't show the borg error output for local repositories #705

witten commented 2023-05-31 02:48:37 +00:00

Owner

Copy Link

I reproduced this locally, and I suspect you are right about #688 changes being the cause. Thanks for filing this!

I reproduced this locally, and I suspect you are right about #688 changes being the cause. Thanks for filing this!

witten added the

bug

label 2023-05-31 02:48:44 +00:00

witten referenced this issue from a commit 2023-05-31 06:19:45 +00:00

Fix "check" action error when repository and archive checks are configured but the archive check gets skipped due to the configured frequency (#704).

witten commented 2023-05-31 06:20:34 +00:00

Owner

Copy Link

I've fixed this in main, and the fix will be part of the next release. Thanks again for finding this and reporting it! (It was indeed #688 fallout.)

I've fixed this in main, and the fix will be part of the next release. Thanks again for finding this and reporting it! (It was indeed #688 fallout.)

witten closed this issue 2023-05-31 06:20:35 +00:00

witten commented 2023-06-04 05:30:12 +00:00

Owner

Copy Link

Just released as part of borgmatic 1.7.14!

Just released as part of borgmatic 1.7.14!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#704

No description provided.