Multiple bugs in PostgreSQL hook #678

New Issue

Closed

opened 2023-04-14 22:58:16 +00:00 by witten · 2 comments

witten commented 2023-04-14 22:58:16 +00:00

Owner

Copy Link

What I'm trying to do and why

Use the PostgreSQL hook to backup my databases with borgmatic, so I don't have to dump them manually.

Steps to reproduce / actual behavior

Separate bugs, each with the repro and the observed behavior:

• Dump backups when a database is configured with format "plain".

pg_restore: error: input file appears to be a text format dump. Please use psql.

• Use shell commands with arguments within psql_command and pg_restore_command options.

These commands are executed without shell=True, so the subprocess
module treats e.g. docker exec my_pg_container psql as a single command
(resulting in Errno 2 "No such file or directory") instead of a command
with arguments.

• psql shouldn't read ~/.psqlrc.

Some settings in user's ~/.psqlrc, e.g. linestyle unicode, may break the
CSV output. --no-psqlrc tells psql to not read this startup file.

This is not necessary for the analyze_command and restore_command (with
all_databases), but it's generally recommended when running psql from a
script.

• PostgreSQL hook doesn't use the psql_command option for listing databse when dumping all.

Environment

Unknown. This ticket was created from commit messages in this PR: #677

#### What I'm trying to do and why Use the PostgreSQL hook to backup my databases with borgmatic, so I don't have to dump them manually. #### Steps to reproduce / actual behavior Separate bugs, each with the repro and the observed behavior: * Dump backups when a database is configured with format "plain". ```console pg_restore: error: input file appears to be a text format dump. Please use psql. ``` * Use shell commands with arguments within `psql_command` and `pg_restore_command` options. These commands are executed without `shell=True`, so the subprocess module treats e.g. `docker exec my_pg_container psql` as a single command (resulting in `Errno 2 "No such file or directory"`) instead of a command with arguments. * `psql` shouldn't read `~/.psqlrc`. Some settings in user's `~/.psqlrc`, e.g. `linestyle unicode`, may break the CSV output. `--no-psqlrc` tells `psql` to not read this startup file. This is not necessary for the analyze_command and restore_command (with all_databases), but it's generally recommended when running psql from a script. * PostgreSQL hook doesn't use the `psql_command` option for listing databse when dumping `all`. #### Environment Unknown. This ticket was created from commit messages in this PR: https://projects.torsion.org/borgmatic-collective/borgmatic/pulls/677

witten added the

bug

label 2023-04-14 22:58:16 +00:00

witten referenced this issue 2023-04-14 22:59:39 +00:00

Fix multiple bugs in PostgreSQL hook #677

witten referenced this issue from a commit 2023-04-21 04:05:23 +00:00

Fix multiple bugs in PostgreSQL hook (#678).

witten referenced this issue from a commit 2023-04-21 04:45:00 +00:00

Add additional tests for PostgreSQL hook fixes (#678).

witten commented 2023-04-21 04:45:32 +00:00

Author

Owner

Copy Link

Fixed in main by @jirutka. Will be part of the next release.

Fixed in main by @jirutka. Will be part of the next release.

witten closed this issue 2023-04-21 04:45:32 +00:00

witten referenced this issue from a commit 2023-04-21 17:35:23 +00:00

Another try. Backing out psql error changes (#678).

witten commented 2023-05-16 17:04:57 +00:00

Author

Owner

Copy Link

This was just released in borgmatic 1.7.13!

This was just released in borgmatic 1.7.13!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#678

No description provided.