borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
15
57
Fork 40
Code Issues 54 Pull Requests 1 Actions Packages Releases 121 Activity

borgmatic info --archive latest --json creates invalid borg invocation including duplicate --glob-archives argument #670

New Issue
Closed
opened 2023-04-08 21:13:43 +00:00 by ginkel · 5 comments
ginkel commented 2023-04-08 21:13:43 +00:00
Copy Link

What I'm trying to do and why

After running a backup I'd like to determine statistics using:

borgmatic info --archive latest --json

Steps to reproduce (if a bug)

Run borgmatic info --archive latest --json with the following config:

consistency:
    checks:
    -   frequency: 2 weeks
        name: repository
hooks:
    after_backup:
    - /etc/borgmatic/hooks/btrfs-snapshot-remove.sh
    - /etc/borgmatic/hooks/update-metrics.py
    before_backup:
    - /etc/borgmatic/hooks/btrfs-snapshot-create.sh
location:
    exclude_patterns:
    - /backup
    - /mnt
    - /proc
    - /sys
    - /tmp
    - /var/tmp
    - /borg-backup/srv/elasticsearch/log
    - /borg-backup/srv/docker-registry
    - /borg-backup/srv/gitlab-elasticsearch
    one_file_system: false
    repositories:
    - ssh://<user>@<user>.your-storagebox.de:23/./borg/<hostname>
    source_directories:
    - /borg-backup/srv
retention:
    keep_daily: 7
    keep_monthly: 6
    keep_yearly: 1
storage:
    archive_name_format: '{fqdn}-{now:%Y-%m-%d.%H:%M}'
    encryption_passphrase: <redacted>
    retries: 2
    retry_wait: 120
    ssh_command: ssh -i /root/.ssh/id_borg

Actual behavior (if a bug)

# borgmatic info --archive latest --json --verbosity 2

Ensuring legacy configuration is upgraded
borg --version --debug --show-rc
ssh://<user>@<user>.your-storagebox.de:23/./borg/pegasus: Running actions for repository
/etc/borgmatic/config.yaml: No commands to run for pre-actions hook
borg list --last 1 --short ssh://<user>@<user>.your-storagebox.de:23/./borg/pegasus
ssh://<user>@<user>.your-storagebox.de:23/./borg/pegasus: Latest archive is <fqdn>-2023-04-08.19:52
borg info --glob-archives {fqdn}-* --json ssh://<user>@<user>.your-storagebox.de:23/./borg/pegasus --glob-archives <fqdn>-2023-04-08.19:52
usage: borg info [-h] [--critical] [--error] [--warning] [--info] [--debug]
                 [--debug-topic TOPIC] [-p] [--iec] [--log-json]
                 [--lock-wait SECONDS] [--bypass-lock] [--show-version]
                 [--show-rc] [--umask M] [--remote-path PATH]
                 [--remote-ratelimit RATE] [--upload-ratelimit RATE]
                 [--remote-buffer UPLOAD_BUFFER]
                 [--upload-buffer UPLOAD_BUFFER] [--consider-part-files]
                 [--debug-profile FILE] [--rsh RSH] [--json]
                 [-P PREFIX | -a GLOB] [--sort-by KEYS] [--first N | --last N]
                 [REPOSITORY_OR_ARCHIVE]
borg info: error: argument -a/--glob-archives: There can be only one.
ssh://<user>@<user>.your-storagebox.de:23/./borg/pegasus: Error running actions for repository
Command '('borg', 'info', '--glob-archives', '{fqdn}-*', '--json', 'ssh://<user>@<user>.your-storagebox.de:23/./borg/pegasus', '--glob-archives', '<fqdn>-2023-04-08.19:52')' returned non-zero exit status 2.

Expected behavior (if a bug)

The command completes successfully and returns JSON info about the most recent archive.

Other notes / implementation ideas

Environment

borgmatic version: 1.7.11

borgmatic installation method: pip

Borg version: 1.2.4

Python version: 3.8.10

Database version (if applicable): n/a

operating system and version: Ubuntu 20.04.6 LTS

#### What I'm trying to do and why After running a backup I'd like to determine statistics using: ``` borgmatic info --archive latest --json ``` #### Steps to reproduce (if a bug) Run `borgmatic info --archive latest --json` with the following config: ``` consistency: checks: - frequency: 2 weeks name: repository hooks: after_backup: - /etc/borgmatic/hooks/btrfs-snapshot-remove.sh - /etc/borgmatic/hooks/update-metrics.py before_backup: - /etc/borgmatic/hooks/btrfs-snapshot-create.sh location: exclude_patterns: - /backup - /mnt - /proc - /sys - /tmp - /var/tmp - /borg-backup/srv/elasticsearch/log - /borg-backup/srv/docker-registry - /borg-backup/srv/gitlab-elasticsearch one_file_system: false repositories: - ssh://<user>@<user>.your-storagebox.de:23/./borg/<hostname> source_directories: - /borg-backup/srv retention: keep_daily: 7 keep_monthly: 6 keep_yearly: 1 storage: archive_name_format: '{fqdn}-{now:%Y-%m-%d.%H:%M}' encryption_passphrase: <redacted> retries: 2 retry_wait: 120 ssh_command: ssh -i /root/.ssh/id_borg ``` #### Actual behavior (if a bug) ``` # borgmatic info --archive latest --json --verbosity 2 Ensuring legacy configuration is upgraded borg --version --debug --show-rc ssh://<user>@<user>.your-storagebox.de:23/./borg/pegasus: Running actions for repository /etc/borgmatic/config.yaml: No commands to run for pre-actions hook borg list --last 1 --short ssh://<user>@<user>.your-storagebox.de:23/./borg/pegasus ssh://<user>@<user>.your-storagebox.de:23/./borg/pegasus: Latest archive is <fqdn>-2023-04-08.19:52 borg info --glob-archives {fqdn}-* --json ssh://<user>@<user>.your-storagebox.de:23/./borg/pegasus --glob-archives <fqdn>-2023-04-08.19:52 usage: borg info [-h] [--critical] [--error] [--warning] [--info] [--debug] [--debug-topic TOPIC] [-p] [--iec] [--log-json] [--lock-wait SECONDS] [--bypass-lock] [--show-version] [--show-rc] [--umask M] [--remote-path PATH] [--remote-ratelimit RATE] [--upload-ratelimit RATE] [--remote-buffer UPLOAD_BUFFER] [--upload-buffer UPLOAD_BUFFER] [--consider-part-files] [--debug-profile FILE] [--rsh RSH] [--json] [-P PREFIX | -a GLOB] [--sort-by KEYS] [--first N | --last N] [REPOSITORY_OR_ARCHIVE] borg info: error: argument -a/--glob-archives: There can be only one. ssh://<user>@<user>.your-storagebox.de:23/./borg/pegasus: Error running actions for repository Command '('borg', 'info', '--glob-archives', '{fqdn}-*', '--json', 'ssh://<user>@<user>.your-storagebox.de:23/./borg/pegasus', '--glob-archives', '<fqdn>-2023-04-08.19:52')' returned non-zero exit status 2. ``` #### Expected behavior (if a bug) The command completes successfully and returns JSON info about the most recent archive. #### Other notes / implementation ideas #### Environment **borgmatic version:** 1.7.11 **borgmatic installation method:** pip **Borg version:** 1.2.4 **Python version:** 3.8.10 **Database version (if applicable):** n/a **operating system and version:** Ubuntu 20.04.6 LTS
witten commented 2023-04-08 21:30:27 +00:00
Owner
Copy Link

Thank you for taking the time to file this. This was actually just fixed in #666 for a related borgmatic info case. I just confirmed that it was indeed fixed; I used your config file and tried the code before and after the change. The fix will be released in the next version of borgmatic in the next few days!

Thank you for taking the time to file this. This was actually just fixed in #666 for a related `borgmatic info` case. I just confirmed that it was indeed fixed; I used your config file and tried the code before and after the change. The fix will be released in the next version of borgmatic in the next few days!
witten added the
bug
 label 2023-04-08 21:30:35 +00:00
ginkel commented 2023-04-09 10:05:04 +00:00
Author
Copy Link

Thanks for the speedy reply! I have downgraded borgmatic to 1.7.10 for now and am looking forward to the upcoming release for a permanent fix.

Thanks for the speedy reply! I have downgraded borgmatic to 1.7.10 for now and am looking forward to the upcoming release for a permanent fix.
👍 1
witten commented 2023-04-13 22:18:23 +00:00
Owner
Copy Link

This fix has been released as part of borgmatic 1.7.12!

This fix has been released as part of borgmatic 1.7.12!
ginkel commented 2023-04-14 18:46:55 +00:00
Author
Copy Link

Excellent, thanks! I can confirm that 1.7.12 indeed fixes the issue.

Excellent, thanks! I can confirm that 1.7.12 indeed fixes the issue.
witten commented 2023-04-14 22:32:36 +00:00
Owner
Copy Link

Glad to hear it!

Glad to hear it!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
spot-check
1.8.10
1.8.9
1.8.8
1.8.7
1.8.6
1.8.5
1.8.4
1.8.3
1.8.2
1.8.1
1.8.0
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.5.24
1.5.23
1.5.22
1.5.21
1.5.20
1.5.19
1.5.18
1.5.17
1.5.16
1.5.15
1.5.14
1.5.13
1.5.12
1.5.11
1.5.10
1.5.9
1.5.8
1.5.7
1.5.7.dev0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.22
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.26
1.3.25
1.3.24
1.3.23
1.3.22
1.3.21
1.3.20
1.3.19
1.3.18
1.3.17
1.3.16
1.3.15
1.3.14
1.3.13
1.3.12
1.3.11
1.3.10
1.3.9
1.3.8
1.3.7
1.3.6
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.18
1.2.17
1.2.16
1.2.15
1.2.14
1.2.13
1.2.12
1.2.11
1.2.10
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.3
1.0.2
1.0.1
1.0.0
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.7
0.0.6
0.0.5
0.0.4
0.0.3
0.0.2
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#670
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?