borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
15
57
Fork 40
Code Issues 53 Pull Requests 1 Actions Packages Releases 121 Activity

Prune action with prefix sends duplicate --glob-archives flags to Borg #668

New Issue
Closed
opened 2023-04-05 20:53:43 +00:00 by witten · 3 comments
witten commented 2023-04-05 20:53:43 +00:00
Owner
Copy Link

What I'm trying to do and why

Run prune during a dry run to reproduce an issue discovered by a Redditor.

Steps to reproduce

Using this configuration in test.yaml:

location:
    source_directories:
        - test

    repositories:
        - test.borg

storage:
    archive_name_format: 'test-{now}'

retention:
    keep_daily: 7
    prefix: 'test-'

Run the following:

borgmatic -c test.yaml -v 2 --dry-run prune

This also repros without the --dry-run flag.

Actual behavior

...
summary:
test.yaml: An error occurred
test.borg: Error running actions for repository
usage: borg prune [-h] [--critical] [--error] [--warning] [--info] [--debug]
                  [--debug-topic TOPIC] [-p] [--iec] [--log-json]
                  [--lock-wait SECONDS] [--bypass-lock] [--show-version]
                  [--show-rc] [--umask M] [--remote-path PATH]
                  [--remote-ratelimit RATE] [--upload-ratelimit RATE]
                  [--remote-buffer UPLOAD_BUFFER]
                  [--upload-buffer UPLOAD_BUFFER] [--consider-part-files]
                  [--debug-profile FILE] [--rsh RSH] [-n] [--force] [-s]
                  [--list] [--keep-within INTERVAL] [--keep-last SECONDLY]
                  [--keep-minutely MINUTELY] [-H HOURLY] [-d DAILY]
                  [-w WEEKLY] [-m MONTHLY] [-y YEARLY] [-P PREFIX | -a GLOB]
                  [--save-space] [-c SECONDS]
                  [REPOSITORY]
borg prune: error: argument -a/--glob-archives: There can be only one.
Command 'borg prune --keep-daily 7 --glob-archives test-* --glob-archives test-* --debug --show-rc --dry-run test.borg' returned non-zero exit status 2.

Need some help? https://torsion.org/borgmatic/#issues

Expected behavior

bormgatic only sending --glob-archives once to Borg, no error from Borg.

Other notes / implementation ideas

You'd think that the fixes and integration tests for duplicate flags in #666 would handle this case! You'd be wrong.

Environment

borgmatic version: master (after 1.7.11)

borgmatic installation method: pip install --editable

Borg version: 1.2.4

Python version: 3.10.10

operating system and version: Manjaro Linux stable

#### What I'm trying to do and why Run `prune` during a dry run to reproduce [an issue discovered by a Redditor](https://www.reddit.com/r/BorgBackup/comments/12ctoqi/getting_error_two_globarchives_with_borgmatic/). #### Steps to reproduce Using this configuration in `test.yaml`: ```yaml location: source_directories: - test repositories: - test.borg storage: archive_name_format: 'test-{now}' retention: keep_daily: 7 prefix: 'test-' ``` Run the following: ```bash borgmatic -c test.yaml -v 2 --dry-run prune ``` This also repros without the `--dry-run` flag. #### Actual behavior ```bash ... summary: test.yaml: An error occurred test.borg: Error running actions for repository usage: borg prune [-h] [--critical] [--error] [--warning] [--info] [--debug] [--debug-topic TOPIC] [-p] [--iec] [--log-json] [--lock-wait SECONDS] [--bypass-lock] [--show-version] [--show-rc] [--umask M] [--remote-path PATH] [--remote-ratelimit RATE] [--upload-ratelimit RATE] [--remote-buffer UPLOAD_BUFFER] [--upload-buffer UPLOAD_BUFFER] [--consider-part-files] [--debug-profile FILE] [--rsh RSH] [-n] [--force] [-s] [--list] [--keep-within INTERVAL] [--keep-last SECONDLY] [--keep-minutely MINUTELY] [-H HOURLY] [-d DAILY] [-w WEEKLY] [-m MONTHLY] [-y YEARLY] [-P PREFIX | -a GLOB] [--save-space] [-c SECONDS] [REPOSITORY] borg prune: error: argument -a/--glob-archives: There can be only one. Command 'borg prune --keep-daily 7 --glob-archives test-* --glob-archives test-* --debug --show-rc --dry-run test.borg' returned non-zero exit status 2. Need some help? https://torsion.org/borgmatic/#issues ``` #### Expected behavior bormgatic only sending `--glob-archives` once to Borg, no error from Borg. #### Other notes / implementation ideas You'd think that the fixes and integration tests for duplicate flags in #666 would handle this case! You'd be wrong. #### Environment **borgmatic version:** master (after 1.7.11) **borgmatic installation method:** `pip install --editable` **Borg version:** 1.2.4 **Python version:** 3.10.10 **operating system and version:** Manjaro Linux stable
witten added the
bug
 label 2023-04-05 20:53:43 +00:00
witten commented 2023-04-05 21:08:09 +00:00
Author
Owner
Copy Link

Looking at the code (make_prune_flags()), it's pretty clear why this happening—the code is not even making an effort to toggle between prefix making --match-archives and archive_name_format making --match-archives. It just blindly does both if prefix is set. Ugh, who was the joker who let this slip through? 😆

Looking at the code (`make_prune_flags()`), it's pretty clear why this happening—the code is not even making an effort to toggle between `prefix` making `--match-archives` and `archive_name_format` making `--match-archives`. It just blindly does both if `prefix` is set. Ugh, who was the joker who let this slip through? 😆
👍 1
witten commented 2023-04-05 21:58:41 +00:00
Author
Owner
Copy Link

Fixed in master. Will be part of the next release.

Fixed in master. Will be part of the next release.
witten commented 2023-04-13 22:18:33 +00:00
Author
Owner
Copy Link

This fix has been released as part of borgmatic 1.7.12!

This fix has been released as part of borgmatic 1.7.12!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
spot-check
1.8.10
1.8.9
1.8.8
1.8.7
1.8.6
1.8.5
1.8.4
1.8.3
1.8.2
1.8.1
1.8.0
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.5.24
1.5.23
1.5.22
1.5.21
1.5.20
1.5.19
1.5.18
1.5.17
1.5.16
1.5.15
1.5.14
1.5.13
1.5.12
1.5.11
1.5.10
1.5.9
1.5.8
1.5.7
1.5.7.dev0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.22
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.26
1.3.25
1.3.24
1.3.23
1.3.22
1.3.21
1.3.20
1.3.19
1.3.18
1.3.17
1.3.16
1.3.15
1.3.14
1.3.13
1.3.12
1.3.11
1.3.10
1.3.9
1.3.8
1.3.7
1.3.6
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.18
1.2.17
1.2.16
1.2.15
1.2.14
1.2.13
1.2.12
1.2.11
1.2.10
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.3
1.0.2
1.0.1
1.0.0
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.7
0.0.6
0.0.5
0.0.4
0.0.3
0.0.2
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#668
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?