Make "--add-drop-database" optional in MySQL backup #642

New Issue

Closed

opened 2023-02-19 18:17:32 +00:00 by st1pps · 1 comment

st1pps commented 2023-02-19 18:17:32 +00:00

Copy Link

What I'm trying to do and why

I'm backing up my MySQL databases using borgmatic. Borgmatic always includes the "--add-drop-database" parameter when invoking mysqldump. This is problematic for manual restores of individual databases, as this results in all grants for the said database being removed, which can result in extra manual work to restore said grants. As I would always opt for manual restoring of individual database and not use the automatic restore, I'd appreciate it if there was a way to disable the "--add-drop-database" option on the created dumps, if there is nothing speaking against that, so I don't need to remember to edit them manually before restoring.
To retain compatibility with the current version, a property like "disableDropDatabase" could be added to the yaml configuration.

Steps to reproduce (if a bug)

Include (sanitized) borgmatic configuration files if applicable.

Actual behavior (if a bug)

Include (sanitized) --verbosity 2 output if applicable.

Expected behavior (if a bug)

Other notes / implementation ideas

Environment

borgmatic version: 1.7.6

Use sudo borgmatic --version or sudo pip show borgmatic | grep ^Version

borgmatic installation method: user site installation

Borg version: 1.2.0

Use sudo borg --version

Python version: 3.10.6

Use python3 --version

Database version (if applicable): MariaDB 10.3

Use psql --version or mysql --version on client and server.

operating system and version: Ubuntu 22.04

#### What I'm trying to do and why I'm backing up my MySQL databases using borgmatic. Borgmatic always includes the "--add-drop-database" parameter when invoking mysqldump. This is problematic for manual restores of individual databases, as this results in all grants for the said database being removed, which can result in extra manual work to restore said grants. As I would always opt for manual restoring of individual database and not use the automatic restore, I'd appreciate it if there was a way to disable the "--add-drop-database" option on the created dumps, if there is nothing speaking against that, so I don't need to remember to edit them manually before restoring. To retain compatibility with the current version, a property like "disableDropDatabase" could be added to the yaml configuration. #### Steps to reproduce (if a bug) Include (sanitized) borgmatic configuration files if applicable. #### Actual behavior (if a bug) Include (sanitized) `--verbosity 2` output if applicable. #### Expected behavior (if a bug) #### Other notes / implementation ideas #### Environment **borgmatic version:** 1.7.6 Use `sudo borgmatic --version` or `sudo pip show borgmatic | grep ^Version` **borgmatic installation method:** user site installation **Borg version:** 1.2.0 Use `sudo borg --version` **Python version:** 3.10.6 Use `python3 --version` **Database version (if applicable):** MariaDB 10.3 Use `psql --version` or `mysql --version` on client and server. **operating system and version:** Ubuntu 22.04

witten referenced this issue from a commit 2023-02-20 23:33:04 +00:00

Add MySQL database hook "add_drop_database" configuration option to control whether dumped MySQL databases get dropped right before restore (#642).

witten commented 2023-02-20 23:39:30 +00:00

Owner

Copy Link

Thanks for the suggestion! This is now implemented in master and released in borgmatic 1.7.7 via a new add_drop_database option you can set to false for a given MySQL database to support your use case.

Thanks for the suggestion! This is now implemented in master and released in borgmatic 1.7.7 via a new `add_drop_database` option you can set to `false` for a given MySQL database to support your use case.

witten closed this issue 2023-02-20 23:39:30 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#642

No description provided.