borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
15
57
Fork 40
Code Issues 53 Pull Requests 2 Actions Packages Releases 121 Activity

Log warning for excluding special files only if list is not empty #629

Merged
witten merged 1 commits from palto42/borgmatic:special_files_warn into master 2023-01-14 17:15:04 +00:00
Conversation 2 Commits 1 Files Changed 2 +12 -13
palto42 commented 2023-01-14 10:57:46 +00:00
Contributor
Copy Link

This PR skips the warning about excluding special files which was added in version 1.7.3 if the list of special files found is empty.

Issuing this warning with an empty files list may cause confusion since there is actually nothing skipped. In my case for example it cause unnecessary notification emails about potential issues during backup.

This PR skips the warning about excluding special files which was added in version 1.7.3 if the list of special files found is empty. Issuing this warning with an empty files list may cause confusion since there is actually nothing skipped. In my case for example it cause unnecessary notification emails about potential issues during backup.
palto42 added 1 commit 2023-01-14 10:57:49 +00:00
witten commented 2023-01-14 17:14:47 +00:00
Owner
Copy Link

Awesome, thanks for taking the time to fix this!

Awesome, thanks for taking the time to fix this!
👍 1
witten merged commit 6c4abb6803 into master 2023-01-14 17:15:04 +00:00
witten referenced this issue from a commit 2023-01-14 17:18:01 +00:00
Add NEWS entry for #629.
witten commented 2023-01-26 23:24:58 +00:00
Owner
Copy Link

Just released in borgmatic 1.7.6. Thanks again!

Just released in borgmatic 1.7.6. Thanks again!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#629
No description provided.
Delete Branch "palto42/borgmatic:special_files_warn"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?