Confusing error messages #623

New Issue

Closed

opened 2022-12-23 16:23:01 +00:00 by marozsas · 7 comments

marozsas commented 2022-12-23 16:23:01 +00:00

Copy Link

When borgmatic is running and in another window you run another borgmatic command, i.e. borgmatic info, it replies with a message saying that was impossible to acquire a lock, which is fine, followed by another error message saying that there is an error in config file that are just non-sense and could lead one to wondering that really is another problem.

Would be nice to just have a siingle message about the lock removing the error message that says "/etc/borgmatic.d/photos.yaml: Error running configuration file" since there is no error on configuration file...

kimera:~ # borgmatic list
/media/miguel/ExternalBackups/borg-backups/windows-pictures: Listing archives
Failed to create/acquire the lock /media/miguel/ExternalBackups/borg-backups/windows-pictures/lock.exclusive (timeout).
/media/miguel/ExternalBackups/borg-backups/windows-pictures: Error running actions for repository
Command 'borg list /media/miguel/ExternalBackups/borg-backups/windows-pictures' returned non-zero exit status 2.
/etc/borgmatic.d/photos.yaml: Error running configuration file
...
summary:
/etc/borgmatic.d/photos.yaml: Error running configuration file
/media/miguel/ExternalBackups/borg-backups/windows-pictures: Error running actions for repository
Failed to create/acquire the lock /media/miguel/ExternalBackups/borg-backups/windows-pictures/lock.exclusive (timeout).
Command 'borg list /media/miguel/ExternalBackups/borg-backups/windows-pictures' returned non-zero exit status 2.

Environment

borgmatic version: 1.7.5

borgmatic installation method: RPM
borgbackup-bash-completion-1.2.2-1.1.noarch
borgbackup-1.2.2-1.1.x86_64
borgmatic-1.7.5-1.1.noarch

Borg version: borg 1.2.2

Python version: Python 3.10.9

operating system and version: opensuse tumbleweed

When borgmatic is running and in another window you run another borgmatic command, i.e. borgmatic info, it replies with a message saying that was impossible to acquire a lock, which is fine, followed by another error message saying that there is an error in config file that are just non-sense and could lead one to wondering that really is another problem. Would be nice to just have a siingle message about the lock removing the error message that says "/etc/borgmatic.d/photos.yaml: Error running configuration file" since there is no error on configuration file... kimera:~ # borgmatic list /media/miguel/ExternalBackups/borg-backups/windows-pictures: Listing archives Failed to create/acquire the lock /media/miguel/ExternalBackups/borg-backups/windows-pictures/lock.exclusive (timeout). /media/miguel/ExternalBackups/borg-backups/windows-pictures: Error running actions for repository Command 'borg list /media/miguel/ExternalBackups/borg-backups/windows-pictures' returned non-zero exit status 2. /etc/borgmatic.d/photos.yaml: Error running configuration file ... summary: /etc/borgmatic.d/photos.yaml: Error running configuration file /media/miguel/ExternalBackups/borg-backups/windows-pictures: Error running actions for repository Failed to create/acquire the lock /media/miguel/ExternalBackups/borg-backups/windows-pictures/lock.exclusive (timeout). Command 'borg list /media/miguel/ExternalBackups/borg-backups/windows-pictures' returned non-zero exit status 2. #### Environment **borgmatic version:** 1.7.5 **borgmatic installation method:** RPM borgbackup-bash-completion-1.2.2-1.1.noarch borgbackup-1.2.2-1.1.x86_64 borgmatic-1.7.5-1.1.noarch **Borg version:** borg 1.2.2 **Python version:** Python 3.10.9 **operating system and version:** opensuse tumbleweed

witten commented 2022-12-23 17:36:15 +00:00

Owner

Copy Link

Thanks for taking the time to file this! The current error messages are accurate, although I can see how they are misleading in this case. What's going on is borgmatic runs Borg, which is itself erroring with the "failed to create/acquire lock" message. borgmatic sees that Borg has exited with an error and displays its own "Error running configuration file" message, indicating that something has gone wrong while running through actions for the named configuration file—not that anything is necessarily wrong with the file itself.

So maybe this is just a question of tweaking the phrasing? What do you think of /etc/borgmatic.d/photos.yaml: Error running actions for configuration file? Or just /etc/borgmatic.d/photos.yaml: An error occurred?

Thanks for taking the time to file this! The current error messages are accurate, although I can see how they are misleading in this case. What's going on is borgmatic runs Borg, which is itself erroring with the "failed to create/acquire lock" message. borgmatic sees that Borg has exited with an error and displays its own "Error running configuration file" message, indicating that something has gone wrong while running through actions for the named configuration file—not that anything is necessarily wrong with the file itself. So maybe this is just a question of tweaking the phrasing? What do you think of `/etc/borgmatic.d/photos.yaml: Error running actions for configuration file`? Or just `/etc/borgmatic.d/photos.yaml: An error occurred`?

marozsas commented 2022-12-23 19:04:05 +00:00

Author

Copy Link

I guess that tweaking the phrase to "/etc/borgmatic.d/photos.yaml: An error occurred" is more general and don't cause one to misinterpret it as a problem in config.

Funny story, let me give you a background of what occurred so you can have a complete picture:

Today, before leaving to Xmas, we (I and my co-workers) decided to make an extra backup, just because we can.

Than, hours later, I run "borgmatic info" to inspect the destination disk, as a sanity check before running the backup and got those errors.
I spend several minutes (really!) to figure out why the config is wrong and why a lock is in place.

Then I realize that one of my buddies started the backup hours before so this explain the lock out of my knowledge, and so I tought it was a problem in config which is most common! You see ? Se someone don't knows a backup is running, the messages are misleading !

Thank tou !

I guess that tweaking the phrase to "/etc/borgmatic.d/photos.yaml: An error occurred" is more general and don't cause one to misinterpret it as a problem in config. Funny story, let me give you a background of what occurred so you can have a complete picture: Today, before leaving to Xmas, we (I and my co-workers) decided to make an extra backup, just because we can. Than, hours later, I run "borgmatic info" to inspect the destination disk, as a sanity check before running the backup and got those errors. I spend several minutes (really!) to figure out why the config is wrong and why a lock is in place. Then I realize that one of my buddies started the backup hours before so this explain the lock out of my knowledge, and so I tought it was a problem in config which is most common! You see ? Se someone don't knows a backup is running, the messages are misleading ! Thank tou !

witten commented 2022-12-23 20:19:55 +00:00

Owner

Copy Link

That totally makes sense. Based on that series of events, I can see how the message would be misleading. I'll tweak the wording to hopefully improve clarity here!

That totally makes sense. Based on that series of events, I can see how the message would be misleading. I'll tweak the wording to hopefully improve clarity here!

witten added the

good first issue

label 2023-02-04 17:14:44 +00:00

diivi commented 2023-03-21 19:42:50 +00:00

Collaborator

Copy Link

I had the same issue with the phrasing too, I'll work on this if nobody else does, considering this might be a good issue for (even) newer contributors :D

I had the same issue with the phrasing too, I'll work on this if nobody else does, considering this might be a good issue for (even) newer contributors :D

witten commented 2023-03-21 20:01:21 +00:00

Owner

Copy Link

Feel free to pick it up if you want!

Feel free to pick it up if you want!

witten commented 2023-03-21 21:24:09 +00:00

Owner

Copy Link

Fixed by @diivi in https://github.com/borgmatic-collective/borgmatic/pull/55!

Fixed by @diivi in https://github.com/borgmatic-collective/borgmatic/pull/55!

witten closed this issue 2023-03-21 21:24:09 +00:00

witten referenced this issue from a commit 2023-03-21 21:25:48 +00:00

Fix confusing message when an error occurs running actions for a configuration file (#623).

witten referenced this issue from a commit 2023-03-21 21:25:48 +00:00

Add confusing error message fix to NEWS (#623).

witten commented 2023-03-27 23:21:58 +00:00

Owner

Copy Link

Released in borgmatic 1.7.10!

Released in borgmatic 1.7.10!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#623

No description provided.