borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
15
57
Fork 40
Code Issues 53 Pull Requests 2 Actions Packages Releases 121 Activity

Feature Request: Add authentication to ntfy hook #621

New Issue
Closed
opened 2022-12-19 20:19:03 +00:00 by crazy-weasel · 6 comments
crazy-weasel commented 2022-12-19 20:19:03 +00:00
Copy Link

What I'm trying to do and why

I run a self hosted ntfy server with authentication enabled and no anonymous access as it's private instance.

Other notes / implementation ideas

The ntfy server supports authentication via basic authorization (Authorization-Header) or as a query parameter. (docs)

The configuration could be extend to support the authentication data and if present, the data could be added to the headers in line 52 of borgmatic/hooks/ntfy.py#L52

Environment

borgmatic version: 1.7.5

borgmatic installation method: pip

Borg version: 1.2.0

Python version: 3.10.6

Database version (if applicable): n/a

operating system and version: Ubuntu 22.04.1 LTS

#### What I'm trying to do and why I run a self hosted ntfy server with authentication enabled and no anonymous access as it's private instance. #### Other notes / implementation ideas The ntfy server supports authentication via basic authorization (Authorization-Header) or as a query parameter. ([docs](https://docs.ntfy.sh/publish/#authentication)) The configuration could be extend to support the authentication data and if present, the data could be added to the headers in line 52 of [borgmatic/hooks/ntfy.py#L52](https://projects.torsion.org/borgmatic-collective/borgmatic/src/branch/master/borgmatic/hooks/ntfy.py#L52) #### Environment **borgmatic version:** 1.7.5 **borgmatic installation method:** pip **Borg version:** 1.2.0 **Python version:** 3.10.6 **Database version (if applicable):** n/a **operating system and version:** Ubuntu 22.04.1 LTS
👍 1
witten commented 2022-12-19 21:19:36 +00:00
Owner
Copy Link

Makes sense. Thanks for filing this! Sounds like borgmatic's ntfy configuration should also be changed as part of this implementation to allow configuration of a ntfy username and password. And then Python's requests library could maybe handle the encoding:

requests.post(..., auth=requests.auth.HTTPBasicAuth(username, password))
Makes sense. Thanks for filing this! Sounds like borgmatic's ntfy configuration should also be changed as part of this implementation to allow configuration of a ntfy `username` and `password`. And then Python's `requests` library could maybe handle the encoding: ```python requests.post(..., auth=requests.auth.HTTPBasicAuth(username, password)) ```
witten added the
good first issue
 label 2023-02-04 17:14:56 +00:00
witten commented 2023-02-25 22:24:37 +00:00
Owner
Copy Link

This will be part of the next release (1.7.8).

This will be part of the next release (1.7.8).
❤️ 2
witten commented 2023-03-02 23:43:01 +00:00
Owner
Copy Link

Just released. Thanks again!

Just released. Thanks again!
👍 1 ❤️ 1
crazy-weasel commented 2023-03-12 22:35:37 +00:00
Author
Copy Link

Great! I just updated my config, and it works as expected.

Thanks to all involved. :)

Great! I just updated my config, and it works as expected. Thanks to all involved. :)
👍 1
notDavid commented 2023-08-11 10:50:28 +00:00
Copy Link

Hmmz, just fyi in case someone else stumbles upon this, i noticed that in my upgraded version (i used borgmatic config generate -s .. -d ...) this part of the config was missing...:

# The username used for authentication.
    # username: testuser
Hmmz, just fyi in case someone else stumbles upon this, i noticed that in my upgraded version (i used `borgmatic config generate -s .. -d ...`) this part of the config was missing...: ``` # The username used for authentication. # username: testuser ```
witten commented 2023-08-11 15:20:23 +00:00
Owner
Copy Link

Thanks for the comment. Would you mind filing a ticket with details about this issue? It sounds like it could be a bug.

Thanks for the comment. Would you mind filing a ticket with details about this issue? It sounds like it could be a bug.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
spot-check
1.8.10
1.8.9
1.8.8
1.8.7
1.8.6
1.8.5
1.8.4
1.8.3
1.8.2
1.8.1
1.8.0
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.5.24
1.5.23
1.5.22
1.5.21
1.5.20
1.5.19
1.5.18
1.5.17
1.5.16
1.5.15
1.5.14
1.5.13
1.5.12
1.5.11
1.5.10
1.5.9
1.5.8
1.5.7
1.5.7.dev0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.22
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.26
1.3.25
1.3.24
1.3.23
1.3.22
1.3.21
1.3.20
1.3.19
1.3.18
1.3.17
1.3.16
1.3.15
1.3.14
1.3.13
1.3.12
1.3.11
1.3.10
1.3.9
1.3.8
1.3.7
1.3.6
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.18
1.2.17
1.2.16
1.2.15
1.2.14
1.2.13
1.2.12
1.2.11
1.2.10
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.3
1.0.2
1.0.1
1.0.0
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.7
0.0.6
0.0.5
0.0.4
0.0.3
0.0.2
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#621
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?