validate-borgmatic-config -c ~/.config/borgmatic/config.yaml crashes, if hooks is set but empty #604

New issue

Closed

opened 2022-10-23 19:09:34 +00:00 by jonasstein · 3 comments

jonasstein commented 2022-10-23 19:09:34 +00:00

Copy link

What I'm trying to do and why

validate-borgmatic-config -c ~/.config/borgmatic/config.yaml

where config.yaml has hooks: as last line.

Traceback (most recent call last):
  File "/usr/bin/validate-borgmatic-config", line 8, in <module>
    sys.exit(main())
  File "/usr/lib/python3.10/site-packages/borgmatic/commands/validate_config.py", line 45, in main
    validate.parse_configuration(config_filename, validate.schema_filename())
  File "/usr/lib/python3.10/site-packages/borgmatic/config/validate.py", line 105, in parse_configuration
    logs = normalize.normalize(config_filename, config)
  File "/usr/lib/python3.10/site-packages/borgmatic/config/normalize.py", line 18, in normalize
    healthchecks = config.get('hooks', {}).get('healthchecks')
AttributeError: 'NoneType' object has no attribute 'get'

Environment

app-backup/borgmatic-1.7.4

borgmatic installation method: Gentoo package

#### What I'm trying to do and why validate-borgmatic-config -c ~/.config/borgmatic/config.yaml where config.yaml has hooks: as last line. ``` Traceback (most recent call last): File "/usr/bin/validate-borgmatic-config", line 8, in <module> sys.exit(main()) File "/usr/lib/python3.10/site-packages/borgmatic/commands/validate_config.py", line 45, in main validate.parse_configuration(config_filename, validate.schema_filename()) File "/usr/lib/python3.10/site-packages/borgmatic/config/validate.py", line 105, in parse_configuration logs = normalize.normalize(config_filename, config) File "/usr/lib/python3.10/site-packages/borgmatic/config/normalize.py", line 18, in normalize healthchecks = config.get('hooks', {}).get('healthchecks') AttributeError: 'NoneType' object has no attribute 'get' ``` #### Environment app-backup/borgmatic-1.7.4 **borgmatic installation method:** Gentoo package

witten commented 2022-10-23 20:24:19 +00:00

Owner

Copy link

Thanks for reporting this! I've reproduced the same error locally by ending a configuration file with just hooks:. This should hopefully be an easy fix.

Thanks for reporting this! I've reproduced the same error locally by ending a configuration file with just `hooks:`. This should hopefully be an easy fix.

❤️ 1

witten added the

bug

label 2022-10-23 20:24:29 +00:00

witten referenced this issue from a commit 2022-10-23 20:56:20 +00:00

Fix traceback when a configuration section is present but lacking any options (#604).

witten commented 2022-10-23 20:57:29 +00:00

Owner

Copy link

This is fixed in master and will be part of the next release. Note that hooks: with no options beneath it is still invalid, but will cause a graceful error now rather than a traceback.

Thanks again for reporting it!

This is fixed in master and will be part of the next release. Note that `hooks:` with no options beneath it is still invalid, but will cause a graceful error now rather than a traceback. Thanks again for reporting it!

witten closed this issue 2022-10-23 20:57:29 +00:00

witten commented 2022-11-27 17:05:21 +00:00

Owner

Copy link

Just released in borgmatic 1.7.5!

Just released in borgmatic 1.7.5!

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

bootstrap-multiple-latest-archives

parallel-borgmatic

command-hook-steps

2.1.6

2.1.5

2.1.4

2.1.3

2.1.2

2.1.1

2.1.0

2.0.13

2.0.12

2.0.11

2.0.10

2.0.9

2.0.8

2.0.7

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.9.14

1.9.13

1.9.12

1.9.11

1.9.10

1.9.9

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

blocked

  

breaking

  

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No labels

blocked

breaking

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

borgmatic-collective/borgmatic#604

No description provided.