borgmatic --json info outputs non-json warnings #602

New Issue

Closed

opened 2022-10-21 13:57:42 +00:00 by satwell · 3 comments

satwell commented 2022-10-21 13:57:42 +00:00

Contributor

Copy Link

What I'm trying to do and why

Parse the output of borgmatic --json info in other scripts.

Steps to reproduce (if a bug)

Run borgmatic --json info 2>/dev/null with repositories configured to use deprecated SSH location syntax like user@host:backups.

Actual behavior (if a bug)

The above borgmatic command (which discards stderr output) will output something like this:

[{ ...json... }]
summary:
/etc/borgmatic/config.yaml: Remote repository paths without ssh:// syntax are deprecated. Interpreting "user@host:backups" as "ssh://user@host/./backups"

Expected behavior (if a bug)

Whne using --json, only parse-able JSON should go to stdout. Other messages should go to stderr. Otherwise, tools that parse the output will break.

Other notes / implementation ideas

Environment

borgmatic version: 1.7.4

borgmatic installation method: pex

Borg version: 1.1.16

Python version: 3.9.2

operating system and version: Debian Bullseye

#### What I'm trying to do and why Parse the output of `borgmatic --json info` in other scripts. #### Steps to reproduce (if a bug) Run `borgmatic --json info 2>/dev/null` with repositories configured to use deprecated SSH location syntax like `user@host:backups`. #### Actual behavior (if a bug) The above `borgmatic` command (which discards stderr output) will output something like this: ``` [{ ...json... }] summary: /etc/borgmatic/config.yaml: Remote repository paths without ssh:// syntax are deprecated. Interpreting "user@host:backups" as "ssh://user@host/./backups" ``` #### Expected behavior (if a bug) Whne using `--json`, only parse-able JSON should go to stdout. Other messages should go to stderr. Otherwise, tools that parse the output will break. #### Other notes / implementation ideas #### Environment **borgmatic version:** 1.7.4 **borgmatic installation method:** pex **Borg version:** 1.1.16 **Python version:** 3.9.2 **operating system and version:** Debian Bullseye

witten commented 2022-10-21 16:49:55 +00:00

Owner

Copy Link

Good find, and thank you for filing this!

Good find, and thank you for filing this!

witten added the

bug

label 2022-10-21 16:50:09 +00:00

witten referenced this issue from a commit 2022-12-02 20:12:42 +00:00

Fix logs that interfere with JSON output by making warnings go to stderr instead of stdout (#602).

witten commented 2022-12-02 20:14:47 +00:00

Owner

Copy Link

This is fixed in master and will be part of the next release. Warnings now go to stderr instead of stdout. In order to make this possible, I had to stop abusing the warning level and make certain logs (such as the output of borgmatic list) go to a new custom log level so they'd still show up on stdout.

Thanks again for filing this!

This is fixed in master and will be part of the next release. Warnings now go to stderr instead of stdout. In order to make this possible, I had to stop abusing the warning level and make certain logs (such as the output of `borgmatic list`) go to a new custom log level so they'd still show up on stdout. Thanks again for filing this!

witten closed this issue 2022-12-02 20:14:48 +00:00

witten commented 2023-01-26 23:25:33 +00:00

Owner

Copy Link

Just released in borgmatic 1.7.6!

Just released in borgmatic 1.7.6!

witten referenced this issue 2023-01-28 18:51:31 +00:00

Some strings (such as "Starting a backup.") wrongly sent to stderr since 1.7.6 #634

Write referenced this issue 2023-01-28 19:02:57 +00:00

Some strings (such as "Starting a backup.") wrongly sent to stderr since 1.7.6 #634

witten referenced this issue 2023-01-29 00:39:42 +00:00

Some strings (such as "Starting a backup.") wrongly sent to stderr since 1.7.6 #634

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#602

No description provided.