add "series" event parameters when pinging cronitor hook #592

Open
opened 2022-10-04 10:01:49 +00:00 by xLogiiCx · 3 comments

What I'm trying to do and why

i noticed, that for each mode bormatic runs (prune, compact, create etc.) it sends a single ping to cronitor.
it would be a great addition if you also could add the "series" event parameter. it would improve the clarity enormously

Expected behavior

when sending a single ping to cronitor add the current running mode (prune,compact,create etc) as a "series" event parameter in the request.
e.g

curl https://cronitor.link/p/e981f5ece0f948e8be3e05abdb4cf3f8/nightly-job?state=run&series=prune

in my opinion the best way would be to be able to addd a custom "series" and add a variable which contains the current borg mode.

Environment

borgmatic version: 1.7.2

borgmatic installation method: aur

Borg version: 1.2.2

Python version: Python 3.10.7

operating system and version: Linux 5.19.12-arch1-1 x86_64

#### What I'm trying to do and why i noticed, that for each mode bormatic runs (prune, compact, create etc.) it sends a single ping to cronitor. it would be a great addition if you also could add the "series" [event parameter](https://cronitor.io/docs/telemetry-api#parameters). it would improve the clarity enormously #### Expected behavior when sending a single ping to cronitor add the current running mode (prune,compact,create etc) as a "series" event parameter in the request. e.g ``` curl https://cronitor.link/p/e981f5ece0f948e8be3e05abdb4cf3f8/nightly-job?state=run&series=prune ``` in my opinion the best way would be to be able to addd a custom "series" and add a variable which contains the current borg mode. #### Environment **borgmatic version:** 1.7.2 **borgmatic installation method:** aur **Borg version:** 1.2.2 **Python version:** Python 3.10.7 **operating system and version:** Linux 5.19.12-arch1-1 x86_64
Owner

Interesting! I didn't know Cronitor supported this. Would this series support be preferable to a feature like #518 (separate ping URLs per borgmatic action)? Or would you potentially take advantage of both?

Interesting! I didn't know Cronitor supported this. Would this `series` support be preferable to a feature like #518 (separate ping URLs per borgmatic action)? Or would you potentially take advantage of both?
Author

I like both Ideas.

Then you could decide if you use them in a Single Check and keep the different options appart with the "series" support.
Or you could create different task with the #518 Idea to get a better overview of the duration of the single commands for example.

I like both Ideas. Then you could decide if you use them in a Single Check and keep the different options appart with the "series" support. Or you could create different task with the #518 Idea to get a better overview of the duration of the single commands for example.
Owner

That makes sense to me!

That makes sense to me!
witten added the
good first issue
label 2023-02-04 17:17:09 +00:00
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#592
No description provided.