add "series" event parameters when pinging cronitor hook #592
Labels
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: borgmatic-collective/borgmatic#592
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What I'm trying to do and why
i noticed, that for each mode bormatic runs (prune, compact, create etc.) it sends a single ping to cronitor.
it would be a great addition if you also could add the "series" event parameter. it would improve the clarity enormously
Expected behavior
when sending a single ping to cronitor add the current running mode (prune,compact,create etc) as a "series" event parameter in the request.
e.g
in my opinion the best way would be to be able to addd a custom "series" and add a variable which contains the current borg mode.
Environment
borgmatic version: 1.7.2
borgmatic installation method: aur
Borg version: 1.2.2
Python version: Python 3.10.7
operating system and version: Linux 5.19.12-arch1-1 x86_64
Interesting! I didn't know Cronitor supported this. Would this
series
support be preferable to a feature like #518 (separate ping URLs per borgmatic action)? Or would you potentially take advantage of both?I like both Ideas.
Then you could decide if you use them in a Single Check and keep the different options appart with the "series" support.
Or you could create different task with the #518 Idea to get a better overview of the duration of the single commands for example.
That makes sense to me!