Illegal option combination is permitted #59

New Issue

Closed

opened 2018-04-17 11:12:03 +00:00 by pocal · 5 comments

pocal commented 2018-04-17 11:12:03 +00:00

Copy Link

While creating my first Borgmatic config.yaml file, I tried this:

   checks:
#         - disabled
        - repository
#        - archives

and got this error:

/storage/Backups/Borg: Creating archive (dry run; not making any changes)
/storage/Backups/Borg: Running consistency checks
--repository-only contradicts --first, --last, --prefix and --verify-data arguments.
/etc/borgmatic/config.yaml: Running command for on-error hook
Tue 17 Apr 11:46:53 BST 2018 - Error while creating a backup.
Command '('borg', 'check', '/storage/Backups/Borg', '--repository-only', '--last', '2', '--lock-wait', '5', '--info')' returned non-zero exit status 2.

If this combination is illegal, the consistency check should notice before running Borg.

While creating my first Borgmatic config.yaml file, I tried this: ``` checks: # - disabled - repository # - archives ``` and got this error: ``` /storage/Backups/Borg: Creating archive (dry run; not making any changes) /storage/Backups/Borg: Running consistency checks --repository-only contradicts --first, --last, --prefix and --verify-data arguments. /etc/borgmatic/config.yaml: Running command for on-error hook Tue 17 Apr 11:46:53 BST 2018 - Error while creating a backup. Command '('borg', 'check', '/storage/Backups/Borg', '--repository-only', '--last', '2', '--lock-wait', '5', '--info')' returned non-zero exit status 2. ``` If this combination is illegal, the consistency check should notice before running Borg.

witten added the

bug

label 2018-05-19 23:23:21 +00:00

witten commented 2018-05-19 23:25:53 +00:00

Owner

Copy Link

Thanks for reporting this! What I'll do is just avoid passing the --last option to Borg in the case that the archives check isn't being run. My thinking is that you still might want it in your config file even if it doesn't take effect.. You might be commenting out - archives temporarily or whatever.

Thanks for reporting this! What I'll do is just avoid passing the `--last` option to Borg in the case that the archives check isn't being run. My thinking is that you still might want it in your config file even if it doesn't take effect.. You might be commenting out `- archives` temporarily or whatever.

pocal commented 2018-05-20 10:43:47 +00:00

Author

Copy Link

OK, that's reasonable. Maybe add a comment in the output to warn that checks are not being run.

OK, that's reasonable. Maybe add a comment in the output to warn that checks are not being run.

witten referenced this issue from a commit 2018-05-21 05:11:54 +00:00

Ignore "check_last" and consistency "prefix" when "archives" not in consistency checks. (#59)

witten commented 2018-05-21 05:12:31 +00:00

Owner

Copy Link

Good call. Just completed this in master. It'll go out with the next release. Thanks again.

Good call. Just completed this in master. It'll go out with the next release. Thanks again.

witten closed this issue 2018-05-21 05:12:31 +00:00

witten commented 2018-06-17 22:22:33 +00:00

Owner

Copy Link

This has just been released as part of borgmatic 1.2.0!

This has just been released as part of borgmatic 1.2.0!

pocal commented 2018-06-17 22:29:33 +00:00

Author

Copy Link

Thanks, I'll check it out.

Thanks, I'll check it out.

witten referenced this issue from a commit 2023-03-23 19:58:14 +00:00

Fix: remove extra links from docs css.

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

config-command-line

1.9.14

1.9.13

1.9.12

1.9.11

1.9.10

1.9.9

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels

blocked

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

No Label

bug

Milestone

No items

No Milestone

Assignees

Clear assignees

diivi import_bot witten

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#59

No description provided.