change prefix for glob_archives or create an alias glob_archives to prefix ? #588

New Issue

Closed

opened 2022-09-28 03:30:11 +00:00 by hrv231 · 4 comments

hrv231 commented 2022-09-28 03:30:11 +00:00

Copy Link

What I'm trying to do and why

Hello,
I just upgraded to borg v1.2.2 and borgmatic v1.7.2

Reading the changelog from borg, I noticed that --prefix is deprecated, use -a / --glob-archives, see borgbackup #6806

--prefix still works on 1.2.x, but will not work on 2.x

example:

retention:
    keep_weekly: 3
    keep_yearly: 1
    prefix: 'myrepo-'

consistency:
    checks:
        - name: archives
    check_last: 7
    prefix: 'myrepo-'

Steps to reproduce (if a bug)

Not a bug

Actual behavior (if a bug)

Not a bug

Expected behavior (if a bug)

Other notes / implementation ideas

I would like an alias to what today is prefix or another option like glob_archives to use instead of prefix.

Right now I know that with the prefix option the yaml is calling --glob-archives, so everything is good, but would be nice to have the option by the name.

retention:
    keep_weekly: 3
    keep_yearly: 1
    glob_archives: 'myrepo-'

consistency:
    checks:
        - name: archives
    check_last: 7
    glob_archives: 'myrepo-'

Environment

borgmatic version: [1.7.2]

borgmatic installation method: [Docker container]

Borg version: [1.2.2]

Python version: [3.10.6]

Database version (if applicable): [version here]

Use psql --version or mysql --version on client and server.

operating system and version: [OS here]

#### What I'm trying to do and why Hello, I just upgraded to borg v1.2.2 and borgmatic v1.7.2 Reading the changelog from borg, I noticed that --prefix is deprecated, use -a / --glob-archives, see borgbackup [#6806](https://github.com/borgbackup/borg/issues/6806) *--prefix* still works on 1.2.x, but will not work on 2.x example: ``` retention: keep_weekly: 3 keep_yearly: 1 prefix: 'myrepo-' consistency: checks: - name: archives check_last: 7 prefix: 'myrepo-' ``` #### Steps to reproduce (if a bug) Not a bug #### Actual behavior (if a bug) Not a bug #### Expected behavior (if a bug) #### Other notes / implementation ideas I would like an alias to what today is prefix or another option like *glob_archives* to use instead of prefix. Right now I know that with the prefix option the yaml is calling --glob-archives, so everything is good, but would be nice to have the option by the name. ``` retention: keep_weekly: 3 keep_yearly: 1 glob_archives: 'myrepo-' consistency: checks: - name: archives check_last: 7 glob_archives: 'myrepo-' ``` #### Environment **borgmatic version:** [1.7.2] **borgmatic installation method:** [Docker container] **Borg version:** [1.2.2] **Python version:** [3.10.6] **Database version (if applicable):** [version here] Use `psql --version` or `mysql --version` on client and server. **operating system and version:** [OS here]

witten commented 2022-09-28 03:37:13 +00:00

Owner

Copy Link

Thanks for filing this. Adding glob_archives as an option seems reasonable to me! Maybe though it shouldn't act exactly the same as prefix, so for instance you'd have to use a value of myrepo-* if you wanted the same behavior as a prefix of myrepo- ? That would also support use cases like a glob_archives value of *glob*. In any case, do you think it would make sense to error if both prefix and glob_archives are used in a configuration section?

Thanks for filing this. Adding `glob_archives` as an option seems reasonable to me! Maybe though it shouldn't act exactly the same as `prefix`, so for instance you'd have to use a value of `myrepo-*` if you wanted the same behavior as a `prefix` of `myrepo-` ? That would also support use cases like a `glob_archives` value of `*glob*`. In any case, do you think it would make sense to error if both `prefix` and `glob_archives` are used in a configuration section?

hrv231 commented 2022-09-28 04:23:25 +00:00

Author

Copy Link

No, thank you for all your hard work.

I agree with you.
I think that having an error is great in this case.

No, thank you for all your hard work. I agree with you. I think that having an error is great in this case.

👍 1

witten commented 2022-10-03 04:43:03 +00:00

Owner

Copy Link

Borg 2.0.0 beta 3 has just renamed --glob-archives to --match-archives, so the borgmatic option would probably be called match_archives! Additionally, the syntax has changed a bit from --glob-archives.. --match-archives supports additional pattern styles now.

Borg 2.0.0 beta 3 has just renamed `--glob-archives` to `--match-archives`, so the borgmatic option would probably be called `match_archives`! Additionally, the syntax has changed a bit from `--glob-archives`.. `--match-archives` supports additional pattern styles now.

witten referenced this issue 2022-10-04 05:52:31 +00:00

Support for Borg 2 beta 3 --match-archives #591

witten referenced this issue 2022-10-16 16:33:35 +00:00

Support for multiple prefixes/archive/glob matchers? #599

witten referenced this issue 2023-03-31 22:31:19 +00:00

How to prevent repeating output of the same by list, info, ... commands #479

witten referenced this issue from a commit 2023-04-02 06:58:21 +00:00

Add "match_archives" option (#588).

witten commented 2023-04-02 06:59:53 +00:00

Owner

Copy Link

This is implemented with a new match_archives option and will part of the next release. The documentation for this feature will appear here shortly: https://torsion.org/borgmatic/docs/how-to/make-per-application-backups/#archive-naming

Thanks for suggesting this!

This is implemented with a new `match_archives` option and will part of the next release. The documentation for this feature will appear here shortly: https://torsion.org/borgmatic/docs/how-to/make-per-application-backups/#archive-naming Thanks for suggesting this!

🎉 1

witten closed this issue 2023-04-02 06:59:53 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#588

No description provided.