borgmatic info no longer giving specific archive information #577

New Issue

Closed

opened 2022-08-31 02:08:37 +00:00 by doy · 3 comments

doy commented 2022-08-31 02:08:37 +00:00

Copy Link

What I'm trying to do and why

previously, running borgmatic info --archive latest would include information about both the overall repository and also specific statistics about the latest archive, but as of version 1.7.0, borgmatic info and borgmatic info --archive latest produce identical output.

Steps to reproduce (if a bug)

run borgmatic info --archive latest

Actual behavior (if a bug)

$ sudo borgmatic info --archive latest
[redacted]: Displaying archive summary information
Repository ID: e8b8a32c06789183e822824492b0157638b2f6963549cfdab094b3503c899d13
Location: [redacted]
Encrypted: Yes (repokey)
Cache: /root/.cache/borg/e8b8a32c06789183e822824492b0157638b2f6963549cfdab094b3503c899d13
Security dir: /root/.config/borg/security/e8b8a32c06789183e822824492b0157638b2f6963549cfdab094b3503c899d13
------------------------------------------------------------------------------
                       Original size      Compressed size    Deduplicated size
All archives:                4.45 TB              3.87 TB            222.96 GB
                       Unique chunks         Total chunks
Chunk index:                  829636             14654304

Expected behavior (if a bug)

$ sudo borgmatic info --archive latest
[redacted]: Displaying summary info for archives
Archive name: [redacted]-2022-08-30T03:31:05.000968
Archive fingerprint: 4c1ec48827fd4ceace0d40d170f4865d19222799784d32c8ba49b7674b573c55
Comment:
Hostname: [redacted]
Username: root
Time (start): Tue, 2022-08-30 03:31:07
Time (end): Tue, 2022-08-30 06:52:43
Duration: 3 hours 21 minutes 36.87 seconds
Number of files: 645545
Command line: /usr/bin/borg create --exclude-from /tmp/tmpa9zhdtjk --info '[redacted]::{hostname}-{now:%Y-%m-%dT%H:%M:%S.%f}' /etc /home /root/.borgmatic /usr/local/bin
Utilization of maximum supported archive size: 0%
------------------------------------------------------------------------------
                       Original size      Compressed size    Deduplicated size
This archive:              202.33 GB            174.06 GB              3.69 GB
All archives:                4.45 TB              3.87 TB            222.96 GB
                       Unique chunks         Total chunks
Chunk index:                  829636             14654304

Other notes / implementation ideas

specifically i'm interested in the json formatted data, but it looks like the issue is the same for normal and json output

Environment

borgmatic version: 1.7.0

Use sudo borgmatic --version or sudo pip show borgmatic | grep ^Version

borgmatic installation method: pacman (arch linux)

Borg version: 1.2.2

Use sudo borg --version

Python version: 3.10.6

Use python3 --version

Database version (if applicable): [version here]

Use psql --version or mysql --version on client and server.

operating system and version: arch linux

#### What I'm trying to do and why previously, running `borgmatic info --archive latest` would include information about both the overall repository and also specific statistics about the latest archive, but as of version 1.7.0, `borgmatic info` and `borgmatic info --archive latest` produce identical output. #### Steps to reproduce (if a bug) run `borgmatic info --archive latest` #### Actual behavior (if a bug) ``` $ sudo borgmatic info --archive latest [redacted]: Displaying archive summary information Repository ID: e8b8a32c06789183e822824492b0157638b2f6963549cfdab094b3503c899d13 Location: [redacted] Encrypted: Yes (repokey) Cache: /root/.cache/borg/e8b8a32c06789183e822824492b0157638b2f6963549cfdab094b3503c899d13 Security dir: /root/.config/borg/security/e8b8a32c06789183e822824492b0157638b2f6963549cfdab094b3503c899d13 ------------------------------------------------------------------------------ Original size Compressed size Deduplicated size All archives: 4.45 TB 3.87 TB 222.96 GB Unique chunks Total chunks Chunk index: 829636 14654304 ``` #### Expected behavior (if a bug) ``` $ sudo borgmatic info --archive latest [redacted]: Displaying summary info for archives Archive name: [redacted]-2022-08-30T03:31:05.000968 Archive fingerprint: 4c1ec48827fd4ceace0d40d170f4865d19222799784d32c8ba49b7674b573c55 Comment: Hostname: [redacted] Username: root Time (start): Tue, 2022-08-30 03:31:07 Time (end): Tue, 2022-08-30 06:52:43 Duration: 3 hours 21 minutes 36.87 seconds Number of files: 645545 Command line: /usr/bin/borg create --exclude-from /tmp/tmpa9zhdtjk --info '[redacted]::{hostname}-{now:%Y-%m-%dT%H:%M:%S.%f}' /etc /home /root/.borgmatic /usr/local/bin Utilization of maximum supported archive size: 0% ------------------------------------------------------------------------------ Original size Compressed size Deduplicated size This archive: 202.33 GB 174.06 GB 3.69 GB All archives: 4.45 TB 3.87 TB 222.96 GB Unique chunks Total chunks Chunk index: 829636 14654304 ``` #### Other notes / implementation ideas specifically i'm interested in the json formatted data, but it looks like the issue is the same for normal and json output #### Environment **borgmatic version:** 1.7.0 Use `sudo borgmatic --version` or `sudo pip show borgmatic | grep ^Version` **borgmatic installation method:** pacman (arch linux) **Borg version:** 1.2.2 Use `sudo borg --version` **Python version:** 3.10.6 Use `python3 --version` **Database version (if applicable):** [version here] Use `psql --version` or `mysql --version` on client and server. **operating system and version:** arch linux

witten commented 2022-08-31 03:31:11 +00:00

Owner

Copy Link

Yikes, thank you for taking the time to report this! I've reproduced the regression locally. I'm guessing it was introduced in 1.7.0 as part of the changes for Borg 2. I'll look into it.

Yikes, thank you for taking the time to report this! I've reproduced the regression locally. I'm guessing it was introduced in 1.7.0 as part of the changes for Borg 2. I'll look into it.

witten added the bug label 2022-08-31 03:31:19 +00:00

witten referenced this issue from a commit 2022-08-31 03:42:56 +00:00

Fix regression in which "borgmatic info --archive ..." showed repository info instead of archive info with Borg 1 (#577).

witten commented 2022-08-31 03:45:30 +00:00

Owner

Copy Link

Okay, this is fixed now in master and will be part of the next release! The problem was that borgmatic info was passing the archive flag (or in this case, the --glob-archives flag) to Borg, but only with Borg 2. Now that code path applies to Borg 1 as well.

Thanks again for bringing this to my attention.

Okay, this is fixed now in master and will be part of the next release! The problem was that `borgmatic info` was passing the archive flag (or in this case, the `--glob-archives` flag) to Borg, but only with Borg 2. Now that code path applies to Borg 1 as well. Thanks again for bringing this to my attention.

witten closed this issue 2022-08-31 03:45:30 +00:00

witten commented 2022-09-08 17:31:26 +00:00

Owner

Copy Link

Just released in borgmatic 1.7.2!

Just released in borgmatic 1.7.2!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

command-hook-steps

2.0.12

2.0.11

2.0.10

2.0.9

2.0.8

2.0.7

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.9.14

1.9.13

1.9.12

1.9.11

1.9.10

1.9.9

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels

blocked

breaking

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

No Label bug

Milestone

No items

No Milestone

Assignees

Clear assignees

witten

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#577