ZFS dataset is treated as a different filesystem - careful with option 'one_file_system' #570

New Issue

Closed

opened 2022-07-30 19:00:47 +00:00 by zenlord · 5 comments

zenlord commented 2022-07-30 19:00:47 +00:00

Copy Link

What I'm trying to do and why

Never waste a good crisis: I had to restore data from my borgmatic-backups and came to the conclusion that the contents of the /home// folders had not been included in the backup.

Steps to reproduce (if a bug)

My config file (or extracts from):

location:
  source_directories:
    [...]
  - /home

repositories:
  - xxx.repo.borgbase.com:repo

exclude_patterns:
  - /home/*/.cache/
  - /home/*/.zfs/

one_file_system: true
exclude_caches: true

Actual behavior (if a bug)

The archives contain all source_directories, and the contents is complete, with the exception of the /home directory: this directory only includes the 'first depth' directories, not the contents.

I have been reading up on the 'borg help patterns', and even tried to experiment with "borg create --dry-run", but I cannot find the root cause for this missing data in my archives?

Environment

borgmatic version:
# borgmatic --version
1.5.13.dev0
# apt policy borgmatic
borgmatic:
Geïnstalleerd: 1.5.12-2
Kandidaat: 1.5.12-2
Versietabel:
*** 1.5.12-2 500

borgmatic installation method:
Debian package (bullseye)

Borg version:
# borg --version
borg 1.1.16

Python version:
# python3 --version
Python 3.9.2

Database version (if applicable):
N/A

operating system and version:
Debian Bullseye (up-to-date)

#### What I'm trying to do and why Never waste a good crisis: I had to restore data from my borgmatic-backups and came to the conclusion that the contents of the /home/<usernames>/ folders had not been included in the backup. #### Steps to reproduce (if a bug) My config file (or extracts from): location: source_directories: [...] - /home repositories: - xxx.repo.borgbase.com:repo exclude_patterns: - /home/*/.cache/ - /home/*/.zfs/ one_file_system: true exclude_caches: true #### Actual behavior (if a bug) The archives contain all source_directories, and the contents is complete, with the exception of the /home directory: this directory only includes the 'first depth' directories, not the contents. I have been reading up on the 'borg help patterns', and even tried to experiment with "borg create --dry-run", but I cannot find the root cause for this missing data in my archives? #### Environment **borgmatic version:** # borgmatic --version 1.5.13.dev0 # apt policy borgmatic borgmatic: Geïnstalleerd: 1.5.12-2 Kandidaat: 1.5.12-2 Versietabel: *** 1.5.12-2 500 **borgmatic installation method:** Debian package (bullseye) **Borg version:** # borg --version borg 1.1.16 **Python version:** # python3 --version Python 3.9.2 **Database version (if applicable):** N/A **operating system and version:** Debian Bullseye (up-to-date)

witten commented 2022-08-01 17:03:31 +00:00

Owner

Copy Link

Looking at your configuration, I'm not sure what's going on.. I have similar glob excludes in my own configuration, and they appear to work as expected. A few thoughts though:

• Is this issue reproducible by just running Borg by itself without borgmatic? You can run borgmatic --verbosity 2 to get most of the borg command-line, although that won't show you the excludes in particular, because those are passed in via a separate temporary file.
• one_file_system: true is making my spidey sense tingle. Is /home mounted on a different filesystem, perhaps?
• How are you inspecting the contents of the archive to see whether the /home contents are present? Something like borgmatic list --archive latest?
• It looks like you're using a two-year-old version of borgmatic. I recommend upgrading if you can!

Looking at your configuration, I'm not sure what's going on.. I have similar glob excludes in my own configuration, and they appear to work as expected. A few thoughts though: * Is this issue reproducible by just running Borg by itself without borgmatic? You can run `borgmatic --verbosity 2` to get most of the `borg` command-line, although that won't show you the excludes in particular, because those are passed in via a separate temporary file. * `one_file_system: true` is making my spidey sense tingle. Is `/home` mounted on a different filesystem, perhaps? * How are you inspecting the contents of the archive to see whether the `/home` contents are present? Something like `borgmatic list --archive latest`? * It looks like you're using a two-year-old version of borgmatic. I recommend upgrading if you can!

witten added the

question / support

label 2022-08-01 17:03:37 +00:00

zenlord commented 2022-08-01 22:09:01 +00:00

Author

Copy Link

Thank you for your fast response!

1: I'll try that tomorrow evening and report back
2: I had the same hunch (and appreciate the Spiderman refrence :p)- /home is a dataset in a ZFS pool, just like /share, but the difference is that I have created a separate dataset for each of the users inside /home. All of them are however local filesystems
3: No, I first used a 'borgmatic extract' command and once I noticed the data was missing, I also used 'borgmatic mount' with several archives.
4: well noted. I try to stick as much as possible to the stable repository, but principles are there to be broken, I guess.

Thank you for your fast response! 1: I'll try that tomorrow evening and report back 2: I had the same hunch (and appreciate the Spiderman refrence :p)- /home is a dataset in a ZFS pool, just like /share, but the difference is that I have created a separate dataset for each of the users inside /home. All of them are however local filesystems 3: No, I first used a 'borgmatic extract' command and once I noticed the data was missing, I also used 'borgmatic mount' with several archives. 4: well noted. I try to stick as much as possible to the stable repository, but principles are there to be broken, I guess.

witten commented 2022-08-01 22:46:45 +00:00

Owner

Copy Link

2: I had the same hunch (and appreciate the Spiderman refrence :p)- /home is a dataset in a ZFS pool, just like /share, but the difference is that I have created a separate dataset for each of the users inside /home. All of them are however local filesystems

Interesting. I'm not super familiar with ZFS, but I'd bet that a mounted ZFS pool is treated as a separate filesystem by Borg, and therefore one_file_system is preventing Borg from backing up anything in /home. Have you tried setting one_file_system to false to see if that "fixes" the problem of /home contents not getting included?

3: No, I first used a 'borgmatic extract' command and once I noticed the data was missing, I also used 'borgmatic mount' with several archives.

Either of those seems like a reliable away to test archive contents.

> 2: I had the same hunch (and appreciate the Spiderman refrence :p)- /home is a dataset in a ZFS pool, just like /share, but the difference is that I have created a separate dataset for each of the users inside /home. All of them are however local filesystems Interesting. I'm not super familiar with ZFS, but I'd bet that a mounted ZFS pool is treated as a separate filesystem by Borg, and therefore `one_file_system` is preventing Borg from backing up anything in `/home`. Have you tried setting `one_file_system` to `false` to see if that "fixes" the problem of `/home` contents not getting included? > 3: No, I first used a 'borgmatic extract' command and once I noticed the data was missing, I also used 'borgmatic mount' with several archives. Either of those seems like a reliable away to test archive contents.

zenlord commented 2022-08-02 13:16:51 +00:00

Author

Copy Link

Interesting. I'm not super familiar with ZFS, but I'd bet that a mounted ZFS pool is treated as a separate filesystem by Borg, and therefore one_file_system is preventing Borg from backing up anything in /home. Have you tried setting one_file_system to false to see if that "fixes" the problem of /home contents not getting included?

That did the trick - I have changed the configuration and the latest archive indeed contains the contents of the /home/ source_location.
I'll edit the title of this issue for future reference, and this can be closed.

Thank you!!
(and I promise, from now on, to test my backup archives periodically - "with great power comes great responsibility" ;))

> Interesting. I'm not super familiar with ZFS, but I'd bet that a mounted ZFS pool is treated as a separate filesystem by Borg, and therefore `one_file_system` is preventing Borg from backing up anything in `/home`. Have you tried setting `one_file_system` to `false` to see if that "fixes" the problem of `/home` contents not getting included? That did the trick - I have changed the configuration and the latest archive indeed contains the contents of the /home/ source_location. I'll edit the title of this issue for future reference, and this can be closed. Thank you!! (and I promise, from now on, to test my backup archives periodically - "with great power comes great responsibility" ;))

zenlord changed title from Missing data in archive: Confused by exclude_patterns? to ZFS dataset is treated as a different filesystem - careful with option 'one_file_system' 2022-08-02 13:19:06 +00:00

witten commented 2022-08-02 15:52:21 +00:00

Owner

Copy Link

I'm glad to hear that did it!

I'm glad to hear that did it!

witten closed this issue 2022-08-02 15:52:21 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#570

No description provided.