borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
15
56
Fork 39
Code Issues 52 Pull Requests 1 Actions Packages Releases 121 Activity

Improve error message when mounting archive when multiple repositories are defined #566

New Issue
Closed
opened 2022-07-24 09:07:56 +00:00 by NielsH · 6 comments
NielsH commented 2022-07-24 09:07:56 +00:00
Copy Link

What I'm trying to do and why

We're busy migrating our backups to a different storage backend. This means we now have two different repositories defined within the borgmatic configuration.

Backups have a timestamp in their archive name, and while similar, the name is of course different on both backup repositories. Now when we attempt to mount a backup that is present on our second repository borgmatic will try to mount it from our first defined repository first. This fails, of course, and prints out a big red error message.

After that, it tries mounting it from the second defined repository, and succeeds since the archive name is present there, but the success is silent. This leads to a red error message but in fact also having succeeded in mounting it from the other repo.

This behaviour is a bit confusing.

Steps to reproduce (if a bug)

So if you have defined 2 repositories in a borgmatic config and do a borgmatic list, you'd get something like this (filtered):

ssh://borg@10.40.5.10:22/./bb9ae878-ef5b-4c4b-bbad-4490e5643d52: Listing archives
demo03-2022-07-24T03:48:34.972201    Sun, 2022-07-24 03:48:36 [370e3aec0e881295dab1325b9bd6ad5a8fb746e95c25f12c991b5a0fe171af4e]
ssh://borg@10.40.5.20:22/./bb9ae878-ef5b-4c4b-bbad-4490e5643d52: Listing archives
demo03-2022-07-24T03:49:45.410766    Sun, 2022-07-24 03:49:46 [a4bdd085d7dfe64c3832865cb1aae5c9197f34b4d58b1e67b1597094340d1dcf]

Now if we attempt to mount the secondary archive:

root@demo03:~# borgmatic mount --archive=demo03-2022-07-24T03:49:45.410766 --mount-point=/mnt
ssh://borg@10.40.5.10:22/./bb9ae878-ef5b-4c4b-bbad-4490e5643d52: Error running actions for repository
Command 'borg mount --lock-wait 7200 ssh://borg@10.40.5.10:22/./bb9ae878-ef5b-4c4b-bbad-4490e5643d52::demo03-2022-07-24T03:49:45.410766 /mnt' returned non-zero exit status 2.
/etc/borgmatic.d/aerial-bear.yaml: Error running configuration file

summary:
/etc/borgmatic.d/aerial-bear.yaml: Error running configuration file
ssh://borg@10.40.5.10:22/./bb9ae878-ef5b-4c4b-bbad-4490e5643d52: Error running actions for repository
Archive demo03-2022-07-24T03:49:45.410766 does not exist
Command 'borg mount --lock-wait 7200 ssh://borg@10.40.5.10:22/./bb9ae878-ef5b-4c4b-bbad-4490e5643d52::demo03-2022-07-24T03:49:45.410766 /mnt' returned non-zero exit status 2.

Need some help? https://torsion.org/borgmatic/#issues

However, it mounted correctly from the second backup repository:

root@demo03:~# mount | grep /mnt
borgfs on /mnt type fuse (ro,nosuid,nodev,relatime,user_id=0,group_id=0,default_permissions)

Other notes / implementation ideas

Perhaps when multiple repo's are present either give the error message at the end if all repo's failed to mount the supplied archive, or give an information message that:

  1. the backup is being attempted to mount from $repo
  2. Succeeded, or, when it failed, that:
  3. It is now being attempted to be mounted from $second_repo
  4. Succedeeded (repeat if >2 repo's are defined)

Environment

borgmatic version: [1.6.6]

Use sudo borgmatic --version or sudo pip show borgmatic | grep ^Version

borgmatic installation method: [pip]

Borg version: [1.2.1]

Use sudo borg --version

Python version: [3.9.2]

Use python3 --version

operating system and version: [Debian 11]

#### What I'm trying to do and why We're busy migrating our backups to a different storage backend. This means we now have two different repositories defined within the borgmatic configuration. Backups have a timestamp in their archive name, and while similar, the name is of course different on both backup repositories. Now when we attempt to mount a backup that is present on our second repository borgmatic will try to mount it from our first defined repository first. This fails, of course, and prints out a big red error message. After that, it tries mounting it from the second defined repository, and succeeds since the archive name *is* present there, but the success is silent. This leads to a red error message but in fact also having succeeded in mounting it from the other repo. This behaviour is a bit confusing. #### Steps to reproduce (if a bug) So if you have defined 2 repositories in a borgmatic config and do a borgmatic list, you'd get something like this (filtered): ``` ssh://borg@10.40.5.10:22/./bb9ae878-ef5b-4c4b-bbad-4490e5643d52: Listing archives demo03-2022-07-24T03:48:34.972201 Sun, 2022-07-24 03:48:36 [370e3aec0e881295dab1325b9bd6ad5a8fb746e95c25f12c991b5a0fe171af4e] ssh://borg@10.40.5.20:22/./bb9ae878-ef5b-4c4b-bbad-4490e5643d52: Listing archives demo03-2022-07-24T03:49:45.410766 Sun, 2022-07-24 03:49:46 [a4bdd085d7dfe64c3832865cb1aae5c9197f34b4d58b1e67b1597094340d1dcf] ``` Now if we attempt to mount the secondary archive: ``` root@demo03:~# borgmatic mount --archive=demo03-2022-07-24T03:49:45.410766 --mount-point=/mnt ssh://borg@10.40.5.10:22/./bb9ae878-ef5b-4c4b-bbad-4490e5643d52: Error running actions for repository Command 'borg mount --lock-wait 7200 ssh://borg@10.40.5.10:22/./bb9ae878-ef5b-4c4b-bbad-4490e5643d52::demo03-2022-07-24T03:49:45.410766 /mnt' returned non-zero exit status 2. /etc/borgmatic.d/aerial-bear.yaml: Error running configuration file summary: /etc/borgmatic.d/aerial-bear.yaml: Error running configuration file ssh://borg@10.40.5.10:22/./bb9ae878-ef5b-4c4b-bbad-4490e5643d52: Error running actions for repository Archive demo03-2022-07-24T03:49:45.410766 does not exist Command 'borg mount --lock-wait 7200 ssh://borg@10.40.5.10:22/./bb9ae878-ef5b-4c4b-bbad-4490e5643d52::demo03-2022-07-24T03:49:45.410766 /mnt' returned non-zero exit status 2. Need some help? https://torsion.org/borgmatic/#issues ``` However, it mounted correctly from the second backup repository: ``` root@demo03:~# mount | grep /mnt borgfs on /mnt type fuse (ro,nosuid,nodev,relatime,user_id=0,group_id=0,default_permissions) ``` #### Other notes / implementation ideas Perhaps when multiple repo's are present either give the error message at the end if all repo's failed to mount the supplied archive, or give an information message that: 1. the backup is being attempted to mount from $repo 2. Succeeded, or, when it failed, that: 3. It is now being attempted to be mounted from $second_repo 4. Succedeeded (repeat if >2 repo's are defined) #### Environment **borgmatic version:** [1.6.6] Use `sudo borgmatic --version` or `sudo pip show borgmatic | grep ^Version` **borgmatic installation method:** [pip] **Borg version:** [1.2.1] Use `sudo borg --version` **Python version:** [3.9.2] Use `python3 --version` **operating system and version:** [Debian 11]
witten commented 2022-07-24 19:59:03 +00:00
Owner
Copy Link

Thanks for filing this! I totally agree that the existing behavior is confusing. What do you think of making the --repository flag required for borgmatic mount if there are multiple repositories configured (or in general)? It doesn't really make sense to attempt to mount a named archive from multiple repositories onto a single mount point; one of them is going to fail.

Thanks for filing this! I totally agree that the existing behavior is confusing. What do you think of making the `--repository` flag required for `borgmatic mount` if there are multiple repositories configured (or in general)? It doesn't really make sense to attempt to mount a named archive from multiple repositories onto a single mount point; one of them is going to fail.
NielsH commented 2022-07-24 20:15:54 +00:00
Author
Copy Link

Requiring the repository flag when multiple mountpoints are defined seems fair to me as well, with a informational message that this flag is required when attempting to mount without supplying --repository.

I personally wouldn't require it when just a single repository is defined; having it filled in automatically when there's only one possible choice to make seems more user friendly 👍

Requiring the repository flag when multiple mountpoints are defined seems fair to me as well, with a informational message that this flag is required when attempting to mount without supplying `--repository`. I personally wouldn't require it when just a single repository is defined; having it filled in automatically when there's only one possible choice to make seems more user friendly 👍
witten commented 2022-07-24 21:40:02 +00:00
Owner
Copy Link

That makes sense, thanks!

That makes sense, thanks!
witten commented 2022-07-25 18:30:36 +00:00
Owner
Copy Link

This is implemented in master now, and will be part of the next release. Thanks again!

This is implemented in master now, and will be part of the next release. Thanks again!
NielsH commented 2022-07-25 19:33:39 +00:00
Author
Copy Link

Thank you!

Thank you!
witten commented 2022-08-22 04:59:53 +00:00
Owner
Copy Link

Just released in borgmatic 1.7.0!

Just released in borgmatic 1.7.0!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
spot-check
1.8.10
1.8.9
1.8.8
1.8.7
1.8.6
1.8.5
1.8.4
1.8.3
1.8.2
1.8.1
1.8.0
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.5.24
1.5.23
1.5.22
1.5.21
1.5.20
1.5.19
1.5.18
1.5.17
1.5.16
1.5.15
1.5.14
1.5.13
1.5.12
1.5.11
1.5.10
1.5.9
1.5.8
1.5.7
1.5.7.dev0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.22
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.26
1.3.25
1.3.24
1.3.23
1.3.22
1.3.21
1.3.20
1.3.19
1.3.18
1.3.17
1.3.16
1.3.15
1.3.14
1.3.13
1.3.12
1.3.11
1.3.10
1.3.9
1.3.8
1.3.7
1.3.6
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.18
1.2.17
1.2.16
1.2.15
1.2.14
1.2.13
1.2.12
1.2.11
1.2.10
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.3
1.0.2
1.0.1
1.0.0
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.7
0.0.6
0.0.5
0.0.4
0.0.3
0.0.2
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#566
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?