borg check fails with borgmatic and borg 1.1.2 #54

New Issue

Closed

opened 2018-01-14 09:45:12 +00:00 by henfri · 4 comments

henfri commented 2018-01-14 09:45:12 +00:00

Copy Link

Hello,

when running borg check, this command is run for me:

borg check borg@openmediavault:/borgbackup --repository-only --archives-only --last 3 --remote-path borg

I get this output:

--repository-only contradicts --first, --last, --prefix and --verify-data arguments.

And borgmatic exits with returncode 2.
This makes sense, as "--repository-only" makes repository level checks only, while "--last" is an archive-level filter.

I do not know, what is needed in terms of check, but the intention of this command (checking the repository and the archive) today must either be splitted into two commands, or the --repository-only part must be removed.

Hello, when running borg check, this command is run for me: > borg check borg@openmediavault:/borgbackup --repository-only --archives-only --last 3 --remote-path borg I get this output: > --repository-only contradicts --first, --last, --prefix and --verify-data arguments. And borgmatic exits with returncode 2. This makes sense, as "--repository-only" makes repository level checks only, while "--last" is an archive-level filter. I do not know, what is needed in terms of check, but the intention of this command (checking the repository and the archive) today must either be splitted into two commands, or the --repository-only part must be removed.

henfri commented 2018-01-14 10:01:13 +00:00

Author

Copy Link

Hello,

I checked the code:

return tuple(
    '--{}-only'.format(check) for check in checks
    if check in DEFAULT_CHECKS
) + last_flag

This architecture might need a change. I do not know if borg will support both --archive-only and --repository-only at the same time in future (does not make sense to me).

I see two options here:
a) no last_flag if 'archive' is also checked
b) run borg check twice once for the archive, once for the repository

Hello, I checked the code: return tuple( '--{}-only'.format(check) for check in checks if check in DEFAULT_CHECKS ) + last_flag This architecture might need a change. I do not know if borg will support both --archive-only and --repository-only at the same time in future (does not make sense to me). I see two options here: a) no last_flag if 'archive' is also checked b) run borg check twice once for the archive, once for the repository

witten commented 2018-01-14 21:39:58 +00:00

Owner

Copy Link

Yeah, you are correct in that the code as-is does not make sense. If both "archives" and "repository" are specified in borgmatic config, then neither --archive-only nor --repository-only should be passed to Borg. That's because Borg does both checks by default unless told otherwise. So this fix here is to omit the only flags in this case.

Yeah, you are correct in that the code as-is does not make sense. If both "archives" and "repository" are specified in borgmatic config, then neither `--archive-only` nor `--repository-only` should be passed to Borg. That's because Borg does both checks by default unless told otherwise. So this fix here is to omit the `only` flags in this case.

witten added the

bug

label 2018-01-14 22:08:43 +00:00

witten commented 2018-01-14 22:10:46 +00:00

Owner

Copy Link

I just pushed a fix for this in master. The problem only manifested when you specified all three checks in borgmatic config. The fix will go out in the next borgmatic release. Thanks for reporting it!

I just pushed a fix for this in master. The problem only manifested when you specified all three checks in borgmatic config. The fix will go out in the next borgmatic release. Thanks for reporting it!

witten closed this issue 2018-01-14 22:10:46 +00:00

witten commented 2018-01-15 00:40:15 +00:00

Owner

Copy Link

borgmatic 1.1.13 was just released with this fix.

borgmatic 1.1.13 was just released with this fix.

witten referenced this issue from a commit 2023-03-21 17:29:42 +00:00

Support file:// paths for repositories (#576).

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#54

No description provided.