borg check fails with borgmatic and borg 1.1.2 #54
Labels
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: borgmatic-collective/borgmatic#54
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hello,
when running borg check, this command is run for me:
I get this output:
And borgmatic exits with returncode 2.
This makes sense, as "--repository-only" makes repository level checks only, while "--last" is an archive-level filter.
I do not know, what is needed in terms of check, but the intention of this command (checking the repository and the archive) today must either be splitted into two commands, or the --repository-only part must be removed.
Hello,
I checked the code:
This architecture might need a change. I do not know if borg will support both --archive-only and --repository-only at the same time in future (does not make sense to me).
I see two options here:
a) no last_flag if 'archive' is also checked
b) run borg check twice once for the archive, once for the repository
Yeah, you are correct in that the code as-is does not make sense. If both "archives" and "repository" are specified in borgmatic config, then neither
--archive-only
nor--repository-only
should be passed to Borg. That's because Borg does both checks by default unless told otherwise. So this fix here is to omit theonly
flags in this case.I just pushed a fix for this in master. The problem only manifested when you specified all three checks in borgmatic config. The fix will go out in the next borgmatic release. Thanks for reporting it!
borgmatic 1.1.13 was just released with this fix.