generate-borgmatic-config with source file does not upgrade Healthchecks schema #536
Labels
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No Milestone
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: borgmatic-collective/borgmatic#536
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What I'm trying to do and why
I'm trying to upgrade a borgmatic 1.6.0 configuration file containing Healthchecks settings to borgmatic 1.6.1.
Steps to reproduce
generate-borgmatic-config -s 1.6.0.yaml -d 1.6.1.yaml
Actual behavior
The Healthchecks configuration in the generated file stays as the old-style scalar:
Expected behavior
I expect the configuration to get upgraded to the new-style object mapping with multiple options:
Other notes / implementation ideas
The problem is that the generation code doesn't call the normalize() function to "upgrade" the source configuration's schema.
Environment
borgmatic version: 1.6.1
borgmatic installation method:
pip install --editable
Borg version: 1.2.0
Python version: 3.10.4
operating system and version: Manjaro stable
Fixed in master.
This fix has been released in borgmatic 1.6.2!