generate-borgmatic-config with source file does not upgrade Healthchecks schema #536

New Issue

Closed

opened 2022-05-25 17:20:37 +00:00 by witten · 2 comments

witten commented 2022-05-25 17:20:37 +00:00

Owner

Copy Link

What I'm trying to do and why

I'm trying to upgrade a borgmatic 1.6.0 configuration file containing Healthchecks settings to borgmatic 1.6.1.

Steps to reproduce

generate-borgmatic-config -s 1.6.0.yaml -d 1.6.1.yaml

Actual behavior

The Healthchecks configuration in the generated file stays as the old-style scalar:

hooks:
    healthchecks: https://...

Expected behavior

I expect the configuration to get upgraded to the new-style object mapping with multiple options:

hooks:
    healthchecks:
        ping_url: https://...
        # send_logs: false
        ...

Other notes / implementation ideas

The problem is that the generation code doesn't call the normalize() function to "upgrade" the source configuration's schema.

Environment

borgmatic version: 1.6.1

borgmatic installation method: pip install --editable

Borg version: 1.2.0

Python version: 3.10.4

operating system and version: Manjaro stable

#### What I'm trying to do and why I'm trying to upgrade a borgmatic 1.6.0 configuration file containing Healthchecks settings to borgmatic 1.6.1. #### Steps to reproduce `generate-borgmatic-config -s 1.6.0.yaml -d 1.6.1.yaml` #### Actual behavior The Healthchecks configuration in the generated file stays as the old-style scalar: ``` hooks: healthchecks: https://... ``` #### Expected behavior I expect the configuration to get upgraded to the new-style object mapping with multiple options: ``` hooks: healthchecks: ping_url: https://... # send_logs: false ... ``` #### Other notes / implementation ideas The problem is that the generation code doesn't call the normalize() function to "upgrade" the source configuration's schema. #### Environment **borgmatic version:** 1.6.1 **borgmatic installation method:** `pip install --editable` **Borg version:** 1.2.0 **Python version:** 3.10.4 **operating system and version:** Manjaro stable

witten added the bug label 2022-05-25 17:20:43 +00:00

witten referenced this issue 2022-05-25 17:21:16 +00:00

Add option to Healthchecks hook to NOT include logs in payload data #460

witten referenced this issue from a commit 2022-05-25 17:26:54 +00:00

Fix generate-borgmatic-config with "--source" flag to support more complex schema changes like the new Healthchecks configuration options (#536).

witten commented 2022-05-25 17:27:08 +00:00

Author

Owner

Copy Link

Fixed in master.

Fixed in master.

witten closed this issue 2022-05-25 17:27:08 +00:00

witten commented 2022-05-31 16:44:29 +00:00

Author

Owner

Copy Link

This fix has been released in borgmatic 1.6.2!

This fix has been released in borgmatic 1.6.2!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

command-hook-steps

2.1.2

2.1.1

2.1.0

2.0.13

2.0.12

2.0.11

2.0.10

2.0.9

2.0.8

2.0.7

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.9.14

1.9.13

1.9.12

1.9.11

1.9.10

1.9.9

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels

blocked

breaking

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

No Label bug

Milestone

No items

No Milestone

Assignees

Clear assignees

witten

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#536