borgmatic restore does not pass options from mongodb hook #533

New Issue

Closed

opened 2022-05-13 23:28:01 +00:00 by errnesto · 5 comments

errnesto commented 2022-05-13 23:28:01 +00:00

Copy Link

What I'm trying to do and why

I want to backup and restore my mongodb database via borgmatic hooks

Steps to reproduce (if a bug)

The database needs the --ssl option set for the connection to work

Actual behavior (if a bug)

This works fine by setting the options via the config for creating the backup
But for borgmatic restore --archive latest I get:

Error running actions for repository
Command 'mongorestore --archive --drop --db mydb --host xxx --username xxx --password xxx --authenticationDatabase admin' returned non-zero exit status 1.
xxx.yaml: Error running configuration file

With error connecting to host: could not connect to server: server selection error in the description

Expected behavior (if a bug)

I think the reason for this is that the --ssl flag is missing on the mongorestore command and therefore it fails.

So the options should be added to the restore command as well

Environment

borgmatic version: [version here]

1.6.0

borgmatic installation method: [e.g., Debian package, Docker container, etc.]

pip

Borg version: [version here]

borg 1.1.16

Python version: [version here]

Python 3.10.4

Database version (if applicable): [version here]

mongodb 4.2

operating system and version: [OS here]

Debian bullseye

#### What I'm trying to do and why I want to backup and restore my mongodb database via borgmatic hooks #### Steps to reproduce (if a bug) The database needs the `--ssl` option set for the connection to work #### Actual behavior (if a bug) This works fine by setting the options via the config for creating the backup But for `borgmatic restore --archive latest` I get: ``` Error running actions for repository Command 'mongorestore --archive --drop --db mydb --host xxx --username xxx --password xxx --authenticationDatabase admin' returned non-zero exit status 1. xxx.yaml: Error running configuration file ``` With `error connecting to host: could not connect to server: server selection error` in the description #### Expected behavior (if a bug) I think the reason for this is that the --ssl flag is missing on the `mongorestore` command and therefore it fails. So the options should be added to the restore command as well #### Environment **borgmatic version:** [version here] 1.6.0 **borgmatic installation method:** [e.g., Debian package, Docker container, etc.] pip **Borg version:** [version here] borg 1.1.16 **Python version:** [version here] Python 3.10.4 **Database version (if applicable):** [version here] mongodb 4.2 **operating system and version:** [OS here] Debian bullseye

witten commented 2022-05-13 23:39:32 +00:00

Owner

Copy Link

Thank you for reporting this! It looks like this behavior is intentional—all the database hooks only pass the database options value to the dump and not the restore commands. I think the idea is that users often want to provide dump-only options.

Given that you're interested in passing the --ssl flag, which seems like a pretty common need, what do you think of borgmatic supporting a new ssl option (true or false) along with your other MongoDB database options? When true, that could plumb the --ssl flag to both dump and restore commands.

Thank you for reporting this! It looks like this behavior is intentional—all the database hooks only pass the database `options` value to the dump and not the restore commands. I think the idea is that users often want to provide dump-only options. Given that you're interested in passing the `--ssl` flag, which seems like a pretty common need, what do you think of borgmatic supporting a new `ssl` option (true or false) along with your other MongoDB database options? When true, that could plumb the `--ssl` flag to both dump and restore commands.

errnesto commented 2022-05-13 23:44:51 +00:00

Author

Copy Link

Hey thank you for the quick response.
Yes adding an ssl option would sound good to me.

Maybe this could also be solved with a mongodb connection string. But if so I could not figure this out yet…

Hey thank you for the quick response. Yes adding an ssl option would sound good to me. Maybe this could also be solved with a mongodb connection string. But if so I could not figure this out yet…

errnesto commented 2022-05-14 00:08:41 +00:00

Author

Copy Link

Maybe another idea would be to have restore_options that work the same as options but for the restore command? This way more complex (connection) setups would also be supported.

Maybe another idea would be to have `restore_options` that work the same as `options` but for the restore command? This way more complex (connection) setups would also be supported.

witten commented 2022-05-14 02:36:47 +00:00

Owner

Copy Link

Both of those approaches (ssl and restore_options) sound good to me! There is already precedent in some of the other database hooks for things like list_options.

Both of those approaches (`ssl` and `restore_options`) sound good to me! There is already precedent in some of the other database hooks for things like `list_options`.

witten added the

design finalized

label 2022-05-14 02:36:55 +00:00

witten commented 2023-02-04 17:36:35 +00:00

Owner

Copy Link

The MongoDB hook now has a restore_options configuration option in borgmatic 1.7.6. Enjoy!

The MongoDB hook now has a `restore_options` configuration option in borgmatic 1.7.6. Enjoy!

witten closed this issue 2023-02-04 17:36:35 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#533

No description provided.