Labels Milestones

New Issue

Exit code should be 0 if command succeeds after retry #517

Closed

opened 1 year ago by m3nu · 4 comments

m3nu commented 1 year ago

What I'm trying to do and why

The new retries and retry_wait settings are great to work around unstable connections.

Only issues is that Borgmatic still exits with code 1, as opposed to 0, even if the final retry succeeds.

Steps to reproduce (if a bug)

1. Add retries and retry_wait settings
2. Run some command that fails and later succeeds (by e.g. disconnecting from the internet for a few seconds)
3. Borgmatic returns with exit code 1 even if the command succeeded after a retry.

Expected behavior (if a bug)

The exit code should be 0 if any retry succeeds.

Other notes / implementation ideas

Environment

borgmatic version: 1.5.23

borgmatic installation method: PyPi

Borg version: 1.2.0

Python version: Python 3.9.2

operating system and version: Debian 11

#### What I'm trying to do and why The new `retries` and `retry_wait` settings are great to work around unstable connections. Only issues is that Borgmatic still exits with code `1`, as opposed to `0`, even if the final retry succeeds. #### Steps to reproduce (if a bug) 1. Add `retries` and `retry_wait` settings 2. Run some command that fails and later succeeds (by e.g. disconnecting from the internet for a few seconds) 3. Borgmatic returns with exit code `1` even if the command succeeded after a retry. #### Expected behavior (if a bug) The exit code should be `0` if any retry succeeds. #### Other notes / implementation ideas #### Environment **borgmatic version:** 1.5.23 **borgmatic installation method:** PyPi **Borg version:** 1.2.0 **Python version:** Python 3.9.2 **operating system and version:** Debian 11

witten commented 1 year ago

Owner

Confirmed this issue with a local repro! Thanks so much for reporting it.

Confirmed this issue with a local repro! Thanks so much for reporting it.

witten added the

bug

label 1 year ago

m3nu commented 1 year ago

Poster

Thanks for this feature. It's something I was missing. Already added it to the template on our setup page and will also add it to the Ansible role. 👍

Thanks for this feature. It's something I was missing. Already added it to the template on our setup page and will also add it to the Ansible role. 👍

witten referenced this issue from a commit 1 year ago

Fix borgmatic exit code (so it's zero) when initial Borg calls fail but later retries succeed (#517).

witten commented 1 year ago

Owner

The original retry feature was actually a PR (#432).

Anyway, I just pushed a fix for this to master, which will be part of the next release. Thanks again for pointing out this issue!

The original retry feature was actually a PR (#432). Anyway, I just pushed a fix for this to master, which will be part of the next release. Thanks again for pointing out this issue!

👍 1

witten closed this issue 1 year ago

witten commented 1 year ago

Owner

Released in borgmatic 1.6.0!

Released in borgmatic 1.6.0!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

check-instrumentation

0.0.2

0.0.3

0.0.4

0.0.5

0.0.6

0.0.7

0.1.0

0.1.1

0.1.2

0.1.3

0.1.4

0.1.5

0.1.6

0.1.7

0.1.8

1.0.0

1.0.1

1.0.2

1.0.3

1.1.0

1.1.1

1.1.10

1.1.11

1.1.12

1.1.13

1.1.14

1.1.15

1.1.2

1.1.3

1.1.4

1.1.5

1.1.6

1.1.7

1.1.9

1.2.0

1.2.1

1.2.10

1.2.11

1.2.12

1.2.13

1.2.14

1.2.15

1.2.16

1.2.17

1.2.18

1.2.2

1.2.3

1.2.4

1.2.5

1.2.6

1.2.7

1.2.8

1.2.9

1.3.0

1.3.1

1.3.10

1.3.11

1.3.12

1.3.13

1.3.14

1.3.15

1.3.16

1.3.17

1.3.18

1.3.19

1.3.2

1.3.20

1.3.21

1.3.22

1.3.23

1.3.24

1.3.25

1.3.26

1.3.3

1.3.4

1.3.5

1.3.6

1.3.7

1.3.8

1.3.9

1.4.0

1.4.1

1.4.10

1.4.11

1.4.12

1.4.13

1.4.14

1.4.15

1.4.16

1.4.17

1.4.18

1.4.19

1.4.2

1.4.20

1.4.21

1.4.22

1.4.3

1.4.4

1.4.5

1.4.6

1.4.7

1.4.8

1.4.9

1.5.0

1.5.1

1.5.10

1.5.11

1.5.12

1.5.13

1.5.14

1.5.15

1.5.16

1.5.17

1.5.18

1.5.19

1.5.2

1.5.20

1.5.21

1.5.22

1.5.23

1.5.24

1.5.3

1.5.4

1.5.5

1.5.6

1.5.7

1.5.7.dev0

1.5.8

1.5.9

1.6.0

1.6.1

1.6.2

1.6.3

1.6.4

1.6.5

1.6.6

1.7.0

1.7.1

1.7.10

1.7.11

1.7.12

1.7.13

1.7.2

1.7.3

1.7.4

1.7.5

1.7.6

1.7.7

1.7.8

1.7.9

Labels

Apply labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

question / support

security

waiting for response

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#517

Write Preview

Loading…

Cancel

Save

There is no content yet.