Exit code should be 0 if command succeeds after retry #517
Labels
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: borgmatic-collective/borgmatic#517
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What I'm trying to do and why
The new
retries
andretry_wait
settings are great to work around unstable connections.Only issues is that Borgmatic still exits with code
1
, as opposed to0
, even if the final retry succeeds.Steps to reproduce (if a bug)
retries
andretry_wait
settings1
even if the command succeeded after a retry.Expected behavior (if a bug)
The exit code should be
0
if any retry succeeds.Other notes / implementation ideas
Environment
borgmatic version: 1.5.23
borgmatic installation method: PyPi
Borg version: 1.2.0
Python version: Python 3.9.2
operating system and version: Debian 11
Confirmed this issue with a local repro! Thanks so much for reporting it.
Thanks for this feature. It's something I was missing. Already added it to the template on our setup page and will also add it to the Ansible role. 👍
The original retry feature was actually a PR (#432).
Anyway, I just pushed a fix for this to master, which will be part of the next release. Thanks again for pointing out this issue!
Released in borgmatic 1.6.0!