SIGTERM is not terminating borgmatic #516

New Issue

Closed

opened 2022-03-31 15:37:12 +00:00 by NED567 · 3 comments

NED567 commented 2022-03-31 15:37:12 +00:00

Copy Link

What I'm trying to do and why

I am using borgmatic on debian/testing. There borgmatic is started by a systemd timer and service. Stopping or restarting the service while borgmatic is creating an archive doesn't work.

Steps to reproduce (if a bug)

• Create multiple configuration files in /etc/borgmatic.d/
  (it looks like it can also be 1 configuration file with multiple repositories)
• Start /usr/bin/borgmatic --verbosity 1
• While borgmatic is working (prune/create/...) on the first repository, stop it from an other terminal with pkill --signal TERM borgmatic.

Actual behavior (if a bug)

The work on the first repository is stopped, but borgmatic continues on the next repository.

Expected behavior (if a bug)

borgmatic should stop the current running action (of borg) and then terminate.

Other notes / implementation ideas

The signal SIGTERM indicates for a process that it needs to be stopped. The process is allowed to clean up it's environment (release locks) but then should stop as soon as possible. It should not start new long lasting actions.

It looks like the method _handle_signal only propagates the SIGTERM to the subprocesses, but the current process (borgmatic) can just continue (with the next repository). This is not correct. Borgmatic should stop as well.

Environment

borgmatic version: [1.5.20]

borgmatic installation method: [Debian package]

Borg version: [borg 1.2.0]

Python version: [Python 3.9.12]

Database version (if applicable): [N/A]

operating system and version: [debian testing]

#### What I'm trying to do and why I am using borgmatic on debian/testing. There borgmatic is started by a systemd timer and service. Stopping or restarting the service while borgmatic is creating an archive doesn't work. #### Steps to reproduce (if a bug) * Create multiple configuration files in /etc/borgmatic.d/ (it looks like it can also be 1 configuration file with multiple repositories) * Start `/usr/bin/borgmatic --verbosity 1` * While borgmatic is working (prune/create/...) on the first repository, stop it from an other terminal with `pkill --signal TERM borgmatic`. #### Actual behavior (if a bug) The work on the first repository is stopped, but borgmatic continues on the next repository. #### Expected behavior (if a bug) borgmatic should stop the current running action (of borg) and then terminate. #### Other notes / implementation ideas The signal SIGTERM indicates for a process that it needs to be stopped. The process is allowed to clean up it's environment (release locks) but then should stop as soon as possible. It should not start new long lasting actions. It looks like the method `_handle_signal` only propagates the SIGTERM to the subprocesses, but the current process (borgmatic) can just continue (with the next repository). This is not correct. Borgmatic should stop as well. #### Environment **borgmatic version:** [1.5.20] **borgmatic installation method:** [Debian package] **Borg version:** [borg 1.2.0] **Python version:** [Python 3.9.12] **Database version (if applicable):** [N/A] **operating system and version:** [debian testing]

witten commented 2022-04-01 03:47:52 +00:00

Owner

Copy Link

Good catch! Looks like it's indeed a bug based on the code, although I haven't yet verified with a local repro. Thank you for filing this.

EDIT: Got a local repro now.

Good catch! Looks like it's indeed a bug based on the code, although I haven't yet verified with a local repro. Thank you for filing this. EDIT: Got a local repro now.

witten added the

bug

label 2022-04-01 03:47:59 +00:00

witten referenced this issue from a commit 2022-04-03 20:13:02 +00:00

Fix handling of TERM signal to exit borgmatic, not just forward the signal to Borg (#516).

witten commented 2022-04-03 20:13:32 +00:00

Owner

Copy Link

This has been fixed in master! It'll be part of the next release. Thanks again.

This has been fixed in master! It'll be part of the next release. Thanks again.

witten closed this issue 2022-04-03 20:13:32 +00:00

witten commented 2022-04-26 17:09:30 +00:00

Owner

Copy Link

Released in borgmatic 1.6.0!

Released in borgmatic 1.6.0!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#516

No description provided.