borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
15
57
Fork 40
Code Issues 53 Pull Requests 1 Actions Packages Releases 121 Activity

Option to disable syslog output #484

New Issue
Closed
opened 2021-12-30 22:02:17 +00:00 by Alexander-Shukaev · 4 comments
Alexander-Shukaev commented 2021-12-30 22:02:17 +00:00
Copy Link

What I'm trying to do and why

Running borgmatic as a systemd service.

Steps to reproduce (if a bug)

Run borgmatic as a systemd service with --verbosity 1 --monitoring-verbosity 1 --syslog-verbosity -1 options.

Actual behavior (if a bug)

borgmatic.service[574202]: ...: Error running pre hook
borgmatic[574202]: CRITICAL ...: Error running pre hook
borgmatic.service[574202]: Command '...' returned non-zero exit status 1.
borgmatic[574202]: CRITICAL Command '...' returned non-zero exit status 1.
borgmatic.service[574202]: ...: Running command for on-error hook
borgmatic.service[574202]: All given configuration files are valid: ...
borgmatic[574202]: ERROR All given configuration files are valid: ...

Notice how borgmatic duplicates most of the error-related output into the syslog even though the service has already done it.

Expected behavior (if a bug)

syslog-verbosity -1 should disable any explicit syslog output from borgmatic as it's redundant under systemd use case or any other similar one, where logging is done in a different manner.

Environment

borgmatic version: 1.5.21

Borg version: 1.1.17

Python version: 3.10.1

#### What I'm trying to do and why Running `borgmatic` as a `systemd` service. #### Steps to reproduce (if a bug) Run `borgmatic` as a `systemd` service with `--verbosity 1 --monitoring-verbosity 1 --syslog-verbosity -1` options. #### Actual behavior (if a bug) ``` borgmatic.service[574202]: ...: Error running pre hook borgmatic[574202]: CRITICAL ...: Error running pre hook borgmatic.service[574202]: Command '...' returned non-zero exit status 1. borgmatic[574202]: CRITICAL Command '...' returned non-zero exit status 1. borgmatic.service[574202]: ...: Running command for on-error hook borgmatic.service[574202]: All given configuration files are valid: ... borgmatic[574202]: ERROR All given configuration files are valid: ... ``` Notice how `borgmatic` duplicates most of the error-related output into the `syslog` even though the service has already done it. #### Expected behavior (if a bug) `syslog-verbosity -1` should disable any explicit `syslog` output from `borgmatic` as it's redundant under `systemd` use case or any other similar one, where logging is done in a different manner. #### Environment **borgmatic version:** 1.5.21 **Borg version:** 1.1.17 **Python version:** 3.10.1
witten commented 2022-04-24 03:08:00 +00:00
Owner
Copy Link

Thanks for filing this! I think to make this work, I'd have to introduce another verbosity level even lower than -1 (such as -2, disabled, etc.). That's because the existing -1 verbosity level is errors only, and it would probably be good to keep that available.

Thanks for filing this! I think to make this work, I'd have to introduce another verbosity level even lower than `-1` (such as `-2`, `disabled`, etc.). That's because the existing `-1` verbosity level is errors only, and it would probably be good to keep that available.
witten added the
good first issue
 label 2023-02-04 17:41:20 +00:00
witten commented 2023-03-28 23:45:50 +00:00
Owner
Copy Link

Adding a note for anyone who picks up this ticket: It would probably be a good idea to alter the sample systemd service with whatever solution is employed here. (--syslog-verbosity -2, --syslog-verbosity disabled, etc.).

Adding a note for anyone who picks up this ticket: It would probably be a good idea to alter the sample systemd service with whatever solution is employed here. (`--syslog-verbosity -2`, `--syslog-verbosity disabled`, etc.).
witten commented 2023-05-30 22:54:04 +00:00
Owner
Copy Link

@Soumik_Dutta has implemented this in main as a new verbosity level of -2. It will be available in the next release!

@Soumik_Dutta has implemented this in main as a new verbosity level of `-2`. It will be available in the next release!
🎉 1
witten commented 2023-06-04 05:29:06 +00:00
Owner
Copy Link

Just released as part of borgmatic 1.7.14!

Just released as part of borgmatic 1.7.14!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
spot-check
1.8.10
1.8.9
1.8.8
1.8.7
1.8.6
1.8.5
1.8.4
1.8.3
1.8.2
1.8.1
1.8.0
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.5.24
1.5.23
1.5.22
1.5.21
1.5.20
1.5.19
1.5.18
1.5.17
1.5.16
1.5.15
1.5.14
1.5.13
1.5.12
1.5.11
1.5.10
1.5.9
1.5.8
1.5.7
1.5.7.dev0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.22
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.26
1.3.25
1.3.24
1.3.23
1.3.22
1.3.21
1.3.20
1.3.19
1.3.18
1.3.17
1.3.16
1.3.15
1.3.14
1.3.13
1.3.12
1.3.11
1.3.10
1.3.9
1.3.8
1.3.7
1.3.6
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.18
1.2.17
1.2.16
1.2.15
1.2.14
1.2.13
1.2.12
1.2.11
1.2.10
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.3
1.0.2
1.0.1
1.0.0
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.7
0.0.6
0.0.5
0.0.4
0.0.3
0.0.2
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#484
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?