Explicitly disabled one_file_system and read_special options are seen as true #408

New Issue

Closed

opened 2021-04-03 12:38:59 +00:00 by Bubbelb · 3 comments

Bubbelb commented 2021-04-03 12:38:59 +00:00

Copy Link

What I'm trying to do and why

I have a backup config, that explicityly states that options one_file_system and read_special should be false, since I want no special files and I want to have the BTRFS subvolumes included.

Steps to reproduce (if a bug)

location:
  source_directories:
    - /mnt/hdd/@userdata
    - /mnt/hdd/@archive
  repositories:
    - /mnt/backup/borg-local/userdata
  one_file_system: false
  read_special: false 
  exclude_caches: true
  exclude_if_present:
    - .nobackup

storage:
  compression: zstd,11
  lock_wait: 5
  archive_name_format: 'userdata-{now:%Y-%m-%dT%H:%M:%S}'

retention:
  keep_within: 72H   
  # keep_secondly: 60
  # keep_minutely: 60
  keep_hourly: 336
  keep_daily: 14  
  keep_weekly: 4 
  keep_monthly: 0    
  keep_yearly: 0  
  prefix: userdata
                    
consistency:
  checks:
    - repository    
    - archives   
  check_last: 5
  prefix: userdata

hooks:
  mysql_databases:
    - name: all
    ...
    ...

Include (sanitized) borgmatic configuration files if applicable.

Actual behavior (if a bug)

ps -aux shows the following command line for borg:

usr/bin/python 
/usr/bin/borg create
   --exclude-caches
   --exclude-if-present .nobackup
   --compression zstd,11
   --one-file-system
   --read-special
   --lock-wait 5
   --info /mnt/backup/borg-local/userdata::userdata-{now:%Y-%m-%dT%H:%M:%S} 
   /mnt/btrfs-hdd/@archive/...

Of course, this output had some tidying for readability...

Expected behavior (if a bug)

both options should not be added to the borg command line.

Other notes / implementation ideas

Environment

borgmatic version: 1.5.12

borgmatic installation method: Archlinux pacman

Borg version: 1.1.15

Python version: 3.9.2

Database version (if applicable): n/a

operating system and version: Archlinux

#### What I'm trying to do and why I have a backup config, that explicityly states that options one_file_system and read_special should be false, since I want no special files and I want to have the BTRFS subvolumes included. #### Steps to reproduce (if a bug) ``` location: source_directories: - /mnt/hdd/@userdata - /mnt/hdd/@archive repositories: - /mnt/backup/borg-local/userdata one_file_system: false read_special: false exclude_caches: true exclude_if_present: - .nobackup storage: compression: zstd,11 lock_wait: 5 archive_name_format: 'userdata-{now:%Y-%m-%dT%H:%M:%S}' retention: keep_within: 72H # keep_secondly: 60 # keep_minutely: 60 keep_hourly: 336 keep_daily: 14 keep_weekly: 4 keep_monthly: 0 keep_yearly: 0 prefix: userdata consistency: checks: - repository - archives check_last: 5 prefix: userdata hooks: mysql_databases: - name: all ... ... ``` Include (sanitized) borgmatic configuration files if applicable. #### Actual behavior (if a bug) ps -aux shows the following command line for borg: ``` usr/bin/python /usr/bin/borg create --exclude-caches --exclude-if-present .nobackup --compression zstd,11 --one-file-system --read-special --lock-wait 5 --info /mnt/backup/borg-local/userdata::userdata-{now:%Y-%m-%dT%H:%M:%S} /mnt/btrfs-hdd/@archive/... ``` Of course, this output had some tidying for readability... #### Expected behavior (if a bug) both options should not be added to the borg command line. #### Other notes / implementation ideas #### Environment **borgmatic version:** 1.5.12 **borgmatic installation method:** Archlinux pacman **Borg version:** 1.1.15 **Python version:** 3.9.2 **Database version (if applicable):** n/a **operating system and version:** Archlinux

Bubbelb commented 2021-04-03 14:16:25 +00:00

Author

Copy Link

Duh. Did an update to the latest version (didn't realize i wasn't using the latest one) and all works well again...

Duh. Did an update to the latest version (didn't realize i wasn't using the latest one) and all works well again...

Bubbelb closed this issue 2021-04-03 14:16:25 +00:00

Bubbelb commented 2021-04-03 15:23:57 +00:00

Author

Copy Link

...Was the MySQL hook...

...Was the MySQL hook...

witten commented 2021-04-03 15:50:12 +00:00

Owner

Copy Link

Glad you've got it figured out! Yeah, the database hooks turn on those options so that it can stream the database dump directly to Borg.

Glad you've got it figured out! Yeah, the database hooks turn on those options so that it can stream the database dump directly to Borg.

witten added the

question / support

label 2021-04-03 15:50:20 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#408

No description provided.