Labels Milestones

New Issue

Support ruamel.yaml 0.17.x #404

Closed

opened 1 year ago by witten · 4 comments

witten commented 1 year ago

Owner

What I'm trying to do and why

borgmatic supports ruamel.yaml up to but not including 0.17.0 as a result of this in setup.py:

    install_requires=(
        ...
        'ruamel.yaml>0.15.0,<0.17.0',
        ...
    ),

However ruamel.yaml version 0.17.0 came out recently, and it would be good for borgmatic to support it.

So as part of this ticket, update the version range in setup.py, update test requirements as well, and confirm that borgmatic still works (and tests pass) with 0.17.0. Read through the ruamel.yaml changelog and make sure there no surprises.

Other notes / implementation ideas

Downstream issue on this: https://bugs.archlinux.org/task/70197

Environment

borgmatic version: master

#### What I'm trying to do and why borgmatic supports `ruamel.yaml` up to but not including `0.17.0` as a result of this in `setup.py`: ```python install_requires=( ... 'ruamel.yaml>0.15.0,<0.17.0', ... ), ``` However `ruamel.yaml` version `0.17.0` came out recently, and it would be good for borgmatic to support it. So as part of this ticket, update the version range in `setup.py`, update test requirements as well, and confirm that borgmatic still works (and tests pass) with `0.17.0`. Read through the `ruamel.yaml` changelog and make sure there no surprises. #### Other notes / implementation ideas Downstream issue on this: https://bugs.archlinux.org/task/70197 #### Environment **borgmatic version:** master

👍 1

csteinforth commented 1 year ago

Hi there,

had exactly this issue today. I solved this by downgrading the package python-ruamel-yaml to 0.16.13.

Regards,

Christoph

Hi there, had exactly this issue today. I solved this by downgrading the package `python-ruamel-yaml` to 0.16.13. Regards, Christoph

PopeRigby commented 1 year ago

Also having this issue on Arch Linux.

Also having this issue on Arch Linux.

witten commented 1 year ago

Poster

Owner

Thanks for your patience here. I've just tested with ruamel.yaml 0.17.x and released borgmatic 1.5.13 with support for it!

Thanks for your patience here. I've just tested with ruamel.yaml 0.17.x and released borgmatic 1.5.13 with support for it!

👍 3 🎉 1

witten closed this issue 1 year ago

witten referenced this issue from a commit 1 year ago

Add support for ruamel.yaml 0.17.x YAML parsing library (#404).

csteinforth commented 1 year ago

New version of borgmatic just hit the arch repos. Thanks for your quick solution on this!

New version of `borgmatic` just hit the arch repos. Thanks for your quick solution on this!

👍 1

witten referenced this issue 1 year ago

python errors? #410

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

end-to-end-database-tests

master

stream-database-dumps

0.0.2

0.0.3

0.0.4

0.0.5

0.0.6

0.0.7

0.1.0

0.1.1

0.1.2

0.1.3

0.1.4

0.1.5

0.1.6

0.1.7

0.1.8

1.0.0

1.0.1

1.0.2

1.0.3

1.1.0

1.1.1

1.1.10

1.1.11

1.1.12

1.1.13

1.1.14

1.1.15

1.1.2

1.1.3

1.1.4

1.1.5

1.1.6

1.1.7

1.1.9

1.2.0

1.2.1

1.2.10

1.2.11

1.2.12

1.2.13

1.2.14

1.2.15

1.2.16

1.2.17

1.2.18

1.2.2

1.2.3

1.2.4

1.2.5

1.2.6

1.2.7

1.2.8

1.2.9

1.3.0

1.3.1

1.3.10

1.3.11

1.3.12

1.3.13

1.3.14

1.3.15

1.3.16

1.3.17

1.3.18

1.3.19

1.3.2

1.3.20

1.3.21

1.3.22

1.3.23

1.3.24

1.3.25

1.3.26

1.3.3

1.3.4

1.3.5

1.3.6

1.3.7

1.3.8

1.3.9

1.4.0

1.4.1

1.4.10

1.4.11

1.4.12

1.4.13

1.4.14

1.4.15

1.4.16

1.4.17

1.4.18

1.4.19

1.4.2

1.4.20

1.4.21

1.4.22

1.4.3

1.4.4

1.4.5

1.4.6

1.4.7

1.4.8

1.4.9

1.5.0

1.5.1

1.5.10

1.5.11

1.5.12

1.5.13

1.5.14

1.5.15

1.5.16

1.5.17

1.5.18

1.5.19

1.5.2

1.5.20

1.5.21

1.5.22

1.5.23

1.5.24

1.5.3

1.5.4

1.5.5

1.5.6

1.5.7

1.5.7.dev0

1.5.8

1.5.9

1.6.0

1.6.1

1.6.2

1.6.3

1.6.4

1.6.5

Labels

Apply labels

Clear labels

bug data loss design finalized question / support security waiting for response

No Label bug data loss design finalized question / support security waiting for response

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.