Feature request: support the BORG_REPO environment variable #391

New Issue

Closed

opened 2021-02-18 14:25:12 +00:00 by soyuka · 2 comments

soyuka commented 2021-02-18 14:25:12 +00:00

Copy Link

What I'm trying to do and why

My configuration files are meant to be open and public. This is why I tend to remove every private information from these files using environment variables. Currently, the Borgmatic configuration file has one last public information: repositories.

I see that https://projects.torsion.org/witten/borgmatic/src/branch/master/borgmatic/borg/environment.py#L3-L12 supports SSH custom command and the BORG_PASSPHRASE variable which I uses.

Would you accept a patch adding the BORG_REPO variable?

Environment

borgmatic version: 1.5.12

borgmatic installation method: AUR

Borg version: 1.1.14

operating system and version: Archlinux

Sidenote: Is there a way to specify ssh commands per repository?

#### What I'm trying to do and why My configuration files are meant to be open and public. This is why I tend to remove every private information from these files using environment variables. Currently, the Borgmatic configuration file has one last public information: repositories. I see that https://projects.torsion.org/witten/borgmatic/src/branch/master/borgmatic/borg/environment.py#L3-L12 supports SSH custom command and the BORG_PASSPHRASE variable which I uses. Would you accept a patch adding the `BORG_REPO` variable? #### Environment **borgmatic version:** 1.5.12 **borgmatic installation method:** AUR **Borg version:** 1.1.14 **operating system and version:** Archlinux Sidenote: Is there a way to specify ssh commands per repository?

witten commented 2022-04-24 03:27:57 +00:00

Owner

Copy Link

Sorry for the lengthy delay here, and thanks for filing this ticket. I'm not sure it makes sense to add BORG_REPO though for a couple of reasons:

1. It would be a little inconsistent to support passing in a repository as an environment variable and not all of the other configuration options in the borgmatic configuration file. But what about all the other supported environment variables such as the ones you linked, you might ask? Those are all environment variables that Borg itself expects to receive, and so borgmatic supports them for Borg compatibility. But borgmatic doesn't currently support any non-Borg-specific environment variables.
2. repositories is a list! So it'd probably have to be BORG_REPOS and somehow encode a sequence of repositories. This is one reason that borgmatic uses a YAML configuration file with a variety of complex types; it would be difficult (although not impossible) to stuff everything into environment variables.

Having said all that, I do recognize your ask and the underlying need there. So how about this: Have you considered borgmatic's command-line configuration option override support? This would allow you to override the configured repositories whenever you invoke borgmatic on the command-line.

Sidenote: Is there a way to specify ssh commands per repository?

The only way to do that currently would be to create separate borgmatic configuration files, one per repository. Then you could use independent options like ssh_command for each repository.

Sorry for the lengthy delay here, and thanks for filing this ticket. I'm not sure it makes sense to add `BORG_REPO` though for a couple of reasons: 1. It would be a little inconsistent to support passing in a repository as an environment variable and not all of the other configuration options in the borgmatic configuration file. But what about all the other supported environment variables such as the ones you linked, you might ask? Those are all environment variables that Borg itself expects to receive, and so borgmatic supports them for Borg compatibility. But borgmatic doesn't currently support any non-Borg-specific environment variables. 2. `repositories` is a list! So it'd probably have to be BORG_REPOS and somehow encode a sequence of repositories. This is one reason that borgmatic uses a YAML configuration file with a variety of complex types; it would be difficult (although not impossible) to stuff everything into environment variables. Having said all that, I do recognize your ask and the underlying need there. So how about this: Have you considered borgmatic's [command-line configuration option override support](https://torsion.org/borgmatic/docs/how-to/make-per-application-backups/#configuration-overrides)? This would allow you to override the configured repositories whenever you invoke borgmatic on the command-line. > Sidenote: Is there a way to specify ssh commands per repository? The only way to do that currently would be to create [separate borgmatic configuration files](https://torsion.org/borgmatic/docs/how-to/make-per-application-backups/), one per repository. Then you could use independent options like `ssh_command` for each repository.

witten commented 2022-05-29 05:57:06 +00:00

Owner

Copy Link

I'm closing this due to inactivity, but please feel free to post any follow-ups here. Thanks!

I'm closing this due to inactivity, but please feel free to post any follow-ups here. Thanks!

witten closed this issue 2022-05-29 05:57:06 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#391

No description provided.