borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
15
56
Fork 39
Code Issues 52 Pull Requests 1 Actions Packages Releases 121 Activity

Optionally pass through PostgreSQL environment variables in database hook #370

New Issue
Closed
opened 2020-11-18 18:53:42 +00:00 by witten · 4 comments
witten commented 2020-11-18 18:53:42 +00:00
Owner
Copy Link

Reported by hugokernel on IRC.

What I'm trying to do and why

Backup a database with borgmatic via the PostgreSQL database hook, passing through some of the credentials or connection information via PG* environment variables so that I don't have to specify them in borgmatic's configuration file.

Perhaps I'm using Docker and environment variables are more convenient for this purpose. Perhaps I already have them in the environment for some other usage. Perhaps I have several databases with the same settings or credentials, and I don't want to have to repeat the configuration for each one in borgmatic's database hook.

Other notes / implementation ideas

Any existing PG* environment variables are not passed through from borgmatic to PostgreSQL today because PGSSLMODE is set unconditionally in the new environment that borgmatic passes to PostgreSQL: https://projects.torsion.org/witten/borgmatic/src/branch/master/borgmatic/hooks/postgresql.py#L25

Adding a conditional around that line would make the environment empty, which would pass env=None to the PostgreSQL call, which would in effect default to borgmatic's own environment.

Reported by `hugokernel` on IRC. #### What I'm trying to do and why Backup a database with borgmatic via the PostgreSQL database hook, passing through some of the credentials or connection information via `PG*` environment variables so that I don't have to specify them in borgmatic's configuration file. Perhaps I'm using Docker and environment variables are more convenient for this purpose. Perhaps I already have them in the environment for some other usage. Perhaps I have several databases with the same settings or credentials, and I don't want to have to repeat the configuration for each one in borgmatic's database hook. #### Other notes / implementation ideas Any existing `PG*` environment variables are not passed through from borgmatic to PostgreSQL today because `PGSSLMODE` is set unconditionally in the new environment that borgmatic passes to PostgreSQL: https://projects.torsion.org/witten/borgmatic/src/branch/master/borgmatic/hooks/postgresql.py#L25 Adding a conditional around that line would make the environment empty, which would pass `env=None` to the PostgreSQL call, which would in effect default to borgmatic's own environment.
👍 1
witten commented 2022-06-14 17:47:51 +00:00
Author
Owner
Copy Link

Some relevant discussion with a related proposal on #546.

Some relevant discussion with a related proposal on #546.
witten commented 2022-06-16 23:26:20 +00:00
Author
Owner
Copy Link

There's a new feature implemented as part of #546 for environment variable interpolation, very related to this ticket although not exactly the same. See the documentation at https://torsion.org/borgmatic/docs/how-to/provide-your-passwords/

There's a new feature implemented as part of #546 for environment variable interpolation, very related to this ticket although not exactly the same. See the documentation at https://torsion.org/borgmatic/docs/how-to/provide-your-passwords/
witten added the
good first issue
 label 2023-02-04 21:26:22 +00:00
witten commented 2024-01-25 22:18:58 +00:00
Author
Owner
Copy Link

Well this took an embarrassingly long time to implement. Fixed in main.

Well this took an embarrassingly long time to implement. Fixed in main.
witten commented 2024-01-31 18:56:08 +00:00
Author
Owner
Copy Link

Released in borgmatic 1.8.8!

Released in borgmatic 1.8.8!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
spot-check
1.8.10
1.8.9
1.8.8
1.8.7
1.8.6
1.8.5
1.8.4
1.8.3
1.8.2
1.8.1
1.8.0
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.5.24
1.5.23
1.5.22
1.5.21
1.5.20
1.5.19
1.5.18
1.5.17
1.5.16
1.5.15
1.5.14
1.5.13
1.5.12
1.5.11
1.5.10
1.5.9
1.5.8
1.5.7
1.5.7.dev0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.22
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.26
1.3.25
1.3.24
1.3.23
1.3.22
1.3.21
1.3.20
1.3.19
1.3.18
1.3.17
1.3.16
1.3.15
1.3.14
1.3.13
1.3.12
1.3.11
1.3.10
1.3.9
1.3.8
1.3.7
1.3.6
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.18
1.2.17
1.2.16
1.2.15
1.2.14
1.2.13
1.2.12
1.2.11
1.2.10
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.3
1.0.2
1.0.1
1.0.0
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.7
0.0.6
0.0.5
0.0.4
0.0.3
0.0.2
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#370
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?