Support break-lock? #357

New Issue

Closed

opened 2020-08-26 19:00:55 +00:00 by harriv · 5 comments

harriv commented 2020-08-26 19:00:55 +00:00

Copy Link

What I'm trying to do and why

I'm backing up over SSH (very long backup). If the backup interrupts (connection broken, computer turned off) mid-backup, continuing backup seems to require "borg break-lock" command. It would be nice if borgmatic either automatically handles this situation, or supports the command so I don't have to manually re-enter the repository path and credentials..

#### What I'm trying to do and why I'm backing up over SSH (very long backup). If the backup interrupts (connection broken, computer turned off) mid-backup, continuing backup seems to require "borg break-lock" command. It would be nice if borgmatic either automatically handles this situation, or supports the command so I don't have to manually re-enter the repository path and credentials..

witten commented 2020-08-26 19:37:38 +00:00

Owner

Copy Link

A borgmatic break-lock action that wraps Borg's own break-lock sounds handy, and makes sense to me. And it appears that break-lock succeeds silently if there's no lock in place. So it should be totally fine for borgmatic to loop over all configured repositories, breaking each one's lock in turn.

Thank you for filing this idea!

A `borgmatic break-lock` action that wraps Borg's own `break-lock` sounds handy, and makes sense to me. And it appears that `break-lock` succeeds silently if there's no lock in place. So it should be totally fine for borgmatic to loop over all configured repositories, breaking each one's lock in turn. Thank you for filing this idea!

harriv commented 2020-08-27 06:35:43 +00:00

Author

Copy Link

I'm not so much into borg internals, but the documentation asks to be careful so I'm not sure how safe this is to do automaticalla: https://borgbackup.readthedocs.io/en/stable/usage/lock.html#borg-break-lock

I'm not so much into borg internals, but the documentation asks to be careful so I'm not sure how safe this is to do automaticalla: https://borgbackup.readthedocs.io/en/stable/usage/lock.html#borg-break-lock

witten commented 2020-08-27 16:24:34 +00:00

Owner

Copy Link

Yeah, you shouldn't run break-lock if the lock is legitimately there because Borg is running! For that reason, I could see making borgmatic break-lock take an optional --repository parameter.

Yeah, you shouldn't run `break-lock` if the lock is legitimately there because Borg is running! For that reason, I could see making `borgmatic break-lock` take an optional `--repository` parameter.

witten referenced this issue from a commit 2022-10-04 20:42:45 +00:00

Add "break-lock" action for removing any repository and cache locks leftover from Borg aborting (#357).

witten commented 2022-10-04 20:43:57 +00:00

Owner

Copy Link

A little late, but this is implemented now in master! Should be part of the next release.

A little late, but this is implemented now in master! Should be part of the next release.

witten closed this issue 2022-10-04 20:43:57 +00:00

witten referenced this issue from a commit 2022-10-12 17:48:53 +00:00

Add missing break-lock action command-line help (#357).

witten commented 2022-10-12 18:03:26 +00:00

Owner

Copy Link

Just released in borgmatic 1.7.3!

Just released in borgmatic 1.7.3!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#357

No description provided.