Borgbmatic errors out when system-wide configuration dir is not readable #350

New Issue

Closed

opened 2020-08-08 08:51:47 +00:00 by apollo13 · 4 comments

apollo13 commented 2020-08-08 08:51:47 +00:00

Copy Link

What I'm trying to do and why

I am trying to create a backup :)

Steps to reproduce (if a bug)

Put any config into ~/.config/borgmatic/...

Actual behavior (if a bug)

Run as non-root user and get greated by:

Traceback (most recent call last):
  File "/usr/bin/borgmatic", line 11, in <module>
    load_entry_point('borgmatic==1.5.9', 'console_scripts', 'borgmatic')()
  File "/usr/lib/python3.8/site-packages/borgmatic/commands/borgmatic.py", line 743, in main
    config_filenames = tuple(collect.collect_config_filenames(global_arguments.config_paths))
  File "/usr/lib/python3.8/site-packages/borgmatic/config/collect.py", line 47, in collect_config_filenames
    for filename in sorted(os.listdir(path)):
PermissionError: [Errno 13] Permission denied: '/etc/borgmatic.d'

Expected behavior (if a bug)

When run as normal user, borgmatic should skip non-readable folders. System wide configuration files are often for root, especially since the config file can contain sensitive data (especially the passphrase). So Fedora chose to package the configuration directory with restrictive permissions.

Other notes / implementation ideas

Either completly skip non-readable directories or issue a warning instead of a hard error

Environment

borgmatic version: 1.5.9

borgmatic installation method: Fedora

Borg version: 1.1.13

Python version: 3.8.5

operating system and version: Fedora 32

#### What I'm trying to do and why I am trying to create a backup :) #### Steps to reproduce (if a bug) Put *any* config into *~/.config/borgmatic/...* #### Actual behavior (if a bug) Run as non-root user and get greated by: ``` Traceback (most recent call last): File "/usr/bin/borgmatic", line 11, in <module> load_entry_point('borgmatic==1.5.9', 'console_scripts', 'borgmatic')() File "/usr/lib/python3.8/site-packages/borgmatic/commands/borgmatic.py", line 743, in main config_filenames = tuple(collect.collect_config_filenames(global_arguments.config_paths)) File "/usr/lib/python3.8/site-packages/borgmatic/config/collect.py", line 47, in collect_config_filenames for filename in sorted(os.listdir(path)): PermissionError: [Errno 13] Permission denied: '/etc/borgmatic.d' ``` #### Expected behavior (if a bug) When run as normal user, borgmatic should skip non-readable folders. System wide configuration files are often for root, especially since the config file can contain sensitive data (especially the passphrase). So Fedora chose to package the configuration directory with restrictive permissions. #### Other notes / implementation ideas Either completly skip non-readable directories or issue a warning instead of a hard error #### Environment **borgmatic version:** 1.5.9 **borgmatic installation method:** Fedora **Borg version:** 1.1.13 **Python version:** 3.8.5 **operating system and version:** Fedora 32

witten commented 2020-08-08 19:22:30 +00:00

Owner

Copy Link

Totally agree that this looks like a bug! Ideally, borgmatic should never present an error to a user as a traceback. And your suggestion about skipping non-readable directories sounds reasonable to me. Thank you for bringing this to my attention.

Totally agree that this looks like a bug! Ideally, borgmatic should never present an error to a user as a traceback. And your suggestion about skipping non-readable directories sounds reasonable to me. Thank you for bringing this to my attention.

witten added the

bug

label 2020-08-08 19:22:37 +00:00

witten referenced this issue from a commit 2020-08-12 18:35:35 +00:00

Fix traceback when a configuration directory is non-readable due to directory permissions (#350).

witten commented 2020-08-12 18:36:35 +00:00

Owner

Copy Link

This is fixed in master now! Non-readable configuration directories are silently skipped. This fix will be part of the next release. Thanks again!

This is fixed in master now! Non-readable configuration directories are silently skipped. This fix will be part of the next release. Thanks again!

witten closed this issue 2020-08-12 18:36:35 +00:00

apollo13 commented 2020-08-12 19:50:35 +00:00

Author

Copy Link

Lovely, thank you for the quick fix -- now I no longer have to remove /etc/borgmatic.d after every fedora update :)

Lovely, thank you for the quick fix -- now I no longer have to remove `/etc/borgmatic.d` after every fedora update :)

witten commented 2020-08-21 21:34:50 +00:00

Owner

Copy Link

Just released in borgmatic 1.5.10!

Just released in borgmatic 1.5.10!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#350

No description provided.