Automatically retry backups for n times

import_bot commented

2018-01-05 05:34:05 +00:00

Collaborator

To handle connection issues (such as SSH's "broken pipe", which you cannot always prevent) you might want to add an option to retry backups (for n times) when they fail.

This is what I've also explained here: https://github.com/borgbackup/borg/issues/636#issuecomment-257319412

Imported from Taiga issue 27 (to do). Created on 2016-10-31T15:55:36+0000 by rugk.

To handle connection issues (such as SSH's "broken pipe", which you cannot always prevent) you might want to add an option to retry backups (for n times) when they fail. This is what I've also explained here: https://github.com/borgbackup/borg/issues/636#issuecomment-257319412 --- Imported from Taiga issue 27 (to do). Created on 2016-10-31T15:55:36+0000 by rugk.

👍 2

decentral1se commented

2019-10-20 11:07:38 +00:00

Contributor

This would be good. Any indication on how this could be setup in the schema?

https://projects.torsion.org/witten/borgmatic/src/branch/master/borgmatic/config/schema.yaml

Simply adding a "num_retry" somewhere around here? https://projects.torsion.org/witten/borgmatic/src/branch/master/borgmatic/config/schema.yaml#L129

This would be good. Any indication on how this could be setup in the schema? > https://projects.torsion.org/witten/borgmatic/src/branch/master/borgmatic/config/schema.yaml Simply adding a "num_retry" somewhere around here? https://projects.torsion.org/witten/borgmatic/src/branch/master/borgmatic/config/schema.yaml#L129

witten commented

2019-10-21 00:15:47 +00:00

Owner

Yup, the storage section seems like the logical place, given precedent. I might just call it retries or retries_count though.

Variant idea: Make retrying some number of times the default behavior, and perhaps don't even make it configurable at all; just hard-coded. Rationale: Almost everyone probably wants retrying on, and anyone who really cares about when retries are happening can go spelunking in the logs.

Thoughts? I don't feel super strongly either way.

Yup, the `storage` section seems like the logical place, given precedent. I might just call it `retries` or `retries_count` though. Variant idea: Make retrying some number of times the default behavior, and perhaps don't even make it configurable at all; just hard-coded. Rationale: Almost everyone probably wants retrying on, and anyone who really cares about when retries are happening can go spelunking in the logs. Thoughts? I don't feel super strongly either way.

kelson42 commented

2020-11-11 08:17:32 +00:00

retries looks good to me.

`retries` looks good to me.

robertschulze commented

2020-11-11 08:37:15 +00:00

+1 to make it some number of retries the default, e.g. 3 sounds reasonable

👍 1

cadamswaite referenced this issue

2021-07-14 22:08:28 +00:00

Retry failing backups #432

witten referenced this issue from a commit

2021-11-15 19:34:26 +00:00

Retry failing backups (#28, #432).

witten referenced this issue from a commit

2021-11-15 19:51:56 +00:00

Rename retry_timeout to retry_wait and standardize log formatting (#28).

witten commented

2021-11-15 19:54:32 +00:00

Owner

New retries and retry_wait options in the storage section of configuration should take care of this in the next release, courtesy of @cadamswaite. The default is zero retries, but I'm open to changing that.

New `retries` and `retry_wait` options in the `storage` section of configuration should take care of this in the next release, courtesy of @cadamswaite. The default is zero retries, but I'm open to changing that.

witten closed this issue

2021-11-15 19:54:32 +00:00

witten commented

2021-11-22 21:21:58 +00:00

Owner

Just released in borgmatic 1.5.21!

jurgenhaas commented

2022-01-11 07:05:11 +00:00

I'm running version 1.5.22 but I get these error messages when using retries and retry_wait:

/etc/borgmatic.d/drupal_site30002.yaml: Error parsing configuration file
An error occurred while parsing a configuration file at /etc/borgmatic.d/drupal_site30002.yaml:
Key 'retries' was not defined. Path: '/storage'
Key 'retry_wait' was not defined. Path: '/storage'

The config file looks like this:

storage:
    encryption_passphrase: 'something'
    retries: 1
    retry_wait: 300

What am I doing wrong?

I'm running version 1.5.22 but I get these error messages when using `retries` and `retry_wait`: ``` /etc/borgmatic.d/drupal_site30002.yaml: Error parsing configuration file An error occurred while parsing a configuration file at /etc/borgmatic.d/drupal_site30002.yaml: Key 'retries' was not defined. Path: '/storage' Key 'retry_wait' was not defined. Path: '/storage' ``` The config file looks like this: ``` storage: encryption_passphrase: 'something' retries: 1 retry_wait: 300 ``` What am I doing wrong?

witten commented

2022-01-11 07:09:41 +00:00

Owner

That configuration looks correct to me! Can you confirm the version you're running? borgmatic --version should do it.

That configuration looks correct to me! Can you confirm the version you're running? `borgmatic --version` should do it.

jurgenhaas commented

2022-01-11 07:10:40 +00:00

Yes, it's 1.5.22

witten commented

2022-01-11 07:11:33 +00:00

Owner

In that case, can you try posting your entire (redacted) configuration file and I'll see if I can reproduce the problem? It might be easiest to open a new ticket for that.

jurgenhaas commented

2022-01-11 07:41:01 +00:00

@witten I'm very confused and sorry for the noice I've made here. I was just about to start a new issue and while collecting the details and retrying everything, it suddenly started to work without any issue. Although I'm having the error logs and a git repo with all the history for the config files, where nothing has changed since I added the retry settings, it failed yesterday and works correctly now. Performed a few more tests, but I can't explain what was going wrong. I keep monitoring this and get back to a new issue, when something similar should happen again.

👍 1

Rows
Columns

Automatically retry backups for n times #28