borgmatic-collective/borgmatic
borgmatic-collective/borgmatic
Watch
9
74
Fork
You've already forked borgmatic
 57
Code Issues 71 Pull requests 3 Releases 162 Packages 1 Activity Actions 1

Clarify when Healthchecks/Cronitor hooks fire in relation to other hooks #238

New issue
Closed
opened 2019-11-05 05:29:40 +00:00 by witten · 1 comment
witten commented 2019-11-05 05:29:40 +00:00
Owner
Copy link

It's become apparent that it's not at all clear when Healthchecks/Cronitor hooks fire in relation to the traditional command/script hooks, especially given the ordering in the YAML configuration file. So as part of this ticket, update both the docs and the schema to make this much clearer.

For the record, here's the sequence of events for a successful backup as per current code:

  1. Start Healthchecks.
  2. Start Cronitor.
  3. Fire all before_backups hooks.
  4. Dump databases.
  5. Run backups.
  6. Remove database dumps.
  7. Fire all after_backups hooks.
  8. Complete Healthchecks.
  9. Complete Cronitor.

In the case of error, the last few steps are changed to:

  1. Fire all on_error hooks.
  2. Fail Healthchecks.
  3. Fail Cronitor.
It's become apparent that it's not at all clear when Healthchecks/Cronitor hooks fire in relation to the traditional command/script hooks, especially given the ordering in the YAML configuration file. So as part of this ticket, update both the docs and the schema to make this much clearer. For the record, here's the sequence of events for a successful backup as per current code: 1. Start Healthchecks. 2. Start Cronitor. 3. Fire all before_backups hooks. 4. Dump databases. 5. Run backups. 6. Remove database dumps. 7. Fire all after_backups hooks. 8. Complete Healthchecks. 9. Complete Cronitor. In the case of error, the last few steps are changed to: 6. Fire all on_error hooks. 7. Fail Healthchecks. 8. Fail Cronitor.
witten commented 2019-11-06 18:13:56 +00:00
Author
Owner
Copy link

borgmatic 1.4.7.

borgmatic 1.4.7.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
parallel-borgmatic
command-hook-steps
2.1.7
2.1.6
2.1.5
2.1.4
2.1.3
2.1.2
2.1.1
2.1.0
2.0.13
2.0.12
2.0.11
2.0.10
2.0.9
2.0.8
2.0.7
2.0.6
2.0.5
2.0.4
2.0.3
2.0.2
2.0.1
2.0.0
1.9.14
1.9.13
1.9.12
1.9.11
1.9.10
1.9.9
1.9.8
1.9.7
1.9.6
1.9.5
1.9.4
1.9.3
1.9.2
1.9.1
1.9.0
1.8.14
1.8.13
1.8.12
1.8.11
1.8.10
1.8.9
1.8.8
1.8.7
1.8.6
1.8.5
1.8.4
1.8.3
1.8.2
1.8.1
1.8.0
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.5.24
1.5.23
1.5.22
1.5.21
1.5.20
1.5.19
1.5.18
1.5.17
1.5.16
1.5.15
1.5.14
1.5.13
1.5.12
1.5.11
1.5.10
1.5.9
1.5.8
1.5.7
1.5.7.dev0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.22
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.26
1.3.25
1.3.24
1.3.23
1.3.22
1.3.21
1.3.20
1.3.19
1.3.18
1.3.17
1.3.16
1.3.15
1.3.14
1.3.13
1.3.12
1.3.11
1.3.10
1.3.9
1.3.8
1.3.7
1.3.6
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.18
1.2.17
1.2.16
1.2.15
1.2.14
1.2.13
1.2.12
1.2.11
1.2.10
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.3
1.0.2
1.0.1
1.0.0
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.7
0.0.6
0.0.5
0.0.4
0.0.3
0.0.2
Labels
Clear labels   
blocked

   
breaking

   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No labels
blocked
breaking
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
borgmatic-collective/borgmatic#238
No description provided.