Hooks exiting with exit code 1 do not cause backup to fail #214

New Issue

Closed

opened 2019-09-12 17:14:26 +00:00 by brakhane · 5 comments

brakhane commented 2019-09-12 17:14:26 +00:00

Copy Link

Actual behaviour

I have set up a few before_hooks that run scripts that dump data from docker containers
so that this data can be backed up too.

When an error occurs, the scripts exit with error code 1; borgmatic is happy to continue however, causing me to have an incomplete backup without me noticing, since I only get notified when a backup failed.

I can work around it by using "script.sh || exit 2", but AFAICT the documentation does not mention that exit code 1 is treated as success.

Expected behaviour

I expect borgmatic to either stop the backup when a hook exits with 1, or the fact that only 2+ causes the backup to abort to be documented.

Environment

borgmatic version: 1.3.14

### Actual behaviour I have set up a few before_hooks that run scripts that dump data from docker containers so that this data can be backed up too. When an error occurs, the scripts exit with error code 1; borgmatic is happy to continue however, causing me to have an incomplete backup without me noticing, since I only get notified when a backup failed. I can work around it by using "script.sh || exit 2", but AFAICT the documentation does not mention that exit code 1 is treated as success. ### Expected behaviour I expect borgmatic to either stop the backup when a hook exits with 1, or the fact that only 2+ causes the backup to abort to be documented. #### Environment **borgmatic version:** 1.3.14

witten commented 2019-09-12 18:45:26 +00:00

Owner

Copy Link

Can I have a look at your hook configuration, and perhaps the output of a borgmatic --verbosity 2 run when this happens? That'd help me understand what's going on. As far as I know, the borgmatic code does not treat exit code 1 differently from exit code 2 for purposes of interpreting hook errors.

Can I have a look at your hook configuration, and perhaps the output of a `borgmatic --verbosity 2` run when this happens? That'd help me understand what's going on. As far as I know, the borgmatic code does not treat exit code 1 differently from exit code 2 for purposes of interpreting hook errors.

witten added the

question / support

label 2019-09-12 18:45:33 +00:00

brakhane commented 2019-09-12 20:37:25 +00:00

Author

Copy Link

It does:

https://projects.torsion.org/witten/borgmatic/src/branch/master/borgmatic/execute.py#L35

It does: https://projects.torsion.org/witten/borgmatic/src/branch/master/borgmatic/execute.py#L35

witten commented 2019-09-12 20:43:55 +00:00

Owner

Copy Link

So it does! I forgot that hooks now go through that code path.

So it does! I forgot that hooks now go through that code path.

witten added

bug

and removed

question / support

labels 2019-09-12 20:44:14 +00:00

witten referenced this issue from a commit 2019-09-12 23:38:58 +00:00

Fix for hook erroring with exit code 1 not being interpreted as an error (#214).

witten commented 2019-09-12 23:39:50 +00:00

Owner

Copy Link

This is fixed in master. This fix will go out as part of the next release (hopefully soon). Thanks for reporting it!

This is fixed in master. This fix will go out as part of the next release (hopefully soon). Thanks for reporting it!

witten closed this issue 2019-09-12 23:39:50 +00:00

witten commented 2019-09-13 04:38:44 +00:00

Owner

Copy Link

And now released as part of borgmatic 1.3.15!

And now released as part of borgmatic 1.3.15!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#214

No description provided.