Labels Milestones

New Issue

patterns and patterns_from do not work with relative dirs in pattern #212

Closed

opened 3 years ago by Alkac · 3 comments

Alkac commented 3 years ago

What I'm trying to do and why

I had own script with Borg backup using patterns file - that worked. Now migrated to borgmatic and all the patterns are ignored.

Steps to reproduce (if a bug)

Create config.yaml with:

location:
    patterns_from:
        - /etc/borgmatic/default.patterns

and

$ cat /etc/borgmatic/default.patterns
P sh
R /
- lv_data

Actual behavior (if a bug)

The path /lv_data is backed up.

Expected behavior (if a bug)

The path /lv_data is excluded from backup.

Other notes / implementation ideas

As per borg help patterns:

... When you give /absolute/ as root, they will look like /absolute/…/file.ext. This is meant when we talk about “full path” below.

Hence R / and - lv_data should result to - /lv_data.

Environment

borgmatic version: 1.3.13-1

borgmatic installation method: AUR Arch package

Borg version: 1.1.10-1

Python version: 3.7.4

operating system and version: Arch Linux x86_64, up-to-date

#### What I'm trying to do and why I had own script with Borg backup using patterns file - that worked. Now migrated to borgmatic and all the patterns are ignored. #### Steps to reproduce (if a bug) Create config.yaml with: ``` location: patterns_from: - /etc/borgmatic/default.patterns ``` and ``` $ cat /etc/borgmatic/default.patterns P sh R / - lv_data ``` #### Actual behavior (if a bug) The path /lv_data is backed up. #### Expected behavior (if a bug) The path /lv_data is excluded from backup. #### Other notes / implementation ideas As per `borg help patterns`: *... When you give /absolute/ as root, they will look like /absolute/…/file.ext. This is meant when we talk about “full path” below.* Hence `R /` and `- lv_data` should result to `- /lv_data`. #### Environment **borgmatic version:** 1.3.13-1 **borgmatic installation method:** AUR Arch package **Borg version:** 1.1.10-1 **Python version:** 3.7.4 **operating system and version:** Arch Linux x86_64, up-to-date

witten commented 3 years ago

Owner

Would it be possible to run borgmatic with --verbosity 2 so we can see the exact flags that borgmatic passes to Borg? That would help me narrow down the problem. Thanks!

Note that borgmatic doesn't do any pre-processing of the patterns files.. It should just be passing the filenames through directly to Borg.

Would it be possible to run borgmatic with `--verbosity 2` so we can see the exact flags that borgmatic passes to Borg? That would help me narrow down the problem. Thanks! Note that borgmatic doesn't do any pre-processing of the patterns files.. It *should* just be passing the filenames through directly to Borg.

witten added the

question / support

label 3 years ago

Alkac commented 3 years ago

Poster

Hm. My mistake. In my original scripts, I probably used relative path for backup, like

cd /
borg create --patterns-from /some/patters repo::archive .

Which then requires patterns like ! home/johny

However, when using:

borg create --patterns-from /some/patters repo::archive /

Then the patterns must be like ! /home/johny.

The Borg docs do say that, however in a not so well comprehensible way...

P.S. I noted some other bug with borgmatic and will report it separately.

Hm. My mistake. In my original scripts, I probably used _relative_ path for backup, like ``` cd / borg create --patterns-from /some/patters repo::archive . ``` Which then requires patterns like `! home/johny` However, when using: ``` borg create --patterns-from /some/patters repo::archive / ``` Then the patterns must be like `! /home/johny`. The Borg docs do say that, however in a not so well comprehensible way... P.S. I noted some other bug with borgmatic and will report it separately.

Alkac closed this issue 3 years ago

witten commented 3 years ago

Owner

Glad to hear this one is cleared up!

Glad to hear this one is cleared up!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

end-to-end-database-tests

master

stream-database-dumps

0.0.2

0.0.3

0.0.4

0.0.5

0.0.6

0.0.7

0.1.0

0.1.1

0.1.2

0.1.3

0.1.4

0.1.5

0.1.6

0.1.7

0.1.8

1.0.0

1.0.1

1.0.2

1.0.3

1.1.0

1.1.1

1.1.10

1.1.11

1.1.12

1.1.13

1.1.14

1.1.15

1.1.2

1.1.3

1.1.4

1.1.5

1.1.6

1.1.7

1.1.9

1.2.0

1.2.1

1.2.10

1.2.11

1.2.12

1.2.13

1.2.14

1.2.15

1.2.16

1.2.17

1.2.18

1.2.2

1.2.3

1.2.4

1.2.5

1.2.6

1.2.7

1.2.8

1.2.9

1.3.0

1.3.1

1.3.10

1.3.11

1.3.12

1.3.13

1.3.14

1.3.15

1.3.16

1.3.17

1.3.18

1.3.19

1.3.2

1.3.20

1.3.21

1.3.22

1.3.23

1.3.24

1.3.25

1.3.26

1.3.3

1.3.4

1.3.5

1.3.6

1.3.7

1.3.8

1.3.9

1.4.0

1.4.1

1.4.10

1.4.11

1.4.12

1.4.13

1.4.14

1.4.15

1.4.16

1.4.17

1.4.18

1.4.19

1.4.2

1.4.20

1.4.21

1.4.22

1.4.3

1.4.4

1.4.5

1.4.6

1.4.7

1.4.8

1.4.9

1.5.0

1.5.1

1.5.10

1.5.11

1.5.12

1.5.13

1.5.14

1.5.15

1.5.16

1.5.17

1.5.18

1.5.19

1.5.2

1.5.20

1.5.21

1.5.22

1.5.23

1.5.24

1.5.3

1.5.4

1.5.5

1.5.6

1.5.7

1.5.7.dev0

1.5.8

1.5.9

1.6.0

1.6.1

1.6.2

1.6.3

1.6.4

1.6.5

Labels

Apply labels

Clear labels

bug data loss design finalized question / support security waiting for response

No Label bug data loss design finalized question / support security waiting for response

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.