error but not really #202

New Issue

Closed

opened 2019-07-19 08:02:48 +00:00 by predmijat · 3 comments

predmijat commented 2019-07-19 08:02:48 +00:00

Copy Link

What I'm trying to do and why

borgmatic via crontab with "on_error" and "after_backup" hooks

Steps to reproduce (if a bug)

in crontab: 30 4 * * * root /usr/local/bin/borgmatic > /dev/null 2>&1

in config.yaml:

...
hooks:
...
  after_backup:
    #    - echo "Backup created."
        - /root/borg/hooks/ok.sh
  on_error:
    #    - echo "Error while creating a backup."
        - /root/borg/hooks/error.sh
...

error.sh is just curl -X POST ... to Slack channel

I got notification on Slack that there was an error - note that ok.sh didn't execute.

But when I SSH-ed and ran borgmatic info --last 1 everything seemed fine...Time (start), Time (end), duration, normal output...

I need help figuring out what happened :)

Environment

borgmatic version: 1.3.12

borgmatic installation method: pip3

Borg version: borg 1.1.9

Python version: Python 3.6.8

operating system and version: CentOS Linux release 7.6.1810 (Core)

EDIT: after inspecting /var/log/messages it seems that borgmatic finished successfully, but ok.sh failed (something with /var/tmp/systemd-private... and mariadb), and when that failed, borgmatic ran error.sh...

#### What I'm trying to do and why borgmatic via crontab with "on_error" and "after_backup" hooks #### Steps to reproduce (if a bug) in crontab: `30 4 * * * root /usr/local/bin/borgmatic > /dev/null 2>&1` in `config.yaml`: ``` ... hooks: ... after_backup: # - echo "Backup created." - /root/borg/hooks/ok.sh on_error: # - echo "Error while creating a backup." - /root/borg/hooks/error.sh ... ``` error.sh is just `curl -X POST ... ` to Slack channel I got notification on Slack that there was an error - note that `ok.sh` didn't execute. But when I SSH-ed and ran `borgmatic info --last 1` everything seemed fine...Time (start), Time (end), duration, normal output... I need help figuring out what happened :) #### Environment **borgmatic version:** 1.3.12 **borgmatic installation method:** pip3 **Borg version:** borg 1.1.9 **Python version:** Python 3.6.8 **operating system and version:** CentOS Linux release 7.6.1810 (Core) EDIT: after inspecting `/var/log/messages` it seems that borgmatic finished successfully, but `ok.sh` failed (something with `/var/tmp/systemd-private...` and mariadb), and when that failed, borgmatic ran `error.sh`...

witten commented 2019-07-19 16:02:18 +00:00

Owner

Copy Link

Thanks for filing the detailed report! Based on the behavior you described, it sounds like borgmatic is running the on_error hook only once the after_backup hook fails. Which sounds like correct behavior to me: Any cleanup steps you might run in an after backup hook are probably important to do, and should trigger an error hook if they fail. However, if you have other expectations, please talk about what you'd like to see instead! Or perhaps some additional logging would make it clearer as to what's going on? Thanks.

Thanks for filing the detailed report! Based on the behavior you described, it sounds like borgmatic is running the `on_error` hook only once the `after_backup` hook fails. Which sounds like correct behavior to me: Any cleanup steps you might run in an after backup hook are probably important to do, and should trigger an error hook if they fail. However, if you have other expectations, please talk about what you'd like to see instead! Or perhaps some additional logging would make it clearer as to what's going on? Thanks.

predmijat commented 2019-07-19 16:20:19 +00:00

Author

Copy Link

I was just under the impression that "on_error" would run if something with backup fails, not if backup was fine but "after_backup" fails.

This behavior is fine when I'm aware of it, maybe just a note in that section of .yaml?

I was just under the impression that "on_error" would run if something with backup fails, not if backup was fine but "after_backup" fails. This behavior is fine when I'm aware of it, maybe just a note in that section of .yaml?

predmijat closed this issue 2019-07-19 16:20:19 +00:00

witten commented 2019-07-19 16:21:12 +00:00

Owner

Copy Link

Sure, I will update the comments/docs accordingly. Thanks again for reporting!

Sure, I will update the comments/docs accordingly. Thanks again for reporting!

👍 1

witten referenced this issue from a commit 2019-07-19 16:27:08 +00:00

Clarify documentation/schema about on_error hook running if there's an error in another hook (#202).

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#202

No description provided.