Borg create errors don't show up at borgmatic verbosity zero #198

New Issue

Closed

opened 2019-06-22 00:30:03 +00:00 by witten · 2 comments

witten commented 2019-06-22 00:30:03 +00:00

Owner

Copy Link

What I'm trying to do and why

When Borg encounters an issue during archive creation (e.g. repository not found), if I'm at borgmatic verbosity level zero (the default), I see that there was an error, but I don't see any of Borg's output. This makes it difficult to debug the error without getting a repro and upping borgmatic's verbosity to one or higher.

Steps to reproduce

Run borgmatic --create with borgmatic's config file referencing a repository that doesn't exist.

Actual behavior

borgmatic says that there was an error with the Borg command, with no indication as to what the error was.

Expected behavior

Borg's output/error is displayed.

Other notes / implementation ideas

Right now, all Borg create output is logged at INFO level.. with the exception of lines that start with the string "borg: error:", which are logged at ERROR. So upping the log level either all the time or only at certain verbosity levels would be one option.

#### What I'm trying to do and why When Borg encounters an issue during archive creation (e.g. repository not found), if I'm at borgmatic verbosity level zero (the default), I see that there was an error, but I don't see any of Borg's output. This makes it difficult to debug the error without getting a repro and upping borgmatic's verbosity to one or higher. #### Steps to reproduce Run `borgmatic --create` with borgmatic's config file referencing a repository that doesn't exist. #### Actual behavior borgmatic says that there was an error with the Borg command, with no indication as to what the error was. #### Expected behavior Borg's output/error is displayed. #### Other notes / implementation ideas Right now, all Borg create output is logged at INFO level.. with the exception of lines that start with the string "borg: error:", which are logged at ERROR. So upping the log level either all the time or only at certain verbosity levels would be one option.

witten added the

bug

label 2019-06-22 00:30:10 +00:00

witten commented 2019-06-24 05:00:23 +00:00

Author

Owner

Copy Link

I have a potential solution for this. Briefly: Record a sliding window of tailed Borg output until Borg exits. If Borg exits non-zero, include the recorded output in the summary at the end of execution. That way, 1. Logging continues to be real-time, 2. Logging at verbosity zero during a successful run continues to be mostly silent, and 3. Any output from a failed Borg run get surfaced as log level error (meaning it surfaces at any verbosity level).

The main downside of this solution is that some of this output can be repeated if the verbosity level is high, but that's mitigated by truncating it to the last n lines.

I have a potential solution for this. Briefly: Record a sliding window of tailed Borg output until Borg exits. If Borg exits non-zero, include the recorded output in the summary at the end of execution. That way, 1. Logging continues to be real-time, 2. Logging at verbosity zero during a successful run continues to be mostly silent, and 3. Any output from a failed Borg run get surfaced as log level error (meaning it surfaces at any verbosity level). The main downside of this solution is that some of this output can be repeated if the verbosity level is high, but that's mitigated by truncating it to the last n lines.

witten referenced this issue from a commit 2019-06-24 16:57:00 +00:00

Fix for Borg create error output not showing up at borgmatic verbosity level zero (#198).

witten commented 2019-06-24 16:58:17 +00:00

Author

Owner

Copy Link

Just fixed this as described above, and released the fix in borgmatic 1.3.10.

Just fixed this as described above, and released the fix in borgmatic 1.3.10.

witten closed this issue 2019-06-24 16:58:17 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#198

No description provided.