Pass through all options (that make sense) to wrapped borg commands #193

New Issue

Closed

opened 2019-06-16 17:54:19 +00:00 by elho · 4 comments

elho commented 2019-06-16 17:54:19 +00:00

Copy Link

There are a number of optinons the borg commands that are wrapped support, that are not passed though.
Some may not make sense, as being handled by the config, but those that do, should be possible to specify.

Examples would be --short' and '--last' for the --listcommand.borg listsupports them, butborgmatic --list` does not.

There are a number of optinons the borg commands that are wrapped support, that are not passed though. Some may not make sense, as being handled by the config, but those that do, should be possible to specify. Examples would be `--short' and '--last' for the `--list` command. `borg list` supports them, but `borgmatic --list` does not.

witten commented 2019-06-17 01:06:21 +00:00

Owner

Copy Link

I've generally been implementing these on an as-needed / as-issue-filed basis rather than trying to go for a comprehensive full-coverage sweep. (See witten/borgmatic#14 for more info.)

Do you have more in mind besides --list's --short and --last?

I've generally been implementing these on an as-needed / as-issue-filed basis rather than trying to go for a comprehensive full-coverage sweep. (See https://projects.torsion.org/witten/borgmatic/issues/14 for more info.) Do you have more in mind besides `--list`'s `--short` and `--last`?

elho commented 2019-06-17 20:51:39 +00:00

Author

Copy Link

Some in mind, others I will only find out over time using borgmatic more, but each time there would be the turnaround time between ticket and release and yet more till one's distro ships that release or the extra effort of bulding a newer package yoruself (I did that now to try borgmatic, but in the long run, it should just be usable with a stable distro release).

AS for list, there's --prefix and --format, for create there may be --noatime, which I didn't make my mind up over yet.

Some in mind, others I will only find out over time using borgmatic more, but each time there would be the turnaround time between ticket and release and yet more till one's distro ships that release or the extra effort of bulding a newer package yoruself (I did that now to try borgmatic, but in the long run, it should just be usable with a stable distro release). AS for `list`, there's `--prefix` and `--format`, for `create` there may be `--noatime`, which I didn't make my mind up over yet.

elho commented 2019-06-19 14:21:26 +00:00

Author

Copy Link

Correction: While --noatime is indeed missing, it rather is something that should be a config option.

Correction: While `--noatime` is indeed missing, it rather is something that should be a config option.

witten referenced this issue from a commit 2019-06-25 17:19:34 +00:00

Pass through several "borg list" flags (#193).

witten referenced this issue from a commit 2019-06-25 18:16:06 +00:00

Support for several more borgmatic/borg info command-line flags (#193).

witten referenced this issue from a commit 2019-06-25 18:32:12 +00:00

Support for Borg --noatime, --noctime, and --nobirthtime flags (mentioned in #193).

witten commented 2019-06-25 18:40:34 +00:00

Owner

Copy Link

Done and released with borgmatic 1.3.11. I implemented pass-throughs for all list-specific flags, all info-specific flags, and I added a couple of new config file options like atime in the location section. There still may be the odd flag here or there that needs coverage (especially with create), so please feel free to file follow-up tickets.

I did do some investment in making it easier to add these in the future. And I should note that having real sub-commands did make this go more smoothly!

Done and released with borgmatic 1.3.11. I implemented pass-throughs for all list-specific flags, all info-specific flags, and I added a couple of new config file options like `atime` in the location section. There still may be the odd flag here or there that needs coverage (especially with `create`), so please feel free to file follow-up tickets. I did do some investment in making it easier to add these in the future. And I should note that having real sub-commands did make this go more smoothly!

witten closed this issue 2019-06-25 18:40:35 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

command-hook-steps

2.0.13

2.0.12

2.0.11

2.0.10

2.0.9

2.0.8

2.0.7

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.9.14

1.9.13

1.9.12

1.9.11

1.9.10

1.9.9

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels

blocked

breaking

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

No Label

Milestone

No items

No Milestone

Assignees

Clear assignees

witten

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#193