Merged Configs and Healthchecks (monitoring) #1338
Labels
No labels
blocked
breaking
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No milestone
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
borgmatic-collective/borgmatic#1338
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What I'm trying to do and why
I'm attempting to use the merging facility to override some options on a per repo basis (say there are two repos).
Previously, the Healthchecks feature would run on the file as a whole, so one entry covering the the start, log and error state of anything that happens.
If I split out the config to a common include, I expect the healthcheck to process twice. Since this is not being overridden, this means these will go to the same healthcheck endpoint. In the worst case, that means if the second repo operation succeeds where the first failed, then the failure might be obscured.
If that's correct, is the expectation to use a separate HC endpoint per file?
Steps to reproduce
include/common.yaml:
repo1.yaml:
repo2.yaml:
borgmatic version
1.9.14
borgmatic installation method
pip
I think everything you said here is correct. Monitoring hooks currently run at the configuration file level—so
startfires before all repositories in a particular configuration file run, andfinishfires after them. So yes, a separate Healthchecks endpoint per configuration file makes sense!Thanks. I've requested a feature to discuss functionality related to this.
Sounds good! (For reference: #1339)