extract to a destination with a relative path is broken #1280
Labels
No labels
blocked
breaking
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
borgmatic-collective/borgmatic#1280
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What I'm trying to do and why
Took an update to the SynoCommunity borg package and my test extract with a relative path failed. The update bumped borgmatic from 2.0.12 to 2.1.2, borg was already at 1.4.3.
Steps to reproduce
take the update with this changelist
from:
to:
Actual behavior
The destination directory specified by
--destinationis emptyusing
-v 2on the extract command, the output lists the requested file, but no output is created in the folder specified by--destinationThe tail of the debug outlook looks like this:
Expected behavior
The extracted files should appear in the destination directory
Other notes / implementation ideas
borgmatic version
2.1.2
borgmatic installation method
synology package
Borg version
borg 1.4.3
Python version
Python 3.8.15
Database version (if applicable)
No response
Operating system and version
DSM 7.3.2
I can't seem to repro this on my end. Can you provide more details about:
extractwithout getting the expected file (redacted as necessary)Alternatively, if you can create and share a minimal repro starting from example config and a fresh repo, that could work too.
thank you for looking into this so quickly!
config:
log:
Thanks for providing that info. I notice that you've got a
working_directoryconfigured, which borgmatic applies to all (well, most) relative paths. So in this case, if you're doing anextractwith--destination testand this config, I'd expect the resulting file(s) to end up in/volume1/borg/test(assuming that directory exists)—nottestin your current directory. So do you see the extracted file(s) in/volume1/borg/test?aaand... there's the extracted file!
I have an overlay yaml that I use on a non-synology host which changes base to be the same directory where I run the tests on that machine. I think I've tested extractions on the synology itself in the past and they worked, but... I can't prove that.
Thank you for your help, and your patience. While I have your attention: thank you also for maintaining this tool, which is far better than any other remote backup tool I've found on the synology.
I'm glad to hear that was it!
Hah okay. The working directory semantics have changed with various borgmatic releases, so it's possible it worked on an older version of borgmatic.
Sure thing. And thank you for using it!